Bruce Dubbs via blfs-support wrote:
On 8/20/19 1:42 AM, Pierre Labastie via blfs-support wrote:
Bruce Dubbs via blfs-support wrote:
[...]
I think having ECM in /opt does not prevent having the icons in /usr.
ECM is only used at build time anyway. Will try to rebuild those with
ECM in /opt. Also phonon seems to need ECM. Actually, phonon is only
used for KDE, so could go into /opt too. Will try all these.
No, but if the user is not building kf5, then it would be the only
thing kf5 related in /opt. Where would you put it? /opt/share? Right
now everyting is installed in /usr/share/ECM.
Good point. So let's keep ECM in /usr.
[...]
I tried commenting out the following:
#include(CMakeFindDependencyMacro)
#find_dependency(KF5Plasma "5.61.0")
I wouldn't do that. It prevents checking the presence of dependencies
of dependencies...
This is not a problem if following the book, of course, since deps are
built. But if a user departs from the book (this happens quite often),
weird errors may be reported if not all the deps are installed, and
their presence has not been checked.
It's unclear to my why including a file that just defines a macro
would change PACKAGE_PREFIX_DIR. That variable is not even defined
in the included file.
Including the file does not change the variable,
It did for me. I added a message() immediately before and after the
include statement to print out the value of PACKAGE_PREFIX_DIR and it
changed immediately after the include statement.
You sure? I ran cmake in trace mode, and the variable only changed when
including ECMConfig.cmake (which is included during execution of the
macro find_dependency).
Anyway, where and when the variable is changed is not important. We just
have to prevent it to be changed, or to reset it right after running the
macro. Maybe save it at the beginning of ECMConfig.cmake, and reset it
at the end (clean, but tricky sed, tentative below), or rerun
get_filename_component(...) after the macro has been called.
sed -e '/PACKAGE_INIT/i set(SAVE_PACKAGE_PREFIX_DIR
"${PACKAGE_PREFIX_DIR}")' \
-e '/^include/a set(PACKAGE_PREFIX_DIR "${SAVE_PACKAGE_PREFIX_DIR}")'
-i ECMConfig.cmake.in
(before starting building ECM)
Pierre
--
http://lists.linuxfromscratch.org/listinfo/blfs-support
FAQ: http://www.linuxfromscratch.org/blfs/faq.html
Unsubscribe: See the above information page
