On Tue, Dec 01, 2020 at 02:07:38PM -0600, Douglas R. Reno via blfs-support wrote: > > On 12/1/20 1:08 PM, Ken Moffat via blfs-support wrote: > > On Tue, Dec 01, 2020 at 09:27:32AM -0600, Douglas R. Reno via blfs-support > > wrote: > > > > > Ah, I missed that (rebuilt meson, retried libsoup). > > > > I'll upload the patch to patches, but I really don't think we need > > > > to recommend sysprof for libsoup. > > > > > > > > ĸen > > > Xi and I were the ones who found the issue. If you don't have sysprof > > > installed, on our systems, libsoup downloaded a git copy of > > > libsysprof-capture-4. Turning sysprof off is an option of course, but it > > > does remove some functionality and it remains to be seen (I guess I'll see > > > here in a day or two since I'm doing a full rebuild for systemd-247) what > > > having that functionality removed actually does... > > > > > I'm vaguely interested in what showed up during the download (if > > details are available). > > > > In theory the choice for sysprof (in libsoup) is auto, so I would > > expect it to be disabled if sysprof is not found, but obviously my > > expectations and what actually happens may differ. > > > > However, if it does download a git copy and you therefore want to > > use system sysprof then meson will need to be patched until the next > > meson release comes out. > > Hi Ken, > > I just moved /usr/lib/libsysprof-capture-4.a and > /usr/lib/pkgconfig/sysprof-capture-4.pc out of the way so I can test this. > Here's the output: > > renodr [ /sources ]$ sh SCRIPTS/libsoup-2.72.0-update.sh > Making libsoup-2.72.0 > Tue Dec 1 02:06:48 PM CST 2020 > patching file tests/ssl-test.c > Initialized empty Git repository in > /sources/libsoup-2.72.0/libsoup-2.72.0/subprojects/sysprof/.git/ > From https://gitlab.gnome.org/GNOME/sysprof > * branch 1bb0eb7798f6a88667681229dde415ed663b1053 -> FETCH_HEAD > Note: switching to '1bb0eb7798f6a88667681229dde415ed663b1053'. > > You are in 'detached HEAD' state. You can look around, make experimental > changes and commit them, and you can discard any commits you make in this > state without impacting any branches by switching back to a branch. > > If you want to create a new branch to retain commits you create, you may > do so (now or later) by using -c with the switch command. Example: > > git switch -c <new-branch-name> > > Or undo this operation with: > > git switch - > > Turn off this advice by setting config variable advice.detachedHead to false > > HEAD is now at 1bb0eb7 Merge branch 'collector-libraries' into 'master' > > [...] > > Run-time dependency sysprof-capture-4 found: NO (tried pkgconfig and cmake) > Looking for a fallback subproject for the dependency sysprof-capture-4 > > |Executing subproject sysprof method meson > | > |Using 'PKG_CONFIG_PATH' from environment with value: > '/opt/kf5/lib/pkgconfig:/opt/qt5/lib/pkgconfig' > |Using 'PKG_CONFIG_PATH' from environment with value: > '/opt/kf5/lib/pkgconfig:/opt/qt5/lib/pkgconfig' > |Project name: sysprof > |Project version: 3.37.1 > |C compiler for the host machine: cc (gcc 10.2.0 "cc (GCC) 10.2.0") > |C linker for the host machine: cc ld.bfd 2.35 > |Compiler for C supports arguments -fvisibility=hidden: YES > |Has header "execinfo.h" : YES > |Checking for function "strlcpy" : NO > |Run-time dependency libunwind-generic found: NO (tried pkgconfig and cmake) > |Checking whether type "struct perf_event_attr" has member "use_clockid" : > YES > |Checking whether type "struct perf_event_attr" has member "clockid" : YES > |Compiler for C supports arguments -Wcast-align: YES > |Compiler for C supports arguments -Wdeclaration-after-statement: YES > (cached) > |Compiler for C supports arguments -Wformat-nonliteral: YES > |Compiler for C supports arguments -Wformat-security: YES > |Compiler for C supports arguments -Wmissing-include-dirs: YES (cached) > |Compiler for C supports arguments -Wnested-externs: YES > |Compiler for C supports arguments -Wno-missing-field-initializers > -Wmissing-field-initializers: YES > |Compiler for C supports arguments -Wno-sign-compare -Wsign-compare: YES > |Compiler for C supports arguments -Wno-unused-parameter -Wunused-parameter: > YES > |Compiler for C supports arguments -Wno-cast-function-type > -Wcast-function-type: YES > |Compiler for C supports arguments -Wpointer-arith: YES (cached) > |Compiler for C supports arguments -Wredundant-decls: YES > |Compiler for C supports arguments -Wswitch-default: YES > |Compiler for C supports arguments -Wswitch-enum: YES > |Compiler for C supports arguments -Wuninitialized: YES > |Compiler for C supports arguments -Werror=format-security -Werror=format=2: > YES > |Compiler for C supports arguments -Werror=empty-body: YES > |Compiler for C supports arguments -Werror=implicit-function-declaration: > YES (cached) > |Compiler for C supports arguments -Werror=incompatible-pointer-types: YES > |Compiler for C supports arguments -Werror=pointer-arith: YES > |Compiler for C supports arguments -Werror=init-self: YES > |Compiler for C supports arguments -Werror=int-conversion: YES > |Compiler for C supports arguments -Werror=misleading-indentation: YES > |Compiler for C supports arguments -Werror=missing-include-dirs: YES > |Compiler for C supports arguments -Werror=overflow: YES > |Compiler for C supports arguments -Werror=parenthesis: NO > |Compiler for C supports arguments -Werror=return-type: YES > |Compiler for C supports arguments -Werror=shadow: YES > |Compiler for C supports arguments -Werror=strict-prototypes: YES > |Compiler for C supports arguments -Werror=undef: YES > |Compiler for C supports arguments -fstack-protector-strong: YES > |Compiler for C supports link arguments -Wl,-z,relro: YES > |Compiler for C supports link arguments -Wl,-z,now: YES > |Configuring sysprof-version.h using configuration > |Run-time dependency threads found: YES > |Configuring config.h using configuration > |Build targets in project: 4 > |Subproject sysprof finished. > > Dependency sysprof-capture-4 from subproject subprojects/sysprof found: YES > 3.37.1 > > [...] > > Found ninja-1.10.0 at /usr/bin/ninja > [1/196] Compiling C object > subprojects/sysprof/src/libsysprof-capture/libsysprof-capture-4.a.p/sysprof-address.c.o > [2/196] Compiling C object > subprojects/sysprof/src/libsysprof-capture/libsysprof-capture-4.a.p/sysprof-capture-cursor.c.o > [3/196] Compiling C object > subprojects/sysprof/src/libsysprof-capture/libsysprof-capture-4.a.p/sysprof-capture-util.c.o > [4/196] Compiling C object > subprojects/sysprof/src/libsysprof-capture/libsysprof-capture-4.a.p/sysprof-capture-condition.c.o > [5/196] Compiling C object > subprojects/sysprof/src/libsysprof-capture/libsysprof-capture-4.a.p/mapped-ring-buffer.c.o > [6/196] Compiling C object > subprojects/sysprof/src/libsysprof-capture/libsysprof-capture-4.a.p/sysprof-capture-writer-cat.c.o > [7/196] Generating soup-resources_c with a custom command > [8/196] Compiling C object > subprojects/sysprof/src/libsysprof-capture/libsysprof-capture-4.a.p/sysprof-capture-writer.c.o > [9/196] Compiling C object > subprojects/sysprof/src/libsysprof-capture/libsysprof-capture-4.a.p/sysprof-clock.c.o > [10/196] Compiling C object > subprojects/sysprof/src/libsysprof-capture/libsysprof-capture-4.a.p/sysprof-platform.c.o >
Wow. Thanks for that. I agree that in keeping with upstream's preferences we should recommend sysprof, but could we add the disable switch as an option ? ĸen -- To say that it (his hair) was black and bound up in a ponytail is to miss the opportunity of using the term 'elephantine'. It was hair with personality. -- The Thief Of Time (about the monk, Sato). -- http://lists.linuxfromscratch.org/listinfo/blfs-support FAQ: http://www.linuxfromscratch.org/blfs/faq.html Unsubscribe: See the above information page
