On 11/26/20 4:58 PM, rhubarbpieguy--- via blfs-support wrote:


Hi rhubarbpieguy,

I looked into the ones that Ken didn't do, and I have some feedback.

autofs

File systems --->
  <*/M> Kernel automounter version 4 support (also supports v3) [CONFIG_AUTOFS4_FS]

   I believe Kernel automounter support has no options.  Should the above lines be deleted?

I don't think the line should be deleted, but it did need to be corrected.
File systems  --->
  [*] Network File Systems ---> [CONFIG_NETWORK_FILESYSTEMS]
    <*/M> NFS client support                                          [CONFIG_NFS_FS]     <*/M> CIFS support (advanced network filesystem, SMBFS successor) [CONFIG_CIFS]

   Should CIFS support (advanced network filesystem, SMBFS successor) be SMB3 and CIFS support (advanced network filesystem)?
Ken did this one :-)
--------------------------------------------------------------------------------------------------------------

BlueZ

[*] Networking support --->                [CONFIG_NET]
  </M> Bluetooth subsystem support --->    [CONFIG_BT]

   Is </M> correct?  Should it be <M>?  <*/M>?

Yes, I've corrected that
<*/M> RF switch subsystem support --->   [CONFIG_RFKILL]

   Should RF switch subsystem support ---> be RF switch subsystem support ----?

Yes, I've corrected that. It's mandatory for WiFi, WiMAX, and Bluetooth at least, and has no options.
[*] Networking support --->                [CONFIG_NET]
This was extraneous :-)
-*- Cryptographic API ---> [CONFIG_CRYPTO]
  </M> User-space interface for hash algorithms                 [CONFIG_CRYPTO_USER_API_HASH]   </M> User-space interface for symmetric key cipher algorithms [CONFIG_CRYPTO_USER_API_SKCIPHER]

   I believe Cryptographic API has no options.  Could [CONFIG_CRYPTO] be deleted as in cryptsetup?

Cryptographic API does have plenty of options, at least on my configuration (5.9.12)
   As with the above, should the hash algorithms and key cipher lines be <M>?  <*/M>?
Yes these should, I've corrected that
--------------------------------------------------------------------------------------------------------------

lm-sensors

[*] Enable loadable module support  --->  [CONFIG_MODULES]

Bus options (PCI etc.)  --->
  [*] PCI support                         [CONFIG_PCI]

   Should Enable loadable module support and Bus options be reversed to follow the order displayed with menuconfig?

Yes it should, I've corrected that :-)
Device Drivers  --->
  I2C support --->
    <*/M> I2C device interface [CONFIG_I2C_CHARDEV]
    I2C Hardware Bus support  --->
      <M> (configure all of them as modules)
  <*/M> Hardware Monitoring support  ---> [CONFIG_HWMON]

   I believe Hardware Monitoring support has no options.  Should it be -*- Hardware Monitoring Support?  If so, could [CONFIG_HWMON] be deleted?
It does have many options, at least on my configuration.
--------------------------------------------------------------------------------------------------------------

UPower

General Setup --->
    [*] Namespaces support --->     [CONFIG_NAMESPACES]

   I believe Namespaces support has no options.  Should it be -*- Namespaces support?  If so, could [CONFIG_NAMESPACES] be deleted?

Namespaces support does have the following options:

--- Namespaces support

[*] UTS namespace

[*] TIME namespace

[*] IPC namespace

[*] User namespace

[*] PID Namespaces

[*] Network namespace


Note that the most important for UPower is the User namespace. Without that option, you'll get "ERROR 213/USER"

--------------------------------------------------------------------------------------------------------------

Cheese

Device Drivers  --->
  Multimedia support --->
    <*> Cameras/video grabbers support [CONFIG_MEDIA_CAMERA_SUPPORT]
    <*> Media USB Adapters  ---> [CONFIG_MEDIA_USB_SUPPORT]

  Should the above be:

Device Drivers  --->
   <*> Multimedia support  --->
      Media device types  --->
         <*> Cameras and video grabbers [CONFIG_MEDIA_CAMERA_SUPPORT]
      Media drivers  --->
        <*> Media USB Adapters ---> [CONFIG_MEDIA_USB_SUPPORT]

  The documentation implies nothing is to be built as a module.
I believe this has been corrected already
--------------------------------------------------------------------------------------------------------------

alsa-lib

Device Drivers --->
  <*/m> Sound card support ---> [CONFIG_SOUND]
    <*/m> Advanced Linux Sound Architecture ---> [CONFIG_SND]

   Should the <*/m>'s above be <*/M> for consistency with the documentation?
Ken got this :-)
--------------------------------------------------------------------------------------------------------------

cryptsetup

Cryptographic API  --->
  <*/M> XTS support [CONFIG_CRYPTO_XTS]
  <*/M> SHA224 and SHA256 digest algorithm [CONFIG_CRYPTO_SHA256]

   Should Cryptographic API  ---> be -*- Cryptographic API --->?

   I believe SHA224 and SHA256 digest algorithm has no options Should the line be deleted?
No it shouldn't, even if it's enabled by default :-) it's easier to keep this documented in case it becomes a non-default option in the future.
--------------------------------------------------------------------------------------------------------------

dosfstools

File systems --->
  <DOS/FAT/NT Filesystems --->

   Should <DOS/FAT/NT Filesystems ---> be DOS/FAT/EXFAT/NT Filesystems --->?
Ken got this :-)
--------------------------------------------------------------------------------------------------------------

About Firmware

General Setup --->
  [y] Initial RAM filesystem and RAM disk (initramfs/initrd) support [CONFIG_BLK_DEV_INITRD]
Processor type and features  --->
  [y] CPU microcode loading support  [CONFIG_MICROCODE]
  [y]      AMD microcode loading support [CONFIG_MICROCODE_AMD]

   Should the [y]'s above be <*> for consistency with the documentation?
Ken got this :-)
--------------------------------------------------------------------------------------------------------------

iptables

[*] Networking support --->                                          [CONFIG_NET]
      Networking Options  --->
        [*] Network packet filtering framework (Netfilter) --->       [CONFIG_NETFILTER]           [*] Advanced netfilter configuration                        [CONFIG_NETFILTER_ADVANCED]
          Core Netfilter Configuration --->
            <*/M> Netfilter connection tracking support               [CONFIG_NF_CONNTRACK]             <*/M> Netfilter Xtables support (required for ip_tables)  [CONFIG_NETFILTER_XTABLES]

   I believe Netfilter Xtables support (required for ip_tables) has no options.  Should the line be deleted?
It doesn't have options, but it isn't enabled by default, so it should probably stay.
--------------------------------------------------------------------------------------------------------------

LVM2

Kernel hacking --->
  [*] Magic SysRq key [CONFIG_MAGIC_SYSRQ]

   Should the above be:

Kernel hacking  --->
  Generic Kernel Debugging Instruments  --->
    [*] Magic SysRq key [CONFIG_MAGIC_SYSRQ]
I believe Ken got this :-)
--------------------------------------------------------------------------------------------------------------

qemu

[*] Virtualization:  ---> [CONFIG_VIRTUALIZATION]
  <*/M>   Kernel-based Virtual Machine (KVM) support [CONFIG_KVM]
  <*/M>     KVM for Intel processors support [CONFIG_KVM_INTEL]

   Should KVM for Intel processors support be KVM for Intel (and compatible) processors support?
I believe Ken got this :-)
--------------------------------------------------------------------------------------------------------------

Cups

Device Drivers  --->
  <*/M> Parallel port support  --->    [CONFIG_PARPORT]
    <*/M> PC-style hardware            [CONFIG_PARPORT_PC]
  Character devices  --->
    <*/M> Parallel printer support     [CONFIG_PRINTER]

   I see no CONFIG_PRINTER in .config.  Can the Character devices and Parallel printer lines be deleted?  I do see CONFIG_USB_PRINTER.
CONFIG_PRINTER is there. I found it on 5.9.12 by pressing "/" (for search) and then typing in CONFIG_PRINTER. It still is under Character Devices. I think it does require Parallel Port support as a prerequisite though.
--------------------------------------------------------------------------------------------------------------

libevdev

Device Drivers  --->
  Input device support --->
    <*> Generic input layer (needed for...) [CONFIG_INPUT]

   Should Generic input layer (needed for...) be Generic input layer (needed for keyboard, mouse, ...)?
Yes it does :-) I've corrected that.
--------------------------------------------------------------------------------------------------------------

Xorg Wacom Driver

Device Drivers  --->
  HID support  --->
    <*/M> HID bus support [CONFIG_HID]

   I  believe HID bus support has no options.  Should it be -*- HID bus support?  If so, could [CONFIG_HID] be deleted?
HID bus support does not have any options, so I have corrected it. However, CONFIG_HID should *not* be deleted because it's a non-default option and is required to make Wacom devices work.
--------------------------------------------------------------------------------------------------------------

Xorg AMDGPU Driver

Device Drivers  --->
  Graphics support --->
   <*> Direct Rendering Manager (XFree86 ... support) ---> [CONFIG_DRM]
   <*/M> AMD GPU [CONFIG_DRM_AMDGPU]
    [ /*] Enable amdgpu support for SI parts [CONFIG_DRM_AMDGPU_SI]
    [ /*] Enable amdgpu support for CIK parts [CONFIG_DRM_AMDGPU_CIK]

   Should the [ /*]'s above be [*]?

Ken got this :-)


Thank you for the report on this :-)

Submitted at r23952

- Doug

--
http://lists.linuxfromscratch.org/listinfo/blfs-support
FAQ: http://www.linuxfromscratch.org/blfs/faq.html
Unsubscribe: See the above information page

Reply via email to