LGTM3 On Thu, Sep 2, 2021 at 12:25 PM Alex Russell <[email protected]> wrote:
> LGTM2 > > On Thursday, September 2, 2021 at 8:25:00 PM UTC+1 Yoav Weiss wrote: > >> LGTM1 >> >> On Saturday, August 28, 2021 at 1:06:50 AM UTC+2 Xiaohan Wang wrote: >> >>> Contact [email protected] >>> >>> Explainerhttps://github.com/w3c/encrypted-media/issues/473 >>> >>> Specification >>> https://w3c.github.io/encrypted-media/#dom-mediakeysessionclosedreason >>> <https://github.com/w3c/encrypted-media/pull/487> >>> >>> Summary >>> >>> A MediaKeySessionClosedReason is proposed to indicate the reason for EME >>> MediaKeySession closure, and the closed attribute would return a >>> Promise<MediaKeySessionClosedReason> instead of the current Promise<void>. >>> >>> Blink componentInternals>Media>Encrypted >>> <https://bugs.chromium.org/p/chromium/issues/list?q=component:Internals%3EMedia%3EEncrypted> >>> >>> TAG review >>> According to the "intent to prototype" discussion the TAG review >>> shouldn't be necessary for this small change. It's still requested though >>> at https://github.com/w3ctag/design-reviews/issues/671 just in case. >>> >> >> Can you mark the TAG review as an FYI? That way it won't be blocking here. >> >> >>> >>> TAG review statusNot applicable >>> >>> Risks >>> >>> Interoperability and Compatibility >>> >>> >>> >>> Gecko: "non-harmful and lack of further comments >>> <https://github.com/mozilla/standards-positions/issues/537>" on the >>> Request for Position. >>> >>> WebKit: Support in W3C Media Working Group meeting >>> <https://lists.w3.org/Archives/Public/public-media-wg/2020Sep/0004.html>. >>> No response on the Request for Position >>> <https://lists.webkit.org/pipermail/webkit-dev/2021-June/031880.html>. >>> >>> Web developers: Supported and approved >>> <https://github.com/w3c/encrypted-media/pull/487> by Netflix's spec >>> editor. >>> >>> >>> Debuggability >>> >>> No DevTools changes are required, treated like any other attribute/enum. >>> >>> Is this feature fully tested by web-platform-tests >>> <https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md> >>> ?Yes (media/encrypted-media/encrypted-media-session-closed-event.html) >>> >>> Flag nameEncryptedMediaSessionClosedReason (see CL >>> <https://chromium-review.googlesource.com/c/chromium/src/+/2937451>) >>> >>> Requires code in //chrome?False >>> >>> Tracking bughttps://crbug.com/1208618 >>> >>> Launch bughttps://crbug.com/1208618 >>> >>> Estimated milestonesM96 >>> >>> Link to entry on the Chrome Platform Status >>> https://www.chromestatus.com/feature/5632124143009792 >>> >>> Links to previous Intent discussionsIntent to prototype: >>> https://groups.google.com/a/chromium.org/g/blink-dev/c/Vze-UnN9d3w >>> >>> >>> This intent message was generated by Chrome Platform Status >>> <https://www.chromestatus.com/>. >>> >> -- > You received this message because you are subscribed to the Google Groups > "blink-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To view this discussion on the web visit > https://groups.google.com/a/chromium.org/d/msgid/blink-dev/2ac12686-e871-4db3-a4aa-a61f3c985c1en%40chromium.org > <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/2ac12686-e871-4db3-a4aa-a61f3c985c1en%40chromium.org?utm_medium=email&utm_source=footer> > . > -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAOMQ%2Bw-KSoKWLstqSjvcqbomKNcYmNnbZC22TZrWuDTe-9y6bA%40mail.gmail.com.
