I did search the source code before I made the change. Seems the os type is always ubuntu for flag-specific builders. And CQ dry run can actually pass. I would imagine the test will fail if we are missing so many test expectations.
Virtual tests are different to flag-specific tests, right? On Tue, Sep 7, 2021 at 9:59 AM Stefan Zager <sza...@chromium.org> wrote: > On Tue, Sep 7, 2021 at 9:01 AM 'Weizhong Xia' via blink-dev < > blink-dev@chromium.org> wrote: > >> >> In this CL we also assumed flag-specific tests only run on linux-bots. >> Pls speak up if you know this is not the case. >> > > I don't think that's true. Virtual test suites run on all platforms, and > they rely on expectation files in flag-specific/. > -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CADXrSipo0XRY6DD7%2B6ivE3LsbmmPsfb9DBwZm1eN_7yXSC00fg%40mail.gmail.com.
