LGTM1
On Thu, Sep 23, 2021 at 12:03 AM PhistucK <phist...@gmail.com> wrote:
> Not sure I completely agree, so, not so "right". :)
> Using <summary>/<details> for "accordions" is kind of the prescribed way
> to do this. I do not think encouraging other, maybe less accessible,
> semantic or simple ways is so "right".
> And this is breaking/changing an existing behaviour. You would not say
> this ("they could just not use the details element, right?") so casually
> about other platform changes, I think.
> This is why I think a way to opt-out is fair.
>
I'm sympathetic to the semantic element argument. I suspect that the need
for such an opt-out is not huge (as it seems fairly niche for content to
want to be hidden), so I wouldn't consider this a blocker, but it seems
worthwhile to keep close tabs of the developer ecosystem and see if such a
need arises.
If it does, adding an opt-out seems worthwhile.
> I would not say this is a huge use case or that it must block shipping
> this, but it is worth a thoughtful consideration, anyway.
>
> ☆*PhistucK*
>
>
> On Wed, Sep 22, 2021 at 10:28 PM Joey Arhar <jar...@chromium.org> wrote:
>
>> > I imagine it could break a little some pages that hide the answer to a
>> question (in a quiz type of thing) via this element...
>>
>> If a site doesn't like this behavior, they could just not use the details
>> element, right? There are plenty of other ways to implement an accordion
>> like this.
>> I think it's more important for the user to be able to find content in
>> the page than it is for the page to hide content from the user by default,
>> right?
>>
>> On Sat, Sep 18, 2021 at 10:58 AM PhistucK <phist...@gmail.com> wrote:
>>
>>> I imagine it could break a little some pages that hide the answer to a
>>> question (in a quiz type of thing) via this element...
>>>
>>> ☆*PhistucK*
>>>
>>>
>>> On Sat, Sep 18, 2021 at 6:55 PM Joey Arhar <jar...@chromium.org> wrote:
>>>
>>>> > Will there be an opt out (without resorting to using other elements)?
>>>>
>>>> No, there is no plan to add an opt-out for this feature.
>>>>
>>>> On Sat, Sep 18, 2021 at 10:54 AM PhistucK <phist...@gmail.com> wrote:
>>>>
>>>>> Will there be an opt out (without resorting to using other elements)?
>>>>>
>>>>> ☆*PhistucK*
>>>>>
>>>>>
>>>>> On Fri, Sep 17, 2021 at 4:55 PM Joey Arhar <jar...@chromium.org>
>>>>> wrote:
>>>>>
>>>>>> > I think it's fair to say "positive", given the like and retweet
>>>>>> signals on https://twitter.com/tomayac/status/1403119516922662913
>>>>>> and https://twitter.com/tomayac/status/1293696281370669057 where
>>>>>> this behavior is described.
>>>>>>
>>>>>> Thanks Thomas!
>>>>>>
>>>>>> > Do I understand correctly and developers don't need to do anything
>>>>>> for their users to benefit from this? (and just need not to break their
>>>>>> content when many toggle events are fired)
>>>>>>
>>>>>> That's correct! Details elements will be opened and toggle events
>>>>>> will be fired when the browser actually scrolls to the content inside a
>>>>>> closed details element.
>>>>>>
>>>>>> > I think I'd describe all these put together as "slightly positive".
>>>>>> > At the same time, if I'm assuming correctly and developer opt-in is
>>>>>> not required, then luke-warm developer reception and happy users sounds
>>>>>> like a win.
>>>>>>
>>>>>> Great! I agree.
>>>>>> You are assuming correctly that developer opt-in is not required.
>>>>>>
>>>>>> On Fri, Sep 17, 2021 at 1:56 AM Yoav Weiss <yoavwe...@chromium.org>
>>>>>> wrote:
>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> On Fri, Sep 17, 2021 at 8:41 AM 'Thomas Steiner' via blink-dev <
>>>>>>> blink-dev@chromium.org> wrote:
>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> On Fri, Sep 17, 2021 at 3:56 AM Joey Arhar <jar...@chromium.org>
>>>>>>>> wrote:
>>>>>>>>
>>>>>>>>> Contact emailsjar...@chromium.org
>>>>>>>>>
>>>>>>>>> Explainer
>>>>>>>>> https://github.com/WICG/display-locking/blob/main/explainers/auto-expanding-details-explainer.md
>>>>>>>>>
>>>>>>>>
>>>>>>> Do I understand correctly and developers don't need to do anything
>>>>>>> for their users to benefit from this? (and just need not to break their
>>>>>>> content when many toggle events are fired)
>>>>>>>
>>>>>>>
>>>>>>>>
>>>>>>>>>
>>>>>>>>> Specificationhttps://github.com/whatwg/html/pull/6466
>>>>>>>>>
>>>>>>>>> Design docs
>>>>>>>>> https://github.com/WICG/display-locking/blob/main/privacy-assessments/auto-expanding-details-privacy.md
>>>>>>>>>
>>>>>>>>> Summary
>>>>>>>>>
>>>>>>>>> This feature will make closed details elements searchable and
>>>>>>>>> automatically expand when the browser tries to scroll to their hidden
>>>>>>>>> contents in response to find-in-page, ScrollToTextFragment, and
>>>>>>>>> element
>>>>>>>>> fragment navigation.
>>>>>>>>>
>>>>>>>>> Blink componentBlink>HTML
>>>>>>>>> <https://bugs.chromium.org/p/chromium/issues/list?q=component:Blink%3EHTML>
>>>>>>>>>
>>>>>>>>> TAG reviewhttps://github.com/w3ctag/design-reviews/issues/677
>>>>>>>>>
>>>>>>>>
>>>>>>>>>
>>>>>>>>> TAG review statusPending
>>>>>>>>>
>>>>>>>>> Risks
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> Interoperability and Compatibility
>>>>>>>>>
>>>>>>>>> If other browsers don't implement this feature for element
>>>>>>>>> fragments, it may be an observable difference to webpages, but this
>>>>>>>>> portion
>>>>>>>>> is the least contentious and complicated part of this feature, so
>>>>>>>>> other
>>>>>>>>> browsers are most likely to at least implement this for element
>>>>>>>>> fragments.
>>>>>>>>> If other browsers don't implement this feature for find-in-page or
>>>>>>>>> ScrollToTextFragment, it won't cause any websites to break because
>>>>>>>>> webpages
>>>>>>>>> can't observe the difference.
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> Gecko: No signal (
>>>>>>>>> https://github.com/mozilla/standards-positions/issues/578)
>>>>>>>>>
>>>>>>>>> WebKit: No signal (
>>>>>>>>> https://lists.webkit.org/pipermail/webkit-dev/2021-September/031983.html
>>>>>>>>> )
>>>>>>>>>
>>>>>>>>> Web developers: No signals
>>>>>>>>>
>>>>>>>>
>>>>>>>> I think it's fair to say "positive", given the like and retweet
>>>>>>>> signals on https://twitter.com/tomayac/status/1403119516922662913
>>>>>>>> and https://twitter.com/tomayac/status/1293696281370669057 where
>>>>>>>> this behavior is described.
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>> - Here is a user reported bug requesting this feature:
>>>>>>>>> https://bugs.chromium.org/p/chromium/issues/detail?id=1058732
>>>>>>>>> - Here is an article I found describing the lack of element
>>>>>>>>> fragment navigation:
>>>>>>>>> https://www.sitepoint.com/fixing-the-details-element/#:~:text=the%20target%20element%20is%20inside%20a%20collapsed%20region
>>>>>>>>>
>>>>>>>>
>>>>>>> I think I'd describe all these put together as "slightly positive".
>>>>>>> At the same time, if I'm assuming correctly and developer opt-in is
>>>>>>> not required, then luke-warm developer reception and happy users sounds
>>>>>>> like a win.
>>>>>>>
>>>>>>>
>>>>>>>>
>>>>>>>>>
>>>>>>>>> Debuggability
>>>>>>>>>
>>>>>>>>> This feature does not have any added DevTools support. This
>>>>>>>>> feature does not add any state to the page that would need to be
>>>>>>>>> inspected
>>>>>>>>> with DevTools. Find-in-page, ScrollToTextFragment, and element
>>>>>>>>> fragment
>>>>>>>>> navigation do not provide any DevTools debugging that this feature
>>>>>>>>> could
>>>>>>>>> build on or leverage.
>>>>>>>>>
>>>>>>>>> Is this feature fully tested by web-platform-tests
>>>>>>>>> <https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md>
>>>>>>>>> ?No
>>>>>>>>> - Auto-expanding details with element fragment navigation is
>>>>>>>>> tested here:
>>>>>>>>> https://wpt.fyi/results/html/semantics/interactive-elements/the-details-element/auto-expand-details-element-fragment.html
>>>>>>>>> - I still need to add ScrollToTextFragment tests.
>>>>>>>>> ScrollToTextFragment tests do exist in WPT.
>>>>>>>>> - Find-in-page can't be tested in WPT
>>>>>>>>> <https://github.com/web-platform-tests/wpt/issues/29915>, but I
>>>>>>>>> may spec window.find and support it for this feature in the future
>>>>>>>>> just to
>>>>>>>>> make this WPT testable.
>>>>>>>>>
>>>>>>>>> Flag name--enable-blink-features=AutoExpandDetailsElement
>>>>>>>>>
>>>>>>>>> Requires code in //chrome?False
>>>>>>>>>
>>>>>>>>> Tracking bug
>>>>>>>>> https://bugs.chromium.org/p/chromium/issues/detail?id=1185950
>>>>>>>>>
>>>>>>>>> Launch bug
>>>>>>>>> https://bugs.chromium.org/p/chromium/issues/detail?id=1241443
>>>>>>>>>
>>>>>>>>> Estimated milestones
>>>>>>>>>
>>>>>>>>> M96
>>>>>>>>>
>>>>>>>>> Link to entry on the Chrome Platform Status
>>>>>>>>> https://chromestatus.com/feature/5032469667512320
>>>>>>>>>
>>>>>>>>> This intent message was generated by Chrome Platform Status
>>>>>>>>> <https://www.chromestatus.com/>.
>>>>>>>>>
>>>>>>>>> --
>>>>>>>>> You received this message because you are subscribed to the Google
>>>>>>>>> Groups "blink-dev" group.
>>>>>>>>> To unsubscribe from this group and stop receiving emails from it,
>>>>>>>>> send an email to blink-dev+unsubscr...@chromium.org.
>>>>>>>>> To view this discussion on the web visit
>>>>>>>>> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAK6btwJKmGKbjhWCdqrVO-Dm5LMmuROQ9M7N4UADjNvnTUaDAg%40mail.gmail.com
>>>>>>>>> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAK6btwJKmGKbjhWCdqrVO-Dm5LMmuROQ9M7N4UADjNvnTUaDAg%40mail.gmail.com?utm_medium=email&utm_source=footer>
>>>>>>>>> .
>>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> --
>>>>>>>> Thomas Steiner, PhD—Developer Advocate (https://blog.tomayac.com,
>>>>>>>> https://twitter.com/tomayac)
>>>>>>>>
>>>>>>>> Google Germany GmbH, ABC-Str. 19, 20354 Hamburg, Germany
>>>>>>>> Geschäftsführer: Paul Manicle, Halimah DeLaine Prado
>>>>>>>> Registergericht und -nummer: Hamburg, HRB 86891
>>>>>>>>
>>>>>>>> -----BEGIN PGP SIGNATURE-----
>>>>>>>> Version: GnuPG v2.1.23 (GNU/Linux)
>>>>>>>>
>>>>>>>>
>>>>>>>> iFy0uwAntT0bE3xtRa5AfeCheCkthAtTh3reSabiGbl0ck0fjumBl3DCharaCTersAttH3b0ttom.
>>>>>>>> hTtPs://xKcd.cOm/1181/
>>>>>>>> -----END PGP SIGNATURE-----
>>>>>>>>
>>>>>>>> --
>>>>>>>> You received this message because you are subscribed to the Google
>>>>>>>> Groups "blink-dev" group.
>>>>>>>> To unsubscribe from this group and stop receiving emails from it,
>>>>>>>> send an email to blink-dev+unsubscr...@chromium.org.
>>>>>>>> To view this discussion on the web visit
>>>>>>>> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CALgRrLnkya4wkC7r-tWBcWoOkoJnGof%3DLt_reiM6AyKtm-BNDQ%40mail.gmail.com
>>>>>>>> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CALgRrLnkya4wkC7r-tWBcWoOkoJnGof%3DLt_reiM6AyKtm-BNDQ%40mail.gmail.com?utm_medium=email&utm_source=footer>
>>>>>>>> .
>>>>>>>>
>>>>>>> --
>>>>>> You received this message because you are subscribed to the Google
>>>>>> Groups "blink-dev" group.
>>>>>> To unsubscribe from this group and stop receiving emails from it,
>>>>>> send an email to blink-dev+unsubscr...@chromium.org.
>>>>>> To view this discussion on the web visit
>>>>>> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAK6btw%2BDmDf3s95mS%2Ba2kQKFCKA4DXhcL59%3Dm8ZmO6tskjQG%3Dg%40mail.gmail.com
>>>>>> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAK6btw%2BDmDf3s95mS%2Ba2kQKFCKA4DXhcL59%3Dm8ZmO6tskjQG%3Dg%40mail.gmail.com?utm_medium=email&utm_source=footer>
>>>>>> .
>>>>>>
>>>>>
--
You received this message because you are subscribed to the Google Groups
"blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to blink-dev+unsubscr...@chromium.org.
To view this discussion on the web visit
https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAL5BFfX%2B5sfrrcbhnEbpsXN5OpdDZtB4-Duy0WzP5GK5cWWn-A%40mail.gmail.com.
