LGTM1. The UX treatment ran through internal security/privacy review, and doesn't create risk above and beyond the existing JavaScript API, which we ship currently and accept.
-mike On Mon, Oct 4, 2021 at 10:56 PM Diego González <die...@gmail.com> wrote: > Hola Chris, > > 1. We have applied for signals through the methods specified in the > document linked, for reference: > * Gecko: https://github.com/mozilla/standards-positions/issues/340 > * I believe there is no entry in the webkit-dev list, although there is > the bug file in webkit bug tracker. (I can add the thread in the mailing > list if it is necessary for the process, but as a fellow webkit engineer > told me, if there is no interaction in the whole standard process it means > there is not interest in the feature.) > > 2. I'll work on landing these changes to manifest incubations for the time > being, that way we can unblock the process since I do not expect to get any > signal from another engine any time soon. > > 3. Overall the summary is positive, with no actionable feedback. A few > "lgtm please ship" and "if we can't use this we'll have to use Electron". > > Regards > > Diego > > On Thursday, 30 September 2021 at 20:30:51 UTC+1 Chris Harrelson wrote: > >> Hi, a few points. >> >> 1. Please file for signals via the mechanism at bit.ly/blink-signals. >> 2. Ok if we block approval on landing the spec PR? >> 3. Can you send us a summary of feedback received during the Origin Trial? >> >> Thanks, >> Chris >> >> >> On Wed, Sep 29, 2021 at 9:25 AM 'Diego Gonzalez' via blink-dev < >> blin...@chromium.org> wrote: >> >>> Contact emails >>> >>> samue...@microsoft.com, mjac...@microsoft.com, luig...@microsoft.com, >>> dmu...@chromium.org >>> >>> >>> Explainer >>> >>> >>> https://github.com/MicrosoftEdge/MSEdgeExplainers/blob/master/URLProtocolHandler/explainer.md >>> >>> https://web.dev/url-protocol-handler/ >>> >>> >>> Specification >>> >>> >>> https://pr-preview.s3.amazonaws.com/w3c/manifest/pull/972.html#protocol_handlers-member >>> >>> >>> Design docs >>> >>> >>> https://docs.google.com/document/d/1NHlWLjAPZ-dyxcz3AoTWibeerDeHW7Vqrx6FmhB0XmE >>> Summary >>> >>> Enable web applications to register themselves as handlers of custom URL >>> protocols/schemes using their installation manifest. >>> Blink component >>> >>> UI>Browser>WebAppInstalls >>> <https://bugs.chromium.org/p/chromium/issues/list?q=component:UI%3EBrowser%3EWebAppInstalls> >>> Search tags >>> >>> protocol <https://chromestatus.com/features#tags:protocol>, web app >>> <https://chromestatus.com/features#tags:web%20app>, protocol handlers >>> <https://chromestatus.com/features#tags:protocol%20handlers>, custom >>> schemes <https://chromestatus.com/features#tags:custom%20schemes> >>> TAG review >>> >>> https://github.com/w3ctag/design-reviews/issues/482 >>> TAG review status >>> >>> Issues addressed, resolution: satisfied. >>> Risks Interoperability and Compatibility >>> >>> Low; manifest elements will be ignored if unsupported by the client. >>> >>> Gecko: No signal (https://bugzilla.mozilla.org/show_bug.cgi?id=1635272) >>> >>> WebKit: No signal (https://bugs.webkit.org/show_bug.cgi?id=211401) >>> >>> Web developers: Positive ( >>> https://twitter.com/search?q=url%3Ahttps%3A%2F%2Fweb.dev%2Furl-protocol-handler%2F&src=typed_query&f=live >>> ) >>> Security >>> >>> >>> https://github.com/MicrosoftEdge/MSEdgeExplainers/blob/main/URLProtocolHandler/explainer.md#security-considerations >>> >>> >>> Debuggability Is this feature fully tested by web-platform-tests >>> <https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md> >>> ? >>> >>> Yes - https://chromium-review.googlesource.com/c/chromium/src/+/3166820 >>> >>> >>> DevTrial instructions >>> >>> >>> https://web.dev/url-protocol-handler/#enabling-via-about:flags-or-edge:flags >>> Flag name >>> >>> #enable-desktop-pwas-protocol-handling >>> >>> >>> Requires code in //chrome? >>> >>> Yes >>> Tracking bug >>> >>> https://crbug.com/1019239 >>> >>> >>> Launch bug >>> >>> https://crbug.com/1063658 >>> >>> >>> Sample links >>> >>> https://protocol-handler.glitch.me/ >>> >>> https://fabiorocha.github.io/pwa >>> >>> >>> Estimated milestones >>> >>> OriginTrial desktop last >>> >>> 95 >>> >>> OriginTrial desktop first >>> >>> 92 >>> >>> >>> >>> >>> Link to entry on the Chrome Platform Status >>> >>> https://chromestatus.com/feature/5151703944921088 >>> >>> >>> Links to previous Intent discussions >>> >>> Intent to prototype: >>> https://groups.google.com/a/chromium.org/g/blink-dev/c/x4Ev_l9Oj2U/m/6bGPs7MVCwAJ >>> >>> Ready for Trial: >>> https://groups.google.com/a/chromium.org/g/blink-dev/c/GbTdEVNPhng >>> >>> Intent to Experiment: >>> https://groups.google.com/a/chromium.org/g/blink-dev/c/AuKUdqTkUAs >>> >>> >>> >>> >>> >>> Regards, >>> >>> >>> >>> *Diego González-Zúñiga* >>> >>> PM, Microsoft Edge >>> >>> >>> >>> >>> >>> -- >>> You received this message because you are subscribed to the Google >>> Groups "blink-dev" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to blink-dev+...@chromium.org. >>> To view this discussion on the web visit >>> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/VI1PR83MB04167084458FC32293FB6387CCA99%40VI1PR83MB0416.EURPRD83.prod.outlook.com >>> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/VI1PR83MB04167084458FC32293FB6387CCA99%40VI1PR83MB0416.EURPRD83.prod.outlook.com?utm_medium=email&utm_source=footer> >>> . >>> >> -- > You received this message because you are subscribed to the Google Groups > "blink-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to blink-dev+unsubscr...@chromium.org. > To view this discussion on the web visit > https://groups.google.com/a/chromium.org/d/msgid/blink-dev/173ad5d9-f162-488f-81b2-99ad2d0149f3n%40chromium.org > <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/173ad5d9-f162-488f-81b2-99ad2d0149f3n%40chromium.org?utm_medium=email&utm_source=footer> > . > -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAKXHy%3DdDdxKZ%2BGU%3DsNrCYfjHmai0MXqrvitPGwA9uDBcjQAa1A%40mail.gmail.com.
