LGTM3. In future, if you assert a TAG review isn't necessary, please provide links to previous reviews that cover the same space.
On Thursday, October 21, 2021 at 12:17:45 PM UTC-7 Manuel Rego wrote: > LGTM2 > > On 21/10/2021 21:16, Daniel Bratell wrote: > > LGTM1 > > > > /Daniel > > > > On Friday, 15 October 2021 at 14:41:44 UTC+2 ari...@chromium.org wrote: > > > > Correct, they’ll behave the same as the other non-legacy hints. > > > > On Fri, Oct 15, 2021 at 05:34 Yoav Weiss <yoav...@chromium.org> wrote: > > > > Thanks for working on this, Ari! > > > > IIUC, this intent will add these new hint names, but would > > also ensure their behavior when it comes to 3P delegation would > > be different from the legacy hints (as they don't have the same > > legacy baggage). Is that correct? > > > > > > On Mon, Oct 11, 2021 at 8:09 PM Ari Chivukula > > <ari...@chromium.org> wrote: > > > > Contact emails > > > > ari...@chromium.org, jadek...@chromium.org, mike...@chromium.org > > > > > > Design Doc > > > > > https://docs.google.com/document/d/1yhVLyEIpDhhDQf698WkvXBiPcLwxEgCBI4o1FjvXwfM/edit > > < > https://docs.google.com/document/d/1yhVLyEIpDhhDQf698WkvXBiPcLwxEgCBI4o1FjvXwfM/edit > > > > > > > > Specification > > > > https://wicg.github.io/client-hints-infrastructure/ > > <https://wicg.github.io/client-hints-infrastructure/> > > > > https://wicg.github.io/responsive-image-client-hints/ > > <https://wicg.github.io/responsive-image-client-hints/> > > > > https://wicg.github.io/savedata/#save-data-request-header-field > > <https://wicg.github.io/savedata/#save-data-request-header-field> > > > > https://wicg.github.io/netinfo/#networkinformation-interface > > <https://wicg.github.io/netinfo/#networkinformation-interface> > > > > > > Summary > > > > This proposal seeks to align our implementation with the > > Client Hint proposal > > <https://wicg.github.io/client-hints-infrastructure/>by > > adding the `sec-ch-` prefix where it’s missing. > > > > > > Blink component > > > > Privacy>Fingerprinting > > < > https://bugs.chromium.org/p/chromium/issues/list?q=component%3APrivacy%3EFingerprinting > > > > > > > > Motivation > > > > Client Hints > > <https://www.chromestatus.com/feature/5995832180473856>, a > > method to request information about the user's device or > > conditions, have been implemented in Chrome, but since the > > initial implementation the naming scheme has changed. If > > implemented, this proposal would add new client hints with a > > `sec-ch-` prefix to re-implement the following: `dpr`, > > `width`, `viewport-width`, and `device-memory`. The three > > network related client hints with legacy names, `rtt`, > > `downlink`, and `ect`, will not be updated as they may be > > replaced by different hints in an independent process. > > > > > > TAG review > > > > Not needed > > > > > > Risks > > > > Only Blink implements client hints and we are not (yet) > > removing any current ones, just re-implementing existing > > ones under the correct name. If usage permits, we will > > remove the legacy names in the future. > > > > > > > > > > Interoperability and Compatibility > > > > Gecko: Client hints not implemented > > > > WebKit: Client hints not implemented > > > > Web developers: Positive interest from Cloudinary > > < > https://discourse.wicg.io/t/responsive-image-client-hints-call-for-review/5470 > > > > > > > > Is this feature fully tested by web-platform-tests? > > > > Yes > > < > https://chromium.googlesource.com/chromium/src/+/refs/heads/main/third_party/blink/web_tests/external/wpt/client-hints/ > > > > > > > > Tracking bug > > > > https://crbug.com/1227043 <https://crbug.com/1227043> > > > > > > Link to entry on the Chrome Platform Status > > > > https://www.chromestatus.com/feature/6658223894429696 > > <https://www.chromestatus.com/feature/6658223894429696> > > > > > > -- > > You received this message because you are subscribed to the > > Google Groups "blink-dev" group. > > To unsubscribe from this group and stop receiving emails > > from it, send an email to blink-dev+...@chromium.org. > > To view this discussion on the web visit > > > https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAGpy5D%2B30oHb6PLFQK0-hFQu2nZ%2Bq_Ge6U4cLXEvsgm-uZaJbQ%40mail.gmail.com > > < > https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAGpy5D%2B30oHb6PLFQK0-hFQu2nZ%2Bq_Ge6U4cLXEvsgm-uZaJbQ%40mail.gmail.com?utm_medium=email&utm_source=footer > >. > > > > -- > > ~ Ari Chivukula (Their/There/They’re) > > > > -- > > You received this message because you are subscribed to the Google > > Groups "blink-dev" group. > > To unsubscribe from this group and stop receiving emails from it, send > > an email to blink-dev+unsubscr...@chromium.org > > <mailto:blink-dev+unsubscr...@chromium.org>. > > To view this discussion on the web visit > > > https://groups.google.com/a/chromium.org/d/msgid/blink-dev/c78c1e05-f468-4035-b444-629acee2f7a1n%40chromium.org > > < > https://groups.google.com/a/chromium.org/d/msgid/blink-dev/c78c1e05-f468-4035-b444-629acee2f7a1n%40chromium.org?utm_medium=email&utm_source=footer > >. > -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/3922db61-658b-470b-9b26-2906efee8b24n%40chromium.org.
