Make true truthy, who could object to that? :-) LGTM2 Seriously though, I agree on the sentiment of the low compat risk. This feels arguably bugfix-level to me. But I agree with Daniel that stranger things have happened in the world of web compat, so as always please keep an ear open for any regressions and revert / measure at the sign of any issues.
Rick On Fri, Mar 4, 2022 at 9:46 AM Daniel Bratell <[email protected]> wrote: > LGTM1. > > The feedback from Mozilla and WebKit is not of the 100% official kind, but > I agree that this is a small enough change to not request more formal > feedback than the feedback that already is there. > > (Also, "exceedingly unlikely", if I've learned anything about the web, it > is that there is nothing that is too strange to exist on it). > > /Daniel > On 2022-03-03 22:23, Mason Freed wrote: > > Contact emails [email protected] > > Explainer https://github.com/whatwg/html/issues/7399 > > Specification https://github.com/whatwg/html/pull/7425 > > Summary > > This is a recent change [1] to the spec for parsing the windowFeatures > argument to window.open(). Previous to this change, > window.open(url,'','popup=true') interpreted the 'popup=true' to mean popup > is false. With this change, 'true' counts as a truthy value. [1] > https://github.com/whatwg/html/pull/7425 > > > Blink component Blink > <https://bugs.chromium.org/p/chromium/issues/list?q=component:Blink> > > Search tags window.open > <https://chromestatus.com/features#tags:window.open>, windowFeatures > <https://chromestatus.com/features#tags:windowFeatures> > > TAG review Extremely small change, and this was peripherally discussed on > the TAG review for the recent addition of the popup windowFeature: > https://github.com/w3ctag/design-reviews/issues/691 > > TAG review status Not applicable > > Risks > > > Interoperability and Compatibility > > It is possible, though extremely unlikely, that a site currently uses > `window.open(url,'','feature=true')` and expects feature to be false. In > that case, this change will change behavior. However, this seems > exceedingly unlikely. > > > Gecko: In development ( > https://github.com/whatwg/html/pull/7425#issuecomment-1058350502) > > WebKit: Positive ( > https://github.com/whatwg/html/issues/7399#issuecomment-989971808) > > Web developers: No signals > > Other signals: > > Ergonomics > > No risks > > > Activation > > No risks. > > > Security > > No risks > > > Debuggability > > Fully debuggable using existing DevTools support. > > > Is this feature fully tested by web-platform-tests > <https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md> > ? Yes > > Flag name > > Requires code in //chrome? False > > Tracking bug https://crbug.com/1277613 > > Estimated milestones > > No milestones specified > > > Link to entry on the Chrome Platform Status > https://chromestatus.com/feature/5669245760307200 > > This intent message was generated by Chrome Platform Status > <https://chromestatus.com/>. > -- > You received this message because you are subscribed to the Google Groups > "blink-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To view this discussion on the web visit > https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAM%3DNeDhYZ9nu-JdWdMS93E8AO8R39wqOWDo3pn3m6NFWqnjb6A%40mail.gmail.com > <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAM%3DNeDhYZ9nu-JdWdMS93E8AO8R39wqOWDo3pn3m6NFWqnjb6A%40mail.gmail.com?utm_medium=email&utm_source=footer> > . > > -- > You received this message because you are subscribed to the Google Groups > "blink-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To view this discussion on the web visit > https://groups.google.com/a/chromium.org/d/msgid/blink-dev/6c7f2dd3-cb27-e064-d4ca-c30865d8c324%40gmail.com > <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/6c7f2dd3-cb27-e064-d4ca-c30865d8c324%40gmail.com?utm_medium=email&utm_source=footer> > . > -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAFUtAY-nnzBsaXKuG8j9N31M3f0OkNsQAocZTtH-1szzmGuXcg%40mail.gmail.com.
