LGTM3 On Tue, May 10, 2022 at 1:34 PM Mike Taylor <[email protected]> wrote:
> LGTM2 - this seems pretty safe and good for interop. Thanks for working on > it. > > On 5/10/22 1:06 PM, Daniel Bratell wrote: > > LGTM1 > > I agree that usage is low enough and use-cases not compelling enough to > keep it. I've gone through a couple of hundred uses of googIPv6 on GitHub > and there are a couple of "false" that you may want to take a look at, but > nothing that causes concerns for me (you may know better). The timeline is > also conservative. > > Make sure you you add the removal date to the deprecation message if it's > not already there. > > /Daniel > On 2022-05-10 15:22, Henrik Boström wrote: > > I'm already displaying a deprecation warning when "googIPv6: false" is > used. The warning was added in M102 (currently Beta). > In terms of deprecation timeline, I'd like to remove this in ~6 months. > M108 is released on November 29, 2022. I suggest we target that milestone. > > On Tuesday, May 10, 2022 at 3:15:32 PM UTC+2 Henrik Boström wrote: > >> Primary eng (and PM) emails >> [email protected], [email protected] >> >> Summary >> WebRTC allows sending and receiving audio, video and arbitrary data >> between two endpoints using the RTCPeerConnection API. >> >> The googIPv6 constraint was originally added to opt-in to IPv6 support >> while that was in development, but IPv6 support has subsequently been >> enabled-by-default for many years. While setting googIPv6 to true is a >> NO-OP, some users make use of this non-standard API to disable IPv6 by >> setting it to false. >> >> Motivation >> A spec-compliant WebRTC implementation supports IPv6 and has no way to >> disable IPv6. Non-chromium browsers does not have an ability to disable >> IPv6, so this constraint is not good for interop. >> >> We want to remove googIPv6 because a) it's non-standard, and b) it >> resides in a dictionary argument of the RTCPeerConnection called >> mediaConstraints that is also non-standard. The existence of googIPv6 >> prevents us from removing mediaConstraints. >> >> Interoperability and Compatibility Risk >> The other browser vendors have been very supportive of removing >> non-standard WebRTC APIs in the past, but I have not reached out to any >> browser vendor specifically about googIPv6. >> >> Alternative implementation suggestion for web developers >> N/A. >> >> Usage information from UseCounter >> The LegacyConstraintGoogIPv6 use counter >> <https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/modules/mediastream/media_constraints_impl.cc;l=379;drc=66fb5c89fa76a7b89983dd6c08e7f67aed1d0999> >> suggests 0.000112% >> of page loads use this feature by setting it to false (setting it to true >> is a NO-OP and not counted here). >> >> Entry on the feature dashboard >> https://chromestatus.com/feature/5184046454800384 >> >> >> >> -- > You received this message because you are subscribed to the Google Groups > "blink-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To view this discussion on the web visit > https://groups.google.com/a/chromium.org/d/msgid/blink-dev/ac2ba002-b13a-4c17-b26c-ea38f8ae33b1n%40chromium.org > <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/ac2ba002-b13a-4c17-b26c-ea38f8ae33b1n%40chromium.org?utm_medium=email&utm_source=footer> > . > > -- > You received this message because you are subscribed to the Google Groups > "blink-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To view this discussion on the web visit > https://groups.google.com/a/chromium.org/d/msgid/blink-dev/0192cbc1-173c-2437-00a2-7068bbd0ffbd%40gmail.com > <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/0192cbc1-173c-2437-00a2-7068bbd0ffbd%40gmail.com?utm_medium=email&utm_source=footer> > . > > > -- > You received this message because you are subscribed to the Google Groups > "blink-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To view this discussion on the web visit > https://groups.google.com/a/chromium.org/d/msgid/blink-dev/99c75909-ded0-9d17-3cc4-3c0b1e1904c6%40chromium.org > <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/99c75909-ded0-9d17-3cc4-3c0b1e1904c6%40chromium.org?utm_medium=email&utm_source=footer> > . > -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAOMQ%2Bw9zC9FAVLCP41aQcBi4TZO-ey0XLVbbs2eFk-95O3H_Cw%40mail.gmail.com.
