LGTM3
On Wed, May 11, 2022 at 3:47 PM Yoav Weiss <yoavwe...@chromium.org> wrote: > LGTM2 > > On Wed, May 11, 2022 at 7:35 AM Mike West <mk...@chromium.org> wrote: > >> LGTM1. This seems like a logical extension of the existing compression >> streams mechanism that was discussed at the time, delayed only due to >> prioritization, not design considerations. It makes a common use case >> simpler for developers, and does so in a way that's consistent with the >> rest of the API. Good luck getting it out the door! >> >> -mike >> >> >> On Mon, May 9, 2022 at 4:46 AM Yutaka Hirano <yhir...@chromium.org> >> wrote: >> >>> >>> >>> On Sat, May 7, 2022 at 8:24 AM Mike Taylor <miketa...@chromium.org> >>> wrote: >>> >>>> On 5/6/22 8:10 AM, Yutaka Hirano wrote: >>>> >>>> Contact emails >>>> >>>> yhir...@chromium.org >>>> >>>> Explainer >>>> >>>> None >>>> >>>> Specification >>>> >>>> https://wicg.github.io/compression/ >>>> >>>> https://github.com/wicg/compression/pull/43 (spec PR) >>>> >>>> https://chromium-review.googlesource.com/c/chromium/src/+/3586945 >>>> (impl and tests) >>>> >>>> Summary >>>> >>>> Add a new compression format, "deflate-raw", to give web developers >>>> access to the raw deflate stream without any headers or footers. This is >>>> needed, for example, to read/write zip files. >>>> >>>> >>>> Blink component >>>> >>>> Blink>Network>StreamsAPI >>>> <https://bugs.chromium.org/p/chromium/issues/list?q=component:Blink%3ENetwork%3EStreamsAPI> >>>> >>>> TAG review >>>> >>>> This is subtle enough for a separate TAG review. >>>> >>>> Do you intend to file one? Or is the above missing a "not"? >>>> >>> >>> Sorry for the unclearness, I wanted to say that we don't need a TAG >>> review for this feature because this is a very small feature. >>> >>>> >>>> TAG review status >>>> >>>> Not applicable >>>> >>>> Risks Interoperability and Compatibility >>>> >>>> This is a new addition and doesn’t change any existing behaviors. >>>> >>>> Gecko: No signal >>>> >>>> (See the bottom of >>>> https://github.com/mozilla/standards-positions/issues/207) >>>> >>>> I pinged that thread to ask if they would prefer us to open a new issue >>>> - Compression Streams was marked as "worth prototyping", but that was >>>> before "deflaw-raw" existed in the spec. >>>> >>>> >>>> WebKit: No signal >>>> >>>> (See https://lists.webkit.org/pipermail/webkit-dev/2022-May/032213.html >>>> ) >>>> >>>> Web developers: Positive >>>> >>>> https://github.com/wicg/compression/issues/25 >>>> >>>> Google Sheets <http://sheets.google.com> >>>> >>>> Google sheets team uses zipping for conversion (client side) of google >>>> sheet into different formats such as xlsx. Browser native >>>> compression/decompression stream apis have much better performance than >>>> using any js library for zipping. >>>> >>>> With support for “deflate-raw” format, we are able to use >>>> compression/decompression stream apis for compression of files during >>>> zipping in a much simpler way compared to “gzip”, “deflate” format which >>>> required workarounds on our side. >>>> >>>> >>>> Other signals: >>>> >>>> WebView application risks >>>> >>>> None. >>>> >>>> >>>> Debuggability >>>> >>>> None >>>> >>>> Is this feature fully tested by web-platform-tests >>>> <https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md> >>>> ? >>>> >>>> Yes >>>> >>>> Flag name >>>> >>>> Requires code in //chrome? >>>> >>>> False >>>> >>>> Tracking bug >>>> >>>> https://crbug.com/1271220 >>>> >>>> Estimated milestones >>>> >>>> 103 >>>> >>>> Anticipated spec changes >>>> >>>> None >>>> >>>> >>>> Link to entry on the Chrome Platform Status >>>> >>>> https://chromestatus.com/feature/5172771293233152 >>>> >>>> Links to previous Intent discussions >>>> >>>> Intent to prototype: >>>> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CABihn6GYcF5VsvfgEDpYL0rCvxQV9phxwFtJ-FxbTEbqPtJxbg%40mail.gmail.com >>>> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/cabihn6gycf5vsvfgedpyl0rcvxqv9phxwftj-fxbtebqptj...@mail.gmail.com> >>>> >>>> >>>> This intent message was generated by Chrome Platform Status >>>> <https://chromestatus.com/>. >>>> >>>> -- >>>> You received this message because you are subscribed to the Google >>>> Groups "blink-dev" group. >>>> To unsubscribe from this group and stop receiving emails from it, send >>>> an email to blink-dev+unsubscr...@chromium.org. >>>> To view this discussion on the web visit >>>> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CABihn6FXZjL0X-j6_ckQfcbTWFDHoTWJkd0_cLE82juYrUkVpw%40mail.gmail.com >>>> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CABihn6FXZjL0X-j6_ckQfcbTWFDHoTWJkd0_cLE82juYrUkVpw%40mail.gmail.com?utm_medium=email&utm_source=footer> >>>> . >>>> >>>> >>>> -- >>> You received this message because you are subscribed to the Google >>> Groups "blink-dev" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to blink-dev+unsubscr...@chromium.org. >>> To view this discussion on the web visit >>> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CABihn6F3bEt9b0U2BGgPrfs%2BetdtfYj-BQuKvHG%3D-CmDELyt-g%40mail.gmail.com >>> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CABihn6F3bEt9b0U2BGgPrfs%2BetdtfYj-BQuKvHG%3D-CmDELyt-g%40mail.gmail.com?utm_medium=email&utm_source=footer> >>> . >>> >> -- >> You received this message because you are subscribed to the Google Groups >> "blink-dev" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to blink-dev+unsubscr...@chromium.org. >> To view this discussion on the web visit >> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAKXHy%3DfpdyXYXpac_WqMif3E6uohvqmJ5kBHOqKTbuBs_HzdrA%40mail.gmail.com >> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAKXHy%3DfpdyXYXpac_WqMif3E6uohvqmJ5kBHOqKTbuBs_HzdrA%40mail.gmail.com?utm_medium=email&utm_source=footer> >> . >> > -- > You received this message because you are subscribed to the Google Groups > "blink-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to blink-dev+unsubscr...@chromium.org. > To view this discussion on the web visit > https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAL5BFfXYAMYKdvaHDg2vYxb3F5zWocTdE9Fm992z6UQ_SBCfmw%40mail.gmail.com > <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAL5BFfXYAMYKdvaHDg2vYxb3F5zWocTdE9Fm992z6UQ_SBCfmw%40mail.gmail.com?utm_medium=email&utm_source=footer> > . > -- TAMURA Kent Software Engineer, Google -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAGH7WqEzjvZcbGFbaOs7wHatg0Ys7d9KidHHiBR7p6Mt5_o-fA%40mail.gmail.com.
