Thanks for the approval! I'll enable it in M105, after the M104 branch this week.
On Wed, Jun 8, 2022 at 7:58 AM Mike Taylor <[email protected]> wrote: > LGTM3 > > On 6/8/22 2:56 AM, Yoav Weiss wrote: > > LGTM2 > > On Wed, Jun 1, 2022 at 5:50 PM Daniel Bratell <[email protected]> wrote: > >> LGTM1 >> >> /Daniel >> On 2022-05-25 11:03, Yoav Weiss wrote: >> >> Thanks for working on this!! :) >> >> On Mon, May 23, 2022 at 9:21 PM Xiaocheng Hu <[email protected]> >> wrote: >> >>> (Note: The feature no longer works on preloads, compared to the original >>> I2P. See explainer for details.) >>> >>> Contact emails [email protected] >>> >>> Explainer >>> https://gist.github.com/xiaochengh/9404abbecdc3b45c0e9f3d5e99fbc65d#file-proposal-v3-md >>> >>> Specification https://github.com/whatwg/html/pull/7474 >>> >>> Summary >>> >>> Allows putting 'blocking=render' as an attribute and value to a >>> <script>, <style> or stylesheet <link> to make it explicitly >>> render-blocking. The main usage is to avoid a flash of unstyled content or >>> user interactions with an immature page caused by, e.g., script-inserted >>> scripts/stylesheets, client-side A/B testing, etc. >>> >>> >>> Blink component Blink>HTML >>> <https://bugs.chromium.org/p/chromium/issues/list?q=component:Blink%3EHTML> >>> >>> Search tags render <https://chromestatus.com/features#tags:render>, >>> blocking <https://chromestatus.com/features#tags:blocking> >>> >>> TAG review https://github.com/w3ctag/design-reviews/issues/727 >>> >> >> I pinged the TAG review. Seems like we can wait a few more days to give >> them time to reach conclusions. >> >> >>> >>> >>> TAG review status Pending >>> >>> Risks >>> >>> >>> Interoperability and Compatibility >>> >>> This is a new feature. There are interop/compat risks only if other >>> browsers do not implement it. >>> >>> >>> Gecko: No signal ( >>> https://github.com/mozilla/standards-positions/issues/608) >>> >> >> I'd even say that they are cautiously slightly positive :) >> >> >>> >>> WebKit: No signal ( >>> https://lists.webkit.org/pipermail/webkit-dev/2022-January/032088.html) >>> >>> Web developers: Positive ( >>> https://bugs.chromium.org/p/chromium/issues/detail?id=1271296) >>> Generally positive / no major concerns when discussed at WHATWG ( >>> https://github.com/whatwg/html/issues/7299#issuecomment-985907750) and >>> WebPerfWG ( >>> https://docs.google.com/document/d/1GQpM8IvL4feXQ0oQdCQIPKhZZkMLNTYJQhBUntMxPkI/edit#heading=h.mldk2zafi9mw >>> ) >>> >>> Other signals: >>> >>> WebView application risks >>> >>> Does this intent deprecate or change behavior of existing APIs, such >>> that it has potentially high risk for Android WebView-based applications? >>> >>> No. >>> >>> >>> Debuggability >>> >>> Yes. Each network request emits a trace event, which has a >>> renderBlocking flag indicating whether the resource blocks rendering. For >>> more details, see >>> https://blog.webpagetest.org/posts/new-render-blocking-indicator-in-chrome-and-webpagetest/ >>> >>> >>> Is this feature fully tested by web-platform-tests >>> <https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md> >>> ? Yes >>> >>> Flag name chrome://flags/#enable-experimental-web-platform-features >>> >>> Requires code in //chrome? False >>> >>> Tracking bug >>> https://bugs.chromium.org/p/chromium/issues/detail?id=1271296 >>> >>> Estimated milestones >>> DevTrial on desktop 102 >>> DevTrial on Android 102 >>> >>> Anticipated spec changes >>> >>> Open questions about a feature may be a source of future web compat or >>> interop issues. Please list open issues (e.g. links to known github issues >>> in the project for the feature specification) whose resolution may >>> introduce web compat/interop risk (e.g., changing to naming or structure of >>> the API in a non-backward-compatible way). >>> >>> >>> Link to entry on the Chrome Platform Status >>> https://chromestatus.com/feature/5452774595624960 >>> >>> Links to previous Intent discussions Intent to prototype: >>> https://groups.google.com/a/chromium.org/g/blink-dev/c/ujX8Vbr_VFE/m/Z61eyTcoBAAJ >>> >>> >>> This intent message was generated by Chrome Platform Status >>> <https://chromestatus.com/>. >>> -- >>> You received this message because you are subscribed to the Google >>> Groups "blink-dev" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to [email protected]. >>> To view this discussion on the web visit >>> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAFqEGhaaBjkqwTRoJpstgJoYhFvgPQ5DFrFfR0hQo%3DKMJ2NjLg%40mail.gmail.com >>> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAFqEGhaaBjkqwTRoJpstgJoYhFvgPQ5DFrFfR0hQo%3DKMJ2NjLg%40mail.gmail.com?utm_medium=email&utm_source=footer> >>> . >>> >> -- >> You received this message because you are subscribed to the Google Groups >> "blink-dev" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected]. >> To view this discussion on the web visit >> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAL5BFfXoO%2BZ_EbNRzPJ6S38_9e3uM%3DT4qXE4POhoeRBkaiu6uw%40mail.gmail.com >> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAL5BFfXoO%2BZ_EbNRzPJ6S38_9e3uM%3DT4qXE4POhoeRBkaiu6uw%40mail.gmail.com?utm_medium=email&utm_source=footer> >> . >> >> -- > You received this message because you are subscribed to the Google Groups > "blink-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To view this discussion on the web visit > https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAL5BFfVpbX6L-ouxYOebU8_YacjJ4tQJtKtJy4R9PGH259AWqg%40mail.gmail.com > <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAL5BFfVpbX6L-ouxYOebU8_YacjJ4tQJtKtJy4R9PGH259AWqg%40mail.gmail.com?utm_medium=email&utm_source=footer> > . > > > -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAFqEGhYwC0ONEqax4W-3KXeM1_8rSJNajSrafshzajaNjV1K0g%40mail.gmail.com.
