Hi, After this CL <https://chromium-review.googlesource.com/c/chromium/src/+/3812107?usp=dashboard>, run_web_tests.py --additional-driver-flag no longer matches additional expectations under web_tests/FlagExpectations <https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/web_tests/FlagExpectations/;l=1?q=FlagExpectations&sq=&ss=chromium> or additional baselines under web_tests/flag-specific <https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/web_tests/flag-specific/>. Please use --flag-specific instead if you need that behavior.
The reason for the change is that the expectations file / baseline directory matching rule is complicated and sometimes problematic when --additional-driver-flag specifies multiple flags. --flag-specific can avoid the problems. Some new tools, e.g. remove_stale_expectations.py <https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/tools/remove_stale_expectations.py;l=1?q=remove_stale_expectations.py&sq=&ss=chromium>, support --flag-specific only. Note virtual suites are more suitable for testing small sets of web tests with flags. See this doc <https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_tests.md#Choosing-between-flag_specific-and-virtual-test-suite> for more details. Also note that for a blink runtime enabled feature that just adds an API without skipping any existing code path, setting status: "test" or status: "experimental" in runtime_enabled_features.json5 <https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/platform/runtime_enabled_features.json5;l=1?q=runtime_enabled_features.json5&ss=chromium> is preferred to a virtual suite or a flag-specific configuration. Xianzhu -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CADBxridWn9rzQz8FgtkuxRDUe0EYdWm8GygDZy%3DzDFmHG3%2BXog%40mail.gmail.com.
