> please update the chromestatus entry to indicate the "shipping" stage.
Done, thanks. This also made us realize we hadn't actually published the spec change (!); that is now up for review <https://github.com/w3c/payment-handler/pull/404> and we are working on associated WPT test changes. On Mon, 14 Nov 2022 at 11:27, Chris Harrelson <chris...@chromium.org> wrote: > Reusing this thread is fine, but please update the chromestatus entry > <https://chromestatus.com/feature/5190978431352832> to indicate the > "shipping" stage. > > > On Mon, Nov 14, 2022 at 8:02 AM Stephen McGruer <smcgr...@chromium.org> > wrote: > >> Hi folks, >> >> *TL;DR - we are requesting LGTM x3 to Remove this API in M111. Please let >> us know if we need to send a new Intent thread for that.* >> >> As we look at M111 coming up, we realized we made a communication error >> here which we would like to correct. The original post said: >> >> > *Estimated milestones* >> > Origin trial: 108 >> > Reverse origin trial: 111 >> > Removal: 114 >> >> This was a misunderstanding over what Removal meant. We thought "Reverse >> origin trial" implied that the feature would be disabled by default in >> M111, with a reverse-OT to re-enable it if needed, and then Removal was >> when the feature was completely off with no way to re-enable. However based >> on Yoav's comments above, we think API Owners may have thought that we were >> not intending to disable this feature until M114. >> >> So we are explicitly seeking approval to *Remove this API in M111*, >> alongside starting a reverse Origin Trial to guard against developers being >> caught by surprise. To the best of our knowledge this reverse Origin Trial >> will probably be unnecessary, as all known payment partners using >> PaymentHandler do not utilize these fields, however we are including it as >> a safe-guard. >> >> No developer signed up to the current Origin Trial, unfortunately >> (possibly because there is no impact), so we have no data from that. >> >> Please let us know if we should send a separate Intent to Remove thread >> instead, happy to do so. >> >> Thanks, >> Stephen >> >> On Tuesday, October 11, 2022 at 11:00:31 AM UTC-4 Rouslan Solomakhin >> wrote: >> >>> Hello, >>> >>> FYI, we are renaming the flag and reversing its meaning to make the >>> Origin Trial framework work. >>> >>> - Dev Trial: *chrome://flags/#identity-in-can-make-payment *- >>> enabled by default. Disabling this flag would remove the fields from the >>> "canmakepayment" event. >>> - Origin Trial: *chrome://flags/#clear-identity-in-can-make-payment* - >>> disabled by default. Enabling this flag will remove fields from the >>> "canmakepayment" event. >>> >>> This change is necessary because Origin Trials can only enable runtime >>> flags, not disable them. So, a flag must be default-disabled to be >>> togglable by an Origin Trial. More information is available in Proposal >>> to Fix the CanMakePayment Identity OT >>> <https://docs.google.com/document/d/1ItfkdtzDfZZfnuWHqwS9XSqexNQLsuN_4M_9PQZjQXE/edit?usp=sharing>. >>> This has also been discussed on blink-reviews-bindings@ >>> <https://groups.google.com/u/1/a/chromium.org/g/blink-reviews-bindings/c/MQkhAEiivNs> >>> . >>> >>> If you are feature-detecting the presence of the fields in the event, >>> the most reliable way is: >>> if (event.topOrigin) {} >>> if (event.paymentRequestOrigin) {} >>> if (evt.methodData && evt.methodData.length > 0) {} >>> if (evt.modifiers && evt.modifiers.length > 0) {} >>> >>> Cheers, >>> Rouslan >>> >>> On Tuesday, September 20, 2022 at 11:06:03 AM UTC-4 Rouslan Solomakhin >>> wrote: >>> >>>> > Chrome is reaching out to the known partners that may be depending on >>>> these fields. >>>> >>>> We have reached out to the known partners with dev-trial instructions >>>> and received back feedback that this change does not affect their API >>>> usage. >>>> >>>> > Estimated milestones >>>> > Origin trial: 108 >>>> > LGTM to run Origin Trial removal 108-110 >>>> >>>> M108 is upon us. We intend to start the origin trial shortly. >>>> >>>> On Wednesday, April 20, 2022 at 12:03:22 PM UTC-4 Yoav Weiss wrote: >>>> >>>>> LGTM to run Origin Trial removal 108-110 >>>>> >>>>> On Wednesday, April 20, 2022 at 4:27:10 PM UTC+2 Rouslan Solomakhin >>>>> wrote: >>>>> >>>>>> > So this intent is requesting to run the first OT M108-M110? >>>>>> >>>>>> Correct. >>>>>> >>>>>> > Any deprecation period you have in mind? >>>>>> >>>>>> Good point. We should start by printing a warning message when these >>>>>> fields are accessed for a few milestones. M105--M107 would be good. Do I >>>>>> need to resend this as an intent to deprecate first? >>>>>> >>>>> >>>>> LGTM to deprecate as well. From my perspective, you could start >>>>> deprecating earlier than 105, assuming we know the timelines we're aiming >>>>> for. >>>>> >>>>> >>>>>> >>>>>> On Wed, Apr 20, 2022 at 9:24 AM Yoav Weiss <yoavwe...@chromium.org> >>>>>> wrote: >>>>>> >>>>>>> So this intent is requesting to run the first OT M108-M110? >>>>>>> Any deprecation period you have in mind? >>>>>>> >>>>>>> It might be better to send separate intents for the rest when their >>>>>>> milestones get closer. >>>>>>> >>>>>>> On Mon, Apr 18, 2022 at 5:49 PM 'Rouslan Solomakhin' via blink-dev < >>>>>>> blink-dev@chromium.org> wrote: >>>>>>> >>>>>>>> Contact emailsrous...@chromium.org >>>>>>>> >>>>>>>> Specificationhttps://w3c.github.io/payment-handler/ >>>>>>>> >>>>>>>> Summary >>>>>>>> >>>>>>>> This is an early heads up that we intend to remove the merchant >>>>>>>> origin and arbitrary data from the "canmakepayment" service worker >>>>>>>> event of the Payment Handler API. These are the event fields to be >>>>>>>> removed: >>>>>>>> >>>>>>>> >>>>>>>> - topOrigin >>>>>>>> - paymentReuqestOrigin >>>>>>>> - methodData >>>>>>>> - modifiers >>>>>>>> >>>>>>>> The removal will be happening through the use of an origin trial at >>>>>>>> first, then a reverse origin trial, and finally removal. >>>>>>>> Blink componentBlink>Payments >>>>>>>> <https://bugs.chromium.org/p/chromium/issues/list?q=component:Blink%3EPayments> >>>>>>>> >>>>>>>> MotivationThe “canmakepayment” service worker event lets the >>>>>>>> merchant know whether the user has a card on file in an installed >>>>>>>> service-worker based payment app. It silently passes the merchants’ >>>>>>>> origin >>>>>>>> and arbitrary data to the service worker from the payment app origin. >>>>>>>> This >>>>>>>> cross-origin communication happens on new PaymentRequest() >>>>>>>> construction in JavaScript, does not require a user gesture, and does >>>>>>>> not >>>>>>>> show any user interface. >>>>>>>> >>>>>>>> Alternatively, we have considered and dismissed the option to >>>>>>>> remove the “canmakepayment” event entirely and behave as if it >>>>>>>> always returns "true", because some payment app partners have >>>>>>>> indicated to >>>>>>>> us that's what they always do. However, the data that we have collected >>>>>>>> shows that the “canmakepayment” event returns "false" 1% to 6% of >>>>>>>> the time, depending on the platform. >>>>>>>> >>>>>>>> TAG review statusNot applicable >>>>>>>> >>>>>>>> Risks >>>>>>>> Interoperability and Compatibility >>>>>>>> >>>>>>>> Only Chrome has implemented the Payment Handler API. >>>>>>>> >>>>>>>> Chrome is reaching out to the known partners that may be depending >>>>>>>> on these fields. >>>>>>>> >>>>>>>> WebView application risks >>>>>>>> >>>>>>>> The Payment Handler API requires the use of the PaymentRequest API. >>>>>>>> Neither API is available in WebView. >>>>>>>> >>>>>>>> >>>>>>>> Is this feature fully tested by web-platform-tests >>>>>>>> <https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md> >>>>>>>> ?Yes >>>>>>>> <https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/web_tests/external/wpt/payment-handler/;drc=f539fffb79da2c97b1a06cbca88cc6d5a93ddc77> >>>>>>>> >>>>>>>> Flag namePaymentHandlerMerchantIdentity >>>>>>>> >>>>>>>> Requires code in //chrome?True >>>>>>>> >>>>>>>> Estimated milestones >>>>>>>> >>>>>>>> Origin trial: 108 >>>>>>>> >>>>>>>> Reverse origin trial: 111 >>>>>>>> >>>>>>>> Removal: 114 >>>>>>>> >>>>>>>> Link to entry on the Chrome Platform Status >>>>>>>> https://chromestatus.com/feature/5190978431352832 >>>>>>>> >>>>>>>> This intent message was generated by Chrome Platform Status >>>>>>>> <https://chromestatus.com/>. >>>>>>>> >>>>>>>> -- >>>>>>>> You received this message because you are subscribed to the Google >>>>>>>> Groups "blink-dev" group. >>>>>>>> To unsubscribe from this group and stop receiving emails from it, >>>>>>>> send an email to blink-dev+unsubscr...@chromium.org. >>>>>>>> To view this discussion on the web visit >>>>>>>> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAMMzaWFz1UFWxgOs%2BECSdF2Bt8JpsBkGtv2wMnq2pemGMmD8Fw%40mail.gmail.com >>>>>>>> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAMMzaWFz1UFWxgOs%2BECSdF2Bt8JpsBkGtv2wMnq2pemGMmD8Fw%40mail.gmail.com?utm_medium=email&utm_source=footer> >>>>>>>> . >>>>>>>> >>>>>>> -- >> You received this message because you are subscribed to the Google Groups >> "blink-dev" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to blink-dev+unsubscr...@chromium.org. >> To view this discussion on the web visit >> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/f36b8343-bf42-4e69-99de-e2530de63182n%40chromium.org >> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/f36b8343-bf42-4e69-99de-e2530de63182n%40chromium.org?utm_medium=email&utm_source=footer> >> . >> > -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CADY3MaeKN4JVFNPgeN%3DzPAT6BSRw5ypObZ6D_ys21KLfXpNQ0g%40mail.gmail.com.
