On Thu, Nov 17, 2022 at 12:42 PM Yoav Weiss <yoavwe...@chromium.org> wrote:
> If this is indeed dead code, then this change is not web exposed, and > hence no LGTMs are needed > SGTM. > Can you outline how this test is testing that we're ignoring these > parameters? I'm not sure I get it.. Also, Safari seems to be failing > <https://wpt.fyi/results/html/canvas/offscreen/manual/wide-gamut-canvas/2d.color.space.p3.convertToBlobp3.canvas.html?label=master&label=experimental&aligned> > that test.. > May be nice to add dedicated tests for both of these parameters to ensure > they are ignored before deleting them. > The parameter has a default color space of sRGB. If we were to respect that, then, in the canvas-to-blob-to-image-to-canvas round-trip, all colors would be clamped to sRGB. To look a bit more carefully, this test only uses within-sRGB colors, so no clamping would be detected. I'll update it when removing the parameters. > -- >> You received this message because you are subscribed to the Google Groups >> "blink-dev" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to blink-dev+unsubscr...@chromium.org. >> To view this discussion on the web visit >> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAGnfxj9rOCB-Fy6obWWJB_AeFKZ6cCAkfZf16v8s0jgiAtDyTg%40mail.gmail.com >> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAGnfxj9rOCB-Fy6obWWJB_AeFKZ6cCAkfZf16v8s0jgiAtDyTg%40mail.gmail.com?utm_medium=email&utm_source=footer> >> . >> > -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAGnfxj_kqY6r7P4tEZNaKPSxSqLFtddBUgKDKPyzA7Sv42Gbug%40mail.gmail.com.
