LGTM3. -mike
On Friday, November 18, 2022 at 4:24:43 PM UTC+1 Mike Taylor wrote: > LGTM2. I think we should expect some compat issues with this change, but > they're currently the ones experienced by Safari and Firefox: > > https://github.com/jsbin/jsbin/issues/3485 > https://github.com/webcompat/web-bugs/issues/105859 > https://bugzilla.mozilla.org/show_bug.cgi?id=1737541 (see bugs in "See > also") > > Do we have any plans to make the developer community aware of the need to > delegate web-share permission to iframes now? Maybe a blog post in the > works? > > On 11/18/22 4:25 AM, Yoav Weiss wrote: > > LGTM1 > > Thanks for catching us up here! :) > > On Thu, Nov 17, 2022 at 11:18 PM Eric Willigers < > ericwillig...@chromium.org> wrote: > >> Contact emails >> ericwillig...@chromium.org, fin...@chromium.org >> >> Explainer >> https://github.com/w3c/web-share/blob/master/docs/explainer.md >> >> Specification >> https://w3c.github.io/web-share/#permissions-policy >> >> Summary >> A new permission policy, "web-share", controls access to >> navigator.share(). >> >> The default allowlist is 'self', avoiding possible abuse by third party >> iframes. >> Link to blink-dev discussion >> >> https://groups.google.com/a/chromium.org/g/blink-dev/c/fgme9KOd8CU/m/TCYPKQAXAwAJ >> >> Blink component >> Blink>WebShare >> <https://bugs.chromium.org/p/chromium/issues/list?q=component:Blink%3EWebShare> >> >> TAG review >> Not needed, trivial change to existing spec >> > > A better reasoning would be that we're aligning to shipped behavior in > other engines. > > >> >> TAG review status >> Not applicable >> >> >> Risks >> >> Interoperability and Compatibility >> >> navigator.share() is called by embedded iframes. These may expect share() >> calls to succeed, when now they will fail if permission has not been >> granted. >> >> Firefox has successfully shipped the feature. >> >> Failures were observed with YouTube, these have now been addressed. >> >> >> >> Gecko: Shipped/Shipping (https://github.com/w3c/web-share/pull/252) >> >> WebKit: Shipped/Shipping (https://github.com/w3c/web-share/issues/169) >> CL recently merged: >> https://github.com/WebKit/WebKit/commit/ded7a6094a6ca38833e63a7915b7b6a2832f5734 >> >> Web developers: No signals >> >> Other signals: >> >> WebView application risks >> >> Does this intent deprecate or change behavior of existing APIs, such that >> it has potentially high risk for Android WebView-based applications? >> >> N/A - Web Share API is not enabled in WebView. >> >> >> Debuggability >> No DevTools changes needed. >> >> Will this feature be supported on all six Blink platforms (Windows, Mac, >> Linux, Chrome OS, Android, and Android WebView)? >> >> No >> >> The Permissions Policy will be supported on all platforms that support >> Web Share API. Currently, this is Android, Chrome OS, Windows. >> >> Is this feature fully tested by web-platform-tests >> <https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md> >> ? >> Yes >> >> Flag name >> >> Requires code in //chrome? >> False >> >> >> Tracking bug >> https://bugs.chromium.org/p/chromium/issues/detail?id=1079104 >> >> Sample links >> https://scrawny-bottlenose-somersault.glitch.me/share-from-iframes.html >> >> Estimated milestones >> M110 >> >> Anticipated spec changes >> >> - >> >> >> Link to entry on the Chrome Platform Status >> https://chromestatus.com/feature/6362499966304256 >> >> >> This intent message was generated by Chrome Platform Status >> <https://chromestatus.com/>. >> >> -- >> You received this message because you are subscribed to the Google Groups >> "blink-dev" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to blink-dev+unsubscr...@chromium.org. >> To view this discussion on the web visit >> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/e4303ef1-c709-4f90-b97b-e2fc4b0f2e2bn%40chromium.org >> >> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/e4303ef1-c709-4f90-b97b-e2fc4b0f2e2bn%40chromium.org?utm_medium=email&utm_source=footer> >> . >> > -- > You received this message because you are subscribed to the Google Groups > "blink-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to blink-dev+unsubscr...@chromium.org. > > To view this discussion on the web visit > https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAL5BFfV%3DC7ac0_gk89v7sG8X3kyOSxN%3DFH0i2DpCQ2iYrweDzw%40mail.gmail.com > > <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAL5BFfV%3DC7ac0_gk89v7sG8X3kyOSxN%3DFH0i2DpCQ2iYrweDzw%40mail.gmail.com?utm_medium=email&utm_source=footer> > . > > > -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/29729480-3327-46bd-86e7-045a0ffcf4a3n%40chromium.org.
