LGTM3

On 1/25/23 12:36 PM, Rick Byers wrote:
LGTM2

On Tue, Jan 24, 2023 at 2:44 AM Kenichi Ishibashi <[email protected]> wrote:

    Thank you Yoav for the suggestions! I'll add more words and
    context next time.

    On Mon, Jan 23, 2023 at 2:18 PM Yoav Weiss
    <[email protected]> wrote:

        LGTM1

        On Mon, Jan 23, 2023 at 2:57 AM Kenichi Ishibashi
        <[email protected]> wrote:


                    Contact emails

            [email protected]


                    Explainer

            None. This feature is standardized.


        It's typically helpful to write a few words that explain the
        feature and the addition to it, even if there's no need for a
        full fledged explainer document for this specific addition.
        For example, you could have linked to the feature'sĀ broader
        explainer
        <https://github.com/bashi/early-hints-explainer/blob/main/explainer.md>,
        and then explain that this adds a new `as` value of "fetch"
        that would enable developers to use Early Hints for resources
        with that potential destination (e.g. `fetch()`ed resources).



                    Specification

            https://html.spec.whatwg.org/multipage/semantics.html#attr-link-as

            https://html.spec.whatwg.org/#early-hints


                    Summary

            Support <link rel=preload as=fetch> in navigation early
            hints. This allows web developers to preload resources
            that are fetched by the fetch() API.



                    Blink component

            Blink>Loader>Preload
            
<https://bugs.chromium.org/p/chromium/issues/list?q=component:Blink%3ELoader%3EPreload>


                    TAG review



                    TAG review status

            Not applicable


        I agree that a TAG review is not needed here, but it's
        typically better to outline the reason.
        In this case, we're adding support for an extra type of
        resource without changing the API's shape or its integration
        with the rest of the platform.



                    Risks



                    Interoperability and Compatibility

            Low. The feature is already specified in the HTML and the
            Fetch standard.



            /Gecko/: In development
            (https://bugzilla.mozilla.org/show_bug.cgi?id=1407355)

            /WebKit/: No signal Previously asked in
            https://lists.webkit.org/pipermail/webkit-dev/2021-May/031861.html

            /Web developers/: No signals. We got this feature request
            from one of our partners.


        I would count a feature request as a slightly positive signal.


            /Other signals/:


                    WebView application risks

            N/A



                    Debuggability

            We have a tracking bug
            <https://bugs.chromium.org/p/chromium/issues/detail?id=1317936>
            to improve debuggability.


                    Will this feature be supported on all six Blink
                    platforms (Windows, Mac, Linux, Chrome OS,
                    Android, and Android WebView)?

            Yes


                    Is this feature fully tested by web-platform-tests
                    
<https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md>?

            We will submit a Web Platform Test along with the
            implementation (Ongoing CL
            
<https://chromium-review.googlesource.com/c/chromium/src/+/4177723>).


                    Flag name

            N/A


                    Requires code in //chrome?

            False


                    Tracking bug

            https://bugs.chromium.org/p/chromium/issues/detail?id=1408649


                    Estimated milestones

            M112



                    Anticipated spec changes

            None



                    Link to entry on the Chrome Platform Status

            https://chromestatus.com/feature/6195487999262720

            This intent message was generated by Chrome Platform
            Status <https://chromestatus.com/>.
-- You received this message because you are subscribed to
            the Google Groups "blink-dev" group.
            To unsubscribe from this group and stop receiving emails
            from it, send an email to [email protected].
            To view this discussion on the web visit
            
https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAPLXX--M%3DZkTz-ZicOW61C9tUJjKvz4cQU49EsnDK7PUG5puGg%40mail.gmail.com
            
<https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAPLXX--M%3DZkTz-ZicOW61C9tUJjKvz4cQU49EsnDK7PUG5puGg%40mail.gmail.com?utm_medium=email&utm_source=footer>.

-- You received this message because you are subscribed to the Google
    Groups "blink-dev" group.
    To unsubscribe from this group and stop receiving emails from it,
    send an email to [email protected].
    To view this discussion on the web visit
    
https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAPLXX-_O7%2Buvu8VbMox69M7f0E7BeEeZ1BC4frEkoXbytaLbdQ%40mail.gmail.com
    
<https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAPLXX-_O7%2Buvu8VbMox69M7f0E7BeEeZ1BC4frEkoXbytaLbdQ%40mail.gmail.com?utm_medium=email&utm_source=footer>.

--
You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAFUtAY9-xG%2BKWcNSVkhh-%3DRQ8na7J%2BcNN85VGc7cefuUi8Hn4w%40mail.gmail.com <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAFUtAY9-xG%2BKWcNSVkhh-%3DRQ8na7J%2BcNN85VGc7cefuUi8Hn4w%40mail.gmail.com?utm_medium=email&utm_source=footer>.

--
You received this message because you are subscribed to the Google Groups 
"blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion on the web visit 
https://groups.google.com/a/chromium.org/d/msgid/blink-dev/dcb86a9d-17f5-adaa-7692-d969a7c50724%40chromium.org.

Reply via email to