LGTM3 On Wed, Feb 8, 2023 at 8:19 AM Rick Byers <rby...@chromium.org> wrote:
> LGTM2 > > On Wed, Feb 8, 2023 at 10:20 AM Yoav Weiss <yoavwe...@chromium.org> wrote: > >> LGTM1 >> >> Thanks for aligning with the spec! >> >> On Wed, Feb 8, 2023 at 1:35 AM Ken Russell <k...@chromium.org> wrote: >> >>> Contact emails >>> >>> k...@chromium.org >>> >>> Explainer >>> >>> None >>> >>> Specification >>> >>> https://registry.khronos.org/webgl/specs/latest/1.0 >>> >>> Summary >>> >>> The WebGLContextEvent type has been defined in Khronos' WebGL >>> specification for a number of years, but it was not noticed until recently >>> that in Blink, this type is not exposed on web workers. (Most applications >>> simply add an event listener for the type, and do not look for its >>> prototype in the global scope.) >>> >>> This is a simple fix to Blink's Web IDL for WebGLContextEvent, but is a >>> web exposed change. >>> >>> >>> >>> Blink component >>> >>> Blink>WebGL >>> <https://bugs.chromium.org/p/chromium/issues/list?q=component:Blink%3EWebGL> >>> >>> Motivation >>> >>> See Summary. >>> >>> >>> Initial public proposal >>> >>> None; standardized years ago in Khronos when WebGL support was added to >>> OffscreenCanvas. >>> >>> >>> TAG review >>> >>> None; standardized years ago in Khronos when WebGL support was added to >>> OffscreenCanvas. >>> >>> >>> TAG review status >>> >>> Not applicable >>> >>> Risks >>> >>> Interoperability and Compatibility >>> >> >> I can't imagine a compat risk here (that is, can't see how reasonable >> content would rely on the fact that this object is *not* exposed in >> workers). >> From an interop perspective, there's risk if we don't align with the spec >> and other implementers. >> >> >>> >>> >>> Gecko: Already implemented >>> >>> WebKit: Just implemented in >>> https://bugs.webkit.org/show_bug.cgi?id=251504 >>> >>> Web developers: Meet team reported this missing prototype in an >>> internal bug report. >>> >>> Other signals: >>> >>> WebView application risks >>> >>> Does this intent deprecate or change behavior of existing APIs, such >>> that it has potentially high risk for Android WebView-based applications? >>> >>> No >>> >>> >>> Debuggability >>> >>> Is this feature fully tested by web-platform-tests >>> <https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md> >>> ? >>> >>> Yes >>> >>> Flag name >>> >>> None >>> >>> Requires code in //chrome? >>> >>> False >>> >>> Estimated milestones >>> >>> M113 >>> >>> >>> Link to entry on the Chrome Platform Status >>> >>> https://chromestatus.com/feature/5071251544997888 >>> >>> This intent message was generated by Chrome Platform Status >>> <https://chromestatus.com/>. >>> >>> -- >>> You received this message because you are subscribed to the Google >>> Groups "blink-dev" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to blink-dev+unsubscr...@chromium.org. >>> To view this discussion on the web visit >>> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAMYvS2czQWvKTcvph9HNX34LH_V6EerUCLyHWOx-XrTJnar_gQ%40mail.gmail.com >>> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAMYvS2czQWvKTcvph9HNX34LH_V6EerUCLyHWOx-XrTJnar_gQ%40mail.gmail.com?utm_medium=email&utm_source=footer> >>> . >>> >> -- >> You received this message because you are subscribed to the Google Groups >> "blink-dev" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to blink-dev+unsubscr...@chromium.org. >> To view this discussion on the web visit >> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAL5BFfU%2BFYwex9_1rhgEpq9SJgsLbOwWj3kyVC92fpswdbJoow%40mail.gmail.com >> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAL5BFfU%2BFYwex9_1rhgEpq9SJgsLbOwWj3kyVC92fpswdbJoow%40mail.gmail.com?utm_medium=email&utm_source=footer> >> . >> > -- > You received this message because you are subscribed to the Google Groups > "blink-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to blink-dev+unsubscr...@chromium.org. > To view this discussion on the web visit > https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAFUtAY966bvG78y8Vw%2BTK841AsHn%3DTnPQeG%2B%2BLPTLeHyTxoDUQ%40mail.gmail.com > <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAFUtAY966bvG78y8Vw%2BTK841AsHn%3DTnPQeG%2B%2BLPTLeHyTxoDUQ%40mail.gmail.com?utm_medium=email&utm_source=footer> > . > -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAOMQ%2Bw8PPZdO%3D_gcBCD_vH7mKdKLY82XA7dpUU9TYd4ouDODAQ%40mail.gmail.com.
