LGTM1 On Wed, Feb 15, 2023 at 6:38 AM Yoav Weiss <yoavwe...@chromium.org> wrote:
> Any update on the other questions I asked above? > > On Mon, Feb 13, 2023 at 3:31 PM Jiacheng Guo <g...@google.com> wrote: > >> The implementation and the feature has been updated with the feature flag >> StrictIPv4EmbeddedIPv6AddressParsing. >> >> Thanks for the advice. >> >> On Thu, Feb 9, 2023 at 12:15 AM Yoav Weiss <yoavwe...@chromium.org> >> wrote: >> >>> >>> >>> On Tue, Feb 7, 2023 at 6:56 AM 'Jiacheng Guo' via blink-dev < >>> blink-dev@chromium.org> wrote: >>> >>>> Contact emails...@google.com >>>> >>>> ExplainerThis is an implementation of an established standard. >>>> >>>> Specificationhttps://url.spec.whatwg.org/#concept-ipv6-parser >>>> >>>> Summary >>>> >>>> The behavior of parsing IPv4 embedded IPv6 host parser will be updated >>>> to strictly follow the web URL standard: >>>> https://url.spec.whatwg.org/#concept-ipv6-parser The introduced >>>> restrictions on the IPv6 address are: * The embedded IPv4 address shall >>>> always consist of 4 parts. Addresses with less than 4 parts like >>>> http://[::1.2] >>>> will be no longer valid. * Embedded IPv4 addresses with trailing dots like >>>> http://[::1.2.3.4.] will be no longer valid. The feature is a part of >>>> the URL interop 2023. >>>> >>>> >>>> Blink componentBlink>Network >>>> <https://bugs.chromium.org/p/chromium/issues/list?q=component:Blink%3ENetwork> >>>> >>>> TAG reviewNot required for the URL standard. >>>> >>>> TAG review statusNot applicable >>>> >>>> Risks >>>> >>>> >>>> Interoperability and Compatibility >>>> >>>> The URL standard is a well-established standard and the fix is a part >>>> of the Interop. No interoperability risk is expected. Shortened IPv4 >>>> addresses embedded in IPv6 are rarely used. Compatibility risk shall be >>>> minimal. >>>> >>> >>> How many such URLs do we see? Any use counters? (or another form of risk >>> analysis) >>> >>> >>>> >>>> >>>> *Gecko*: Shipped/Shipping ( >>>> https://wpt.fyi/results/url/url-constructor.any.html%3Fexclude%3D) The >>>> IPv6 parser in Safari has already forced the check. >>>> >>> >>> You mean Gecko? >>> >>> >>>> >>>> *WebKit*: Shipped/Shipping ( >>>> https://wpt.fyi/results/url/url-constructor.any.html%3Fexclude%3D) The >>>> IPv6 parser in Safari has already forced the check. >>>> >>>> *Web developers*: No signals >>>> >>>> *Other signals*: >>>> >>>> WebView application risks >>>> >>>> Does this intent deprecate or change behavior of existing APIs, such >>>> that it has potentially high risk for Android WebView-based applications? >>>> >>>> >>>> >>>> Debuggability >>>> >>>> >>>> Invalid URLs will be reported in devtools. >>>> >>>> Will this feature be supported on all six Blink platforms (Windows, >>>> Mac, Linux, Chrome OS, Android, and Android WebView)?Yes >>>> >>>> Is this feature fully tested by web-platform-tests >>>> <https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md> >>>> ?Yes >>>> Under https://wpt.fyi/results/url/url-constructor.any.html%3Fexclude%3D >>>> >>>> Flag name >>>> Not under a flag. >>>> >>> >>> You probably want to put such a change behind a base feature flag, to >>> enable turning it off in case of unanticipated breakage. >>> >>> >>>> >>>> Requires code in //chrome?False >>>> >>>> Tracking bughttps://crbug.com/1411619 >>>> >>>> Sample links >>>> https://chromium-review.googlesource.com/c/chromium/src/+/4206417 >>>> >>>> Estimated milestones >>>> >>>> M113 >>>> >>>> Anticipated spec changes >>>> >>>> No spec change >>>> >>>> >>>> Link to entry on the Chrome Platform Status >>>> https://chromestatus.com/feature/5184515301965824 >>>> >>>> Links to previous Intent discussions >>>> >>>> This intent message was generated by Chrome Platform Status >>>> <https://chromestatus.com/>. >>>> >>>> -- >>>> You received this message because you are subscribed to the Google >>>> Groups "blink-dev" group. >>>> To unsubscribe from this group and stop receiving emails from it, send >>>> an email to blink-dev+unsubscr...@chromium.org. >>>> To view this discussion on the web visit >>>> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAJQw1NxUtU8Wns3TYrEQZGQbWQNhNzKm41xYsfv0CKxSO_AngA%40mail.gmail.com >>>> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAJQw1NxUtU8Wns3TYrEQZGQbWQNhNzKm41xYsfv0CKxSO_AngA%40mail.gmail.com?utm_medium=email&utm_source=footer> >>>> . >>>> >>> -- > You received this message because you are subscribed to the Google Groups > "blink-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to blink-dev+unsubscr...@chromium.org. > To view this discussion on the web visit > https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAL5BFfWezQAhPhZ3sGjpndjbOGZhaAavV6mo5-boWspQRh3L9g%40mail.gmail.com > <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAL5BFfWezQAhPhZ3sGjpndjbOGZhaAavV6mo5-boWspQRh3L9g%40mail.gmail.com?utm_medium=email&utm_source=footer> > . > -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAOMQ%2Bw93hg1jF-mQFixOWfSc%2BOXbGkQkEBA4RNrdKKgoGoMziQ%40mail.gmail.com.
