LGTM1, simple ergonomic addition.

On 2/23/23 7:07 AM, Kenichi Ishibashi wrote:


        Contact emails

[email protected]


        Explainer

This is a small extension to URLSearchParams. Web developers can use the `size` attribute to check whether there are any query parameters in a URLSearchParams object.


        Specification

https://url.spec.whatwg.org/#dom-urlsearchparams-size


        Summary

Add a size getter to URLSearchParams. It's useful to check whether there are any query parameters in a URLSearchParams object.



        Blink component

Blink <https://bugs.chromium.org/p/chromium/issues/list?q=component:Blink>


        TAG review

Not applicable. The URL Standard is already updated.
FYI, this isn't really a justification why TAG review shouldn't happen - the TAG does review additions to existing specs. But no review is needed because this is such a simple change, IMHO.


        TAG review status

Not applicable


        Risks



        Interoperability and Compatibility



/Gecko/: No signal
Not an official signal, but there is a patch up at https://bugzilla.mozilla.org/show_bug.cgi?id=1818269. But this is such a small change, we don't need to request an official position.

/WebKit/: Positive (https://github.com/whatwg/url/pull/734)
WebKit bug is here, https://bugs.webkit.org/show_bug.cgi?id=252749#c1 for anyone who is curious.

/Web developers/: Positive (https://github.com/whatwg/url/issues/163)

/Other signals/:


        WebView application risks


        Debuggability

An attribute can be suspected by DevTools and other tools.


        Will this feature be supported on all six Blink platforms
        (Windows, Mac, Linux, Chrome OS, Android, and Android WebView)?

Yes


        Is this feature fully tested by web-platform-tests
        
<https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md>?

Yes
https://wpt.fyi/results/url/urlsearchparams-size.any.html?label=experimental (to appear)


        Flag name

N/A


        Requires code in //chrome?

False


        Tracking bug

https://bugs.chromium.org/p/chromium/issues/detail?id=1418374


        Estimated milestones

M113



        Anticipated spec changes

No.


        Link to entry on the Chrome Platform Status

https://chromestatus.com/feature/5197222754385920

This intent message was generated by Chrome Platform Status <https://chromestatus.com/>.
--
You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAPLXX-_OFPuEo8etovj4_HdWgtwvy3QOxOm6XS1e75EVueVgEQ%40mail.gmail.com <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAPLXX-_OFPuEo8etovj4_HdWgtwvy3QOxOm6XS1e75EVueVgEQ%40mail.gmail.com?utm_medium=email&utm_source=footer>.

--
You received this message because you are subscribed to the Google Groups 
"blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion on the web visit 
https://groups.google.com/a/chromium.org/d/msgid/blink-dev/6de08e84-36f1-ffbc-81f9-438f30761b5d%40chromium.org.

Reply via email to