On 3/13/23 04:02, Koji Ishii wrote:
> This intent to ship just says that you will ship 'text-wrap'. It
doesn't say
> that you will also implement 'white-space-collapse' (the other longhand
of
> 'white-space') or the shorthanding relationship between 'text-wrap' and
> 'white-space'. I therefore assume you're shipping 'text-wrap' as an
> independent property, and this is not going to be spec-compatible.
Koji will need to speak to this.
We have implemented a similar approach as the vertical-align/baseline-source
case
<https://groups.google.com/a/chromium.org/g/blink-dev/c/gLNyu0lTRS0/m/GqVBzSsbAAAJ> so that setting the `white-space` resets the `text-wrap: wrap`. The current impl passes this cascading test <https://github.com/web-platform-tests/wpt/blob/69982c63f5/css/css-text/white-space/text-wrap-white-space-001.html>.
That test doesn't cover the interaction of other values of `white-space` with
the `nowrap` value of `text-wrap`. It would be incorrect for e.g.
`white-space: pre` to return `text-wrap: wrap`.
I think it would be better to just implement both longhands of `white-space`
properly.
> I think it's at a good quality to ship, and we can expect more feedback
for the next stage.
I'm not concerned about the quality of the balancing, as I'm sure it's fine,
and it will improve over time... my concerns are mainly with
a) interaction of the properties
b) any layout interactions with e.g. floats, initial-letter, positioning, text
justification, box sizing, etc.
c) whether the CSSWG considers this stable enough to ship, or if there are
unresolved concerns about the design of the feature
I'll note that there was an issue filed in the CSSWG repo recently in response
to the Blink implementation:
https://github.com/w3c/csswg-drafts/issues/8516
and it raises questions about sizing and floats, among other things.
See also questions in the 2nd paragraph of
https://groups.google.com/a/chromium.org/g/blink-dev/c/f5eLz6PIXaI/m/a9OGhvaNAAAJ
which seem to have been mostly ignored...
Thanks~
~fantasai
--
You received this message because you are subscribed to the Google Groups
"blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to blink-dev+unsubscr...@chromium.org.
To view this discussion on the web visit
https://groups.google.com/a/chromium.org/d/msgid/blink-dev/fdd4574a-fefd-042b-23de-c18ab5398645%40inkedblade.net.
