LGTM2 /Daniel
On 2023-04-05 05:58, Yoav Weiss wrote:
LGTM1 once this is WPT tested with good coverage and our shipped behavior matches both WebKit and the spec. Please get back to this thread if e.g. the implemented WebKit behavior varies from the specified one.On Thu, Mar 30, 2023 at 9:09 AM Roger Zanoni <rzan...@igalia.com> wrote: Hi Philip, thanks for looking for the tests, they are relevant but they don't cover some cases, like implicit wildcard matching with more than one language subtags, private singleton matching I think we should add more cases to wpt tests targeting specific level4 matching logic, like the cases that are tested on https://github.com/WebKit/WebKit/blob/main/LayoutTests/fast/selectors/lang-extended-filtering.html and https://github.com/WebKit/WebKit/blob/main/LayoutTests/fast/selectors/lang-extended-filtering-with-string-arguments.html About the standards-positions issue, I filed it on https://github.com/mozilla/standards-positions/issues/735 On Wednesday, March 29, 2023 at 6:00:19 PM UTC+2 Philip Jägenstedt wrote: Hi Roger, I took a look for the tests, and am wondering if the tests added here are for Level 4? https://github.com/web-platform-tests/wpt/pull/37950 At least some of them are already passing in Chrome Dev (with experimental features enabled), but not Chrome stable, so some of these tests seem relevant. Overall, is the test coverage for this feature in WPT satisfactory? As Yoav said, a standards-positions issue for Gecko would be great, mostly as a heads up that we're shipping this and it's already shipping in Safari. Best regards, Philip On Fri, Mar 17, 2023 at 10:59 AM Yoav Weiss <yoav...@chromium.org> wrote: On Thu, Mar 16, 2023 at 11:09 AM Roger Zanoni <rza...@igalia.com> wrote: Contact emails rza...@igalia.com Explainer https://github.com/rogerzanoni/docs/tree/main/lang-level-4 Specification https://www.w3.org/TR/selectors-4/#the-lang-pseudo Summary The :lang CSS pseudo-class currently matches elements based on level 3 specs logic, which describes a prefix-matching rule to match language values. The level 4 spec changes this matching logic, supporting argument-list and language range matching (according to the specs of the extended filtering operation from RFC4647 - Matching of language tags - section 3.3.2, and the simple priority list matching described on section 2.3) Blink component Blink>CSS <https://bugs.chromium.org/p/chromium/issues/list?q=component:Blink%3ECSS> Search tags css <https://chromestatus.com/features#tags:css>,lang <https://chromestatus.com/features#tags:lang>,pseudo <https://chromestatus.com/features#tags:pseudo> TAG review Just extends functionality of the existing :lang selector. TAG review status Not applicable Risks Interoperability and Compatibility This change mostly extends :lang functionality and don't change existing behavior, except for adding implicit wildcard matching, which breaks one of the existing level 3 tests: https://wpt.fyi/results/css/selectors/i18n/css3-selectors-lang-005.html /Gecko/: No signal (https://bugzilla.mozilla.org/show_bug.cgi?id=1121792) Can you file for a Mozilla position? https://bit.ly/blink-signals /WebKit/: Shipped/Shipping (https://webkit.org/status/#feature-css-selector-:lang) /Web developers/: No signals /Other signals/: CSSWG consensus to ship documented inhttps://www.w3.org/TR/css-2017/#experimental(CSSWG includes reps from all major browser vendors) WebView application risks Does this intent deprecate or change behavior of existing APIs, such that it has potentially high risk for Android WebView-based applications? No. Debuggability Automatically supported, same as other pseudo-elements. Will this feature be supported on all six Blink platforms (Windows, Mac, Linux, Chrome OS, Android, and Android WebView)? Yes Is this feature fully tested byweb-platform-tests <https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md>? No Why not? How do we know that WebKit actually supports this if it's not tested? Flag name Requires code in //chrome? False Tracking bug https://bugs.chromium.org/p/chromium/issues/detail?id=1281157 Estimated milestones No milestones specified Anticipated spec changes Open questions about a feature may be a source of future web compat or interop issues. Please list open issues (e.g. links to known github issues in the project for the feature specification) whose resolution may introduce web compat/interop risk (e.g., changing to naming or structure of the API in a non-backward-compatible way). Link to entry on the Chrome Platform Status https://chromestatus.com/feature/5071058079055872 Links to previous Intent discussions Intent to prototype:https://groups.google.com/a/chromium.org/d/msgid/blink-dev/dd1cdecb-3bd5-cf6c-bf5c-120735d36ee6%40igalia.com This intent message was generated byChrome Platform Status <https://chromestatus.com/>.-- You received this message because you are subscribedto the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+...@chromium.org. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/29b5144d-ba62-bfc9-677c-a9a7e72c09f9%40igalia.com <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/29b5144d-ba62-bfc9-677c-a9a7e72c09f9%40igalia.com?utm_medium=email&utm_source=footer>.-- You received this message because you are subscribed tothe Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+...@chromium.org. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAL5BFfW9m-osR6jJ0jNC9-w_j9jVRR7GaB41%2B%2BBPPJXOQAbSqw%40mail.gmail.com <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAL5BFfW9m-osR6jJ0jNC9-w_j9jVRR7GaB41%2B%2BBPPJXOQAbSqw%40mail.gmail.com?utm_medium=email&utm_source=footer>.-- You received this message because you are subscribed to the GoogleGroups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/ecdf13bd-734a-430c-bb1d-7d6f5c43ae71n%40chromium.org <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/ecdf13bd-734a-430c-bb1d-7d6f5c43ae71n%40chromium.org?utm_medium=email&utm_source=footer>. --You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAL5BFfXQF3bDjxk4tfgG-0KZPXEuE2UfUS1F5veLtGOd%2BdPfEQ%40mail.gmail.com <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAL5BFfXQF3bDjxk4tfgG-0KZPXEuE2UfUS1F5veLtGOd%2BdPfEQ%40mail.gmail.com?utm_medium=email&utm_source=footer>.
-- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/d2e1b9e1-4e73-90f3-7c29-d6304afdfd31%40gmail.com.
