LGTM1. Testing looks good, and skipping the TAG review for features specified and shipped in other browsers is pretty reasonable. The flat UseCounter also gives me confidence. :)
-mike On Wed, Apr 26, 2023 at 12:50 AM TAMURA, Kent <tk...@chromium.org> wrote: > Contact emailstk...@chromium.org > > ExplainerNone > > Specificationhttps://dom.spec.whatwg.org/#locate-a-namespace > https://dom.spec.whatwg.org/#dom-xpathevaluatorbase-creatensresolver > > Summary > > Node.lookupNamespceURI() supports "xml" and "xmlns" prefixes by default. > The function returns fixed namespace strings for them. > Document.createNSResolver() and XPathEvaluator.createNSResolver() stops to > wrap the specified node to add "xml" prefix handling. They return the > specified node as is. Web developers can use an element as an > XPathNSResolver without wrapping it with createNSResolver(). > > > Blink componentBlink>DOM > <https://bugs.chromium.org/p/chromium/issues/list?q=component:Blink%3EDOM> > > TAG reviewNone. Two other browsers already shipped this. > > TAG review statusNot applicable > > Risks > > > Interoperability and Compatibility > > The risk is low. Firefox has had this behavior for a long time, and Safari > has adopted the behavior. This feature has an incompatible change on > createNSResolver(). If a disconnected non-element node is specified to > createNSResolver(), the resultant object has no "xml" prefix support any > longer. We have a UseCounter for such a case, and the counter value is 0.0. > https://chromestatus.com/metrics/feature/timeline/popularity/4475 > > > *Gecko*: Shipped/Shipping > > *WebKit*: Shipped/Shipping (https://commits.webkit.org/260848@main) > > *Web developers*: No signals > > *Other signals*: > > WebView application risks > > None > > > > Debuggability > > > > Will this feature be supported on all six Blink platforms (Windows, Mac, > Linux, Chrome OS, Android, and Android WebView)?Yes > > Is this feature fully tested by web-platform-tests > <https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md> > ?Yes > https://wpt.fyi/results/domxpath/xpathevaluatorbase-creatensresolver.html > https://wpt.fyi/results/dom/nodes/Node-lookupNamespaceURI.html > > Flag name > > Requires code in //chrome?False > > Tracking bughttps://bugs.chromium.org/p/chromium/issues/detail?id=1418215 > > Estimated milestones > Shipping on desktop 115 > Shipping on Android 115 > Shipping on WebView 115 > > Anticipated spec changes > > > > Link to entry on the Chrome Platform Status > https://chromestatus.com/feature/5143218561220608 > > Links to previous Intent discussions > > This intent message was generated by Chrome Platform Status > <https://chromestatus.com/>. > > -- > TAMURA Kent > Software Engineer, Google > > > -- > You received this message because you are subscribed to the Google Groups > "blink-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to blink-dev+unsubscr...@chromium.org. > To view this discussion on the web visit > https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAGH7WqGqrLAR9_dhH0XPiC0T57xBHuRcqTf7934Ap4vbNB5Ngw%40mail.gmail.com > <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAGH7WqGqrLAR9_dhH0XPiC0T57xBHuRcqTf7934Ap4vbNB5Ngw%40mail.gmail.com?utm_medium=email&utm_source=footer> > . > -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAKXHy%3Dfmb5s_ygcEc5qyPSHuwpg%3DQTqyqWvGhwUUN16dNGgBpw%40mail.gmail.com.