Awesome, great to see Mustaq. Thanks for the follow-up! On Wed, May 31, 2023 at 1:27 PM Mustaq Ahmed <mus...@chromium.org> wrote:
> > Thanks for improving interop here Mustaq! > > An update on the Interop front: most of the WPTs resolved > <https://wpt.fyi/results/pointerevents?label=master&label=experimental&aligned&q=uievents%2Fmouse%2Fattributes.html%20or%20pointerevents%2Fcapturing_boundary_event_handler_at_ua_shadowdom.html%20or%20pointerevents%2Fpointerevent_attributes_hoverable%20or%20pointerevents%2Fpointerevent_attributes_nohover_pointers.html> > by > this change are part of Interop 2023, and today's score on the dashboard > confirms a 10+ points improvement (from 71.5 to 82) to our Interop 2023 > Pointer/Mouse score: > > https://wpt.fyi/results/?label=experimental&label=master&product=chrome&product=firefox&product=safari&aligned&view=interop&q=label%3Ainterop-2023-events > > > On Wed, May 31, 2023 at 11:55 AM Daniel Bratell <bratel...@gmail.com> > wrote: > >> LGTM3 >> >> /Daniel >> On 2023-05-31 17:51, Chris Harrelson wrote: >> >> LGTM2 >> >> On Wed, May 31, 2023 at 8:26 AM Rick Byers <rby...@chromium.org> wrote: >> >>> Thanks for improving interop here Mustaq! >>> >>> It looks like >>> <https://chromium-review.googlesource.com/c/chromium/src/+/4536900> >>> this is behind an experimental RuntimeEnabledFeature >>> "NonComposedEnterLeaveEvents", which I assume you'll just set to 'stable' >>> once approved, right? That way if we do discover any breakage, we can flip >>> the kill-switch and do a full compat analysis / breaking change plan, >>> right? I tend to agree the compat risk is very low and we can think of this >>> just as a minor bug-fix. I don't see any easy way to measure the compat >>> risk quantifiably. >>> >>> LGTM1 >>> >>> >>> >>> On Wed, May 24, 2023 at 1:48 PM Mustaq Ahmed <mus...@chromium.org> >>> wrote: >>> >>>> Contact emails mus...@chromium.org >>>> >>>> Specification https://w3c.github.io/uievents/#event-type-mouseenter >>>> https://w3c.github.io/pointerevents/#attributes-and-default-actions >>>> >>>> Summary >>>> >>>> Make the event.composed property in mouseenter, mouseleave, >>>> pointerenter and pointerleave events "false" to be spec compliant and to >>>> fix interop gaps. Both the UI Events spec for Mouse Events and the Pointer >>>> Events spec define these events as non-composed. Both specs switched away >>>> from their original definitions few years ago: >>>> https://github.com/w3c/uievents/pull/210 >>>> https://github.com/w3c/pointerevents/pull/461 In addition to >>>> addressing the interop gap, this change also fixes an erroneous >>>> double/triple dispatch of these events to a shadow DOM host in Chromium >>>> when the shadow DOM also listens to the event ( >>>> https://crbug.com/1136584). >>>> >>>> >>>> Blink component Blink>Input >>>> <https://bugs.chromium.org/p/chromium/issues/list?q=component:Blink%3EInput> >>>> >>>> TAG review None >>>> >>>> TAG review status Not applicable >>>> >>>> Risks >>>> Interoperability >>>> >>>> This fixes a well-known interop gap. >>>> Compatibility >>>> >>>> The risk is negligible because Mozilla shipped the feature 5 years ago. >>>> Some prominent websites were updated back then, thanks to Mozilla's >>>> outreach (https://bugzilla.mozilla.org/show_bug.cgi?id=1478959). The >>>> compat risk is non-zero because Chromium has always dispatched these events >>>> as composed. >>>> >>>> >>>> *Gecko*: Shipped/Shipping ( >>>> https://bugzilla.mozilla.org/show_bug.cgi?id=1484371) >>>> >>>> *WebKit*: Shipped/Shipping ( >>>> https://bugs.chromium.org/p/chromium/issues/detail?id=1136584) >>>> >>>> *Web developers*: Positive (https://crbug.com/1136584 --- this is a >>>> 5-star dev reported bug). >>>> >>>> >>>> WebView application risks >>>> >>>> Does this intent deprecate or change behavior of existing APIs, such >>>> that it has potentially high risk for Android WebView-based applications? >>>> >>>> None >>>> >>>> >>>> Debuggability No special change needed here: DevTools console and >>>> event listener breakpoints support investigating all event attributes. >>>> >>>> Will this feature be supported on all six Blink platforms (Windows, >>>> Mac, Linux, Chrome OS, Android, and Android WebView)? Yes >>>> >>>> Is this feature fully tested by web-platform-tests >>>> <https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md> >>>> ? Yes >>>> >>>> Requires code in //chrome? >>>> False >>>> >>>> Tracking bug https://crbug.com/876994 >>>> >>>> Sample links https://codepen.io/mustaqahmed/pen/XWYZdYp >>>> >>>> Estimated milestones >>>> Shipping on desktop 116 >>>> Shipping on Android 116 >>>> Shipping on WebView 116 >>>> >>>> Anticipated spec changes >>>> >>>> Open questions about a feature may be a source of future web compat or >>>> interop issues. Please list open issues (e.g. links to known github issues >>>> in the project for the feature specification) whose resolution may >>>> introduce web compat/interop risk (e.g., changing to naming or structure of >>>> the API in a non-backward-compatible way). >>>> None >>>> >>>> Link to entry on the Chrome Platform Status >>>> https://chromestatus.com/feature/5073526551216128 >>>> >>>> This intent message was generated by Chrome Platform Status >>>> <https://chromestatus.com/>. >>>> -- >>>> You received this message because you are subscribed to the Google >>>> Groups "blink-dev" group. >>>> To unsubscribe from this group and stop receiving emails from it, send >>>> an email to blink-dev+unsubscr...@chromium.org. >>>> To view this discussion on the web visit >>>> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAB0cuO73bus-BhZU1sxYhRQTAiwh5whzTwP4%2BsJcgUciAtxG7Q%40mail.gmail.com >>>> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAB0cuO73bus-BhZU1sxYhRQTAiwh5whzTwP4%2BsJcgUciAtxG7Q%40mail.gmail.com?utm_medium=email&utm_source=footer> >>>> . >>>> >>> -- >>> You received this message because you are subscribed to the Google >>> Groups "blink-dev" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to blink-dev+unsubscr...@chromium.org. >>> To view this discussion on the web visit >>> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAFUtAY8_2G%3DCAr%2BkDcz0ttx_eCsYxo-qbH%2BRUabsd-sinF2hZg%40mail.gmail.com >>> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAFUtAY8_2G%3DCAr%2BkDcz0ttx_eCsYxo-qbH%2BRUabsd-sinF2hZg%40mail.gmail.com?utm_medium=email&utm_source=footer> >>> . >>> >> -- >> You received this message because you are subscribed to the Google Groups >> "blink-dev" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to blink-dev+unsubscr...@chromium.org. >> To view this discussion on the web visit >> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAOMQ%2Bw9QNNGvW9aCG1bV1eFTiAyd05fFXtSVgwYo8AEgTre-Ug%40mail.gmail.com >> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAOMQ%2Bw9QNNGvW9aCG1bV1eFTiAyd05fFXtSVgwYo8AEgTre-Ug%40mail.gmail.com?utm_medium=email&utm_source=footer> >> . >> >> -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAFUtAY-dBFDxv4g8a08U1pMM74Rxc_2aLn%2BMpNCy5cYjVH%3DCJA%40mail.gmail.com.
