It looks like it needs review, and I'm one of the assigned reviewers... Sorry that I missed this. I'll take a look.
On Thu, Jun 8, 2023 at 9:27 PM Mike Taylor <[email protected]> wrote: > Side note: is there anything blocking > https://github.com/WICG/trust-token-api/pull/257 from landing? > On 6/8/23 9:28 AM, Steven Valdez wrote: > > As an update, we're currently shipping to 1% to collect metrics to ensure > this feature does not regress core web vitals <https://web.dev/vitals/>, > before ramping up the rollout to 100% in the coming weeks. > > On Wed, May 17, 2023 at 2:02 PM Rick Byers <[email protected]> wrote: > >> LGTM4 FWIW. Thank you for working through these issues Steven! >> >> Rick >> >> On Wed, May 17, 2023 at 8:52 AM Yoav Weiss <[email protected]> >> wrote: >> >>> LGTM3 >>> >>> On Tuesday, May 16, 2023 at 6:04:48 PM UTC+2 [email protected] wrote: >>> >>>> We've filed crbug.com/1445984 to keep track of that and will update >>>> the developer articles to point more explicitly to the failure >>>> condition/requirements there. >>>> >>>> -Steven >>>> >>>> On Tue, May 16, 2023 at 5:30 AM Mike West <[email protected]> wrote: >>>> >>>>> LGTM2, with the understanding that cleaning up the developer-facing >>>>> story around this work is important. I think the unenrolled case probably >>>>> falls into step ~8 of >>>>> https://wicg.github.io/trust-token-api/#issue-request, in which case >>>>> I think the web-facing behavior is clearly-enough specified. I'd like >>>>> y'all >>>>> to make sure that that failure mode is debuggable, which I'm happy for you >>>>> to wrap into a larger story around enrollment in devtools if that's what >>>>> you land on when working with that team. >>>>> >>>>> Thanks! >>>>> >>>>> -mike >>>>> >>>>> >>>>> On Mon, May 15, 2023 at 5:06 PM Steven Valdez <[email protected]> >>>>> wrote: >>>>> >>>>>> Thanks, we'll work on fixing those two issues. >>>>>> >>>>>> I'm not sure what the general flow for enrollment in DevTools will >>>>>> look like, but if there's a general flow to detect when enrollment is >>>>>> missing for other APIs that check at runtime, we can try to integrate >>>>>> with >>>>>> that when PST calls are made with an unregistered issuer. >>>>>> >>>>>> On Fri, May 12, 2023 at 7:05 PM Mike Taylor <[email protected]> >>>>>> wrote: >>>>>> >>>>>>> LGTM1 % resolving the following spec issues: >>>>>>> >>>>>>> https://github.com/WICG/trust-token-api/issues/232 >>>>>>> >>>>>>> https://github.com/WICG/trust-token-api/issues/230 >>>>>>> >>>>>>> On Wed, May 10, 2023 at 5:52 AM Mike West <[email protected]> >>>>>>> wrote: >>>>>>> >>>>>>>> Will devtools help guide developers towards enrollment? >>>>>>>> >>>>>>> Also I think Mike's question on devtools support is worth answering. >>>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> >>>>>> Steven Valdez | Chrome Privacy Sandbox | [email protected] | >>>>>> Cambridge, >>>>>> MA >>>>>> >>>>> >>>> >>>> -- >>>> >>>> Steven Valdez | Chrome Privacy Sandbox | [email protected] | >>>> Cambridge, >>>> MA >>>> >>> -- >>> You received this message because you are subscribed to the Google >>> Groups "blink-dev" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to [email protected]. >>> To view this discussion on the web visit >>> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/325d36cb-52a4-4c2e-8124-09036014cbcbn%40chromium.org >>> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/325d36cb-52a4-4c2e-8124-09036014cbcbn%40chromium.org?utm_medium=email&utm_source=footer> >>> . >>> >> -- > You received this message because you are subscribed to the Google Groups > "blink-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To view this discussion on the web visit > https://groups.google.com/a/chromium.org/d/msgid/blink-dev/db001cd5-8d9a-0e3c-83fa-decf3a17d592%40chromium.org > <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/db001cd5-8d9a-0e3c-83fa-decf3a17d592%40chromium.org?utm_medium=email&utm_source=footer> > . > -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAD_OO4iGC4NAn9q3ZF7HN%3DniSC9Np815Qcku0VnANwXAfAHx3Q%40mail.gmail.com.
