FYI ---------- Forwarded message --------- From: Weizhong Xia <[email protected]> Date: Fri, Jun 23, 2023 at 1:38 PM Subject: An update to the Virtual Test Suite expiration policy To: Elly Fong-Jones <[email protected]>, Mason Freed <[email protected]> Cc: Andreas Haas <[email protected]>, Reilly Grant <[email protected]>, chromium-dev-internal <[email protected]>
Thanks to everyone who shared feedback/suggestions. We have made a change on how expiration date is handled in this CL <https://chromium-review.googlesource.com/c/chromium/src/+/4611810>. In summary we will NOT automatically stop running virtual test suites on expiration. Instead a P1 crbug will be filed against the owner when VTS expires. A CL to remove the VTS will be created for review 30 days later if the expiration date is not extended. We are working on finding the owners for the VTSs. Before we find owners for a VTS, it will continue to run as usual. Thanks, Weizhong On Wed, May 31, 2023 at 1:52 PM Elly Fong-Jones <[email protected]> wrote: > The approach the flag metadata file uses: > https://source.chromium.org/chromium/chromium/src/+/main:chrome/browser/flag-metadata.json;l=12?q=flag-metadata.jso&ss=chromium > > has been serving us well so far :) > > -- elly > > On Wed, May 31, 2023 at 1:48 PM Andreas Haas <[email protected]> wrote: > >> I would prefer an owner's email address, ideally multiple email addresses >> should be possible so that also the team's mailing list can be added. >> >> Cheers, Andreas >> >> On Wed, May 31, 2023 at 10:44 PM Weizhong Xia <[email protected]> >> wrote: >> >>> Yes! >>> >>> Between an owner's email address and a crbug component, which one do you >>> prefer? I am leaning toward letting the config file accept an optional >>> component field, and we will automatically file a crbug when a VTS is about >>> to expire. When no component is given, the crbug will be filed to an >>> umbrella component, e.g. Test. >>> >>> thanks, Weizhong >>> >>> On Wed, May 31, 2023 at 10:54 AM Reilly Grant <[email protected]> >>> wrote: >>> >>>> For flag and histogram expiration we have owners assigned for each and >>>> will automatically email them when expiration is getting close. I notice >>>> that there are no owners listed for virtual test suites. Can we add this? >>>> [image: Google Logo] >>>> Reilly Grant >>>> Software Engineer >>>> [email protected] >>>> Google Chrome >>>> >>>> >>>> On Wed, May 31, 2023 at 9:47 AM Weizhong Xia <[email protected]> >>>> wrote: >>>> >>>>> For those who don't know already, the virtual test suites config file >>>>> is located at //third_party/blink/web_tests/VirtualTestSuites. >>>>> >>>>> On Tue, May 30, 2023 at 10:23 AM Weizhong Xia <[email protected]> >>>>> wrote: >>>>> >>>>>> Hi Folks >>>>>> >>>>>> This is a reminder as we are approaching July 1st, 2023, the initial >>>>>> expiration date I set for all the virtual test suites. I did a search >>>>>> just >>>>>> now. Most VTS would still expire at that date (161 out of 194). >>>>>> >>>>>> Can we review this to make sure we do not lose coverage suddenly? >>>>>> >>>>>> thanks, Weizhong >>>>>> >>>>>> On Tue, Nov 22, 2022 at 12:07 PM Weizhong Xia <[email protected]> >>>>>> wrote: >>>>>> >>>>>>> Hi Folks >>>>>>> >>>>>>> TL;DR: We now support expiration dates for virtual test suites. All >>>>>>> virtual test suites now have an initial expiration date of July 1st, >>>>>>> 2023. >>>>>>> If you own any virtual test suites, please review this value, and update >>>>>>> that to an appropriate date. >>>>>>> >>>>>>> In the past we have seen cases where virtual test suites are left >>>>>>> running when they should be deleted. By adding expiration dates, >>>>>>> developers >>>>>>> now have a chance to review the test suites based on latest status. The >>>>>>> expiration date can be set to 'never' if necessary. An explanation is >>>>>>> required for such a case. >>>>>>> >>>>>>> I will resent this a couple of times in case some people should miss >>>>>>> this due to the holiday season. >>>>>>> >>>>>>> And happy holidays! >>>>>>> >>>>>>> thanks, Weizhong >>>>>>> >>>>>>> -- >>>>> You received this message because you are subscribed to the Google >>>>> Groups "chromium-dev-internal" group. >>>>> To unsubscribe from this group and stop receiving emails from it, send >>>>> an email to [email protected]. >>>>> To view this discussion on the web visit >>>>> https://groups.google.com/a/google.com/d/msgid/chromium-dev-internal/CADXrSiokWve4vRXrKEkLNVHA3EvbDBT4QO1Rx3xaiY4Pib9mEA%40mail.gmail.com >>>>> <https://groups.google.com/a/google.com/d/msgid/chromium-dev-internal/CADXrSiokWve4vRXrKEkLNVHA3EvbDBT4QO1Rx3xaiY4Pib9mEA%40mail.gmail.com?utm_medium=email&utm_source=footer> >>>>> . >>>>> >>>> -- >>> You received this message because you are subscribed to the Google >>> Groups "chromium-dev-internal" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to [email protected]. >>> To view this discussion on the web visit >>> https://groups.google.com/a/google.com/d/msgid/chromium-dev-internal/CADXrSipQKTXD_g_FxaRcjcOjGgNXd5DSJfp-OiGtm_eVv427tg%40mail.gmail.com >>> <https://groups.google.com/a/google.com/d/msgid/chromium-dev-internal/CADXrSipQKTXD_g_FxaRcjcOjGgNXd5DSJfp-OiGtm_eVv427tg%40mail.gmail.com?utm_medium=email&utm_source=footer> >>> . >>> >>> -- >>> >>> >> >> -- >> >> Andreas Haas >> >> Software Engineer >> >> [email protected] >> >> >> Google Germany GmbH >> >> Erika-Mann-Straße 33 >> >> 80636 München >> >> >> Geschäftsführer: Paul Manicle, Liana Sebastian >> >> Registergericht und -nummer: Hamburg, HRB 86891 >> >> Sitz der Gesellschaft: Hamburg >> >> >> Diese E-Mail ist vertraulich. Falls sie diese fälschlicherweise erhalten >> haben sollten, leiten Sie diese bitte nicht an jemand anderes weiter, >> löschen Sie alle Kopien und Anhänge davon und lassen Sie mich bitte wissen, >> dass die E-Mail an die falsche Person gesendet wurde. >> >> >> >> This e-mail is confidential. If you received this communication by >> mistake, please don't forward it to anyone else, please erase all copies >> and attachments, and please let me know that it has gone to the wrong >> person. >> >> -- >> You received this message because you are subscribed to the Google Groups >> "chromium-dev-internal" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected]. >> To view this discussion on the web visit >> https://groups.google.com/a/google.com/d/msgid/chromium-dev-internal/CAELSTvfnihTQGgXxKhveGO9zxkbmh%3DJi3TdygLi_Uq1B5yun8g%40mail.gmail.com >> <https://groups.google.com/a/google.com/d/msgid/chromium-dev-internal/CAELSTvfnihTQGgXxKhveGO9zxkbmh%3DJi3TdygLi_Uq1B5yun8g%40mail.gmail.com?utm_medium=email&utm_source=footer> >> . >> > -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CADXrSioygV84qx%2BYVKR7GhhGCdD-vV4k-4mv0Aebdy8OnPJpvw%40mail.gmail.com.
