LGTM3 On Mon, Jun 26, 2023 at 8:56 AM Yoav Weiss <[email protected]> wrote:
> LGTM2 > > On Mon, Jun 26, 2023 at 5:15 PM Rick Byers <[email protected]> wrote: > >> LGTM1 >> >> On Wed, Jun 21, 2023 at 9:10 AM 'Philipp Hancke' via blink-dev < >> [email protected]> wrote: >> >>> Contact emails >>> >>> [email protected], [email protected], [email protected] (sticking to my >>> already subscribed email for sending) >>> >>> Explainer >>> >>> >>> https://docs.google.com/document/d/1y1hTsMeav5ijPvoqu1R6U4YC564i1QzgkMeIqWhgiis/edit# >>> >>> (slightly outdated but still conveys the general idea) >>> >>> Spec >>> >>> https://w3c.github.io/webrtc-extensions/#rtp-header-extension-control >>> >>> There’s also an IETF change pending >>> <https://github.com/rtcweb-wg/jsep/pull/1033> for inclusion into >>> RFC8829-bis >>> <https://datatracker.ietf.org/doc/draft-uberti-rtcweb-rfc8829bis/> that >>> allows us to change some of the language of the W3C spec, but this will not >>> change any behavior and is only editorial as far as the implementation is >>> concerned. It also updates the IETF spec to match the current behavior >>> of browsers >>> <https://github.com/w3c/webrtc-extensions/issues/134#issuecomment-1517504823> >>> . >>> >>> TAG review >>> >>> N/A; minor extension to WebRTC >>> >>> Blink component >>> >>> Blink>WebRTC >>> <https://bugs.chromium.org/p/chromium/issues/list?q=component:Blink%3EWebRTC> >>> >>> Summary >>> >>> The RTP header extensions API adds a control surface to the WebRTC >>> RTCRtpTransceiver API which allows developers to control which RTP header >>> extensions are being negotiated by WebRTC. >>> >>> This is something that is currently only possible via a non-standard API >>> where the Session Description Protocol string is manually modified to tell >>> WebRTC which header extensions to use. By providing apps with a >>> spec-compliant alternative we’ll be that much closer to deprecating the >>> non-standard code path. >>> >>> Link to “Intent to Prototype” blink-dev discussion >>> >>> >>> https://groups.google.com/a/chromium.org/g/blink-dev/c/65YdUi02yZk/m/dXL1a8PYBQAJ >>> >>> Is this feature supported on all six Blink platforms (Windows, Mac, >>> Linux, Chrome OS, Android, and Android WebView)? >>> >>> Yes >>> >>> Debuggability >>> >>> The resulting RTP header extensions are visible in >>> chrome://webrtc-internals by looking at the SDP meaning any app using this >>> API can be inspected via this dev tool. The API also conveys which header >>> extensions were negotiated via a getter for JS level debugging. >>> >>> Risks >>> >>> Interoperability and Compatibility >>> >>> Firefox: positive >>> https://github.com/mozilla/standards-positions/issues/713 with great >>> feedback that improved the specification >>> >>> Safari: positive >>> https://github.com/WebKit/standards-positions/issues/100 >>> >>> Web / Framework developers: Positive (Teams and Google Meet) >>> >>> Is this feature fully tested by web-platform-tests >>> <https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md>? >>> Link to test suite results from wpt.fyi. >>> >>> Yes: >>> https://wpt.fyi/results/webrtc-extensions/RTCRtpTransceiver-headerExtensionControl.html >>> >>> Entry on the feature dashboard <http://www.chromestatus.com/> >>> >>> https://chromestatus.com/feature/5680189201711104 >>> >>> -- >>> You received this message because you are subscribed to the Google >>> Groups "blink-dev" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to [email protected]. >>> To view this discussion on the web visit >>> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CADxkKi%2BVVgjhZg%2BG1sbj%2BzUtaMzooeo9RRQPONx0%2B-G1ROA%2BgQ%40mail.gmail.com >>> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CADxkKi%2BVVgjhZg%2BG1sbj%2BzUtaMzooeo9RRQPONx0%2B-G1ROA%2BgQ%40mail.gmail.com?utm_medium=email&utm_source=footer> >>> . >>> >> -- >> You received this message because you are subscribed to the Google Groups >> "blink-dev" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected]. >> To view this discussion on the web visit >> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAFUtAY8ZYCxw1gvKvV9uZ-6s4K%3Dtzxm0z9detCCYBbrrM10OEQ%40mail.gmail.com >> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAFUtAY8ZYCxw1gvKvV9uZ-6s4K%3Dtzxm0z9detCCYBbrrM10OEQ%40mail.gmail.com?utm_medium=email&utm_source=footer> >> . >> > -- > You received this message because you are subscribed to the Google Groups > "blink-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To view this discussion on the web visit > https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAL5BFfUrvK%3D%3DRGuSSfoEWnB0sto4ZmnDksitVsU6STPqrDRetQ%40mail.gmail.com > <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAL5BFfUrvK%3D%3DRGuSSfoEWnB0sto4ZmnDksitVsU6STPqrDRetQ%40mail.gmail.com?utm_medium=email&utm_source=footer> > . > -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAOMQ%2Bw92TyuZNOQSmF0ZzAkDWaM2KSE%3DojPvAL3v9QS-%3D0%3DS4w%40mail.gmail.com.
