LGTM3 On Fri, Jun 30, 2023, 21:47 Stephen Chenney <schen...@chromium.org> wrote:
> Thanks Mike for looking up github usage. It does indeed do nothing and the > github refs are all -webkit-highlight: none or initial, which I have to > assume was also none. We checked many of the http-archive links and they > were all the one a11y library usage, all value none. > > Cheers, > Stephen. > > On Fri, Jun 30, 2023 at 3:36 PM Mike Taylor <miketa...@chromium.org> > wrote: > >> >> https://github.com/search?type=code&q=-webkit-highlight+language%3ACSS&l=CSS >> shows this has been used elsewhere (but I guess has just been useless in >> clank?). >> >> That said, LGTM2. >> >> On 7/1/23 4:33 AM, Rick Byers wrote: >> >> Removing a prefixed API with no behavior should be trivial, thanks for >> the cleanup Stephen :-) >> >> However, the UseCounter is surprisingly high with lots of hits in HA: >> https://chromestatus.com/metrics/css/timeline/popularity/251. Just >> confirming that you looked at a sample of those hits and found they were >> all using this 3P library? >> >> LGTM1 >> >> >> >> On Thu, Jun 29, 2023 at 1:30 PM Stephen Chenney <schen...@chromium.org> >> wrote: >> >>> Contact emails schen...@chromium.org, spectran...@igalia.com >>> >>> Explainer None >>> >>> Specification None >>> >>> Summary >>> >>> The CSS property -webkit-highlight is intended to highlight text, but >>> was never standardized. It has no visible effect in chromium (it is parsed >>> but never used in rendering content). The property was removed from WebKit >>> in 2014 (https://bugs.webkit.org/show_bug.cgi?id=128456), has been >>> marked as deprecated on MDN, and has been replaced recently with the CSS >>> Highlight Pseudo spec ( >>> https://www.w3.org/TR/css-pseudo-4/#highlight-pseudos). The property >>> seems to be used in a single third-party library ( >>> https://www.audioeye.com/) where it is always set to the value "none". >>> >>> >>> Blink component Blink>CSS >>> <https://bugs.chromium.org/p/chromium/issues/list?q=component:Blink%3ECSS> >>> >>> TAG review None >>> >>> TAG review status Not applicable >>> >>> Risks >>> >>> >>> Interoperability and Compatibility >>> >>> Improving interop and compat. No other browser supports this feature and >>> the feature has no effect. >>> >>> >>> *Gecko*: N/A Never shipped. >>> >>> *WebKit*: Removed in 2014. ( >>> https://bugs.webkit.org/show_bug.cgi?id=128456) >>> >>> *Web developers*: No signals. The property is essentially >>> undiscoverable. >>> >>> *Other signals*: >>> >>> WebView application risks >>> >>> Does this intent deprecate or change behavior of existing APIs, such >>> that it has potentially high risk for Android WebView-based applications? >>> >>> None >>> >>> >>> Debuggability >>> >>> Will this feature be supported on all six Blink platforms (Windows, Mac, >>> Linux, Chrome OS, Android, and Android WebView)? No >>> >>> Is this feature fully tested by web-platform-tests >>> <https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md> >>> ? No >>> >>> Flag name on chrome://flags >>> >>> Finch feature name >>> >>> Non-finch justification The feature does nothing, so the behavior of >>> web content cannot change. There are no crash concerns with the code being >>> removed. >>> >>> Requires code in //chrome? False >>> >>> Tracking bug >>> https://bugs.chromium.org/p/chromium/issues/detail?id=1086089 >>> >>> Estimated milestones >>> Shipping on desktop 117 >>> Shipping on Android 117 >>> Shipping on WebView 117 >>> >>> Anticipated spec changes >>> >>> Open questions about a feature may be a source of future web compat or >>> interop issues. Please list open issues (e.g. links to known github issues >>> in the project for the feature specification) whose resolution may >>> introduce web compat/interop risk (e.g., changing to naming or structure of >>> the API in a non-backward-compatible way). >>> None >>> >>> Link to entry on the Chrome Platform Status >>> https://chromestatus.com/feature/5171295490146304 >>> >>> Links to previous Intent discussions >>> >>> This intent message was generated by Chrome Platform Status >>> <https://chromestatus.com/>. >>> -- >>> You received this message because you are subscribed to the Google >>> Groups "blink-dev" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to blink-dev+unsubscr...@chromium.org. >>> To view this discussion on the web visit >>> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAGsbWzRjoatsXASAmVugMynmGDubKHaEVpD2_dQOxGn0rK71zA%40mail.gmail.com >>> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAGsbWzRjoatsXASAmVugMynmGDubKHaEVpD2_dQOxGn0rK71zA%40mail.gmail.com?utm_medium=email&utm_source=footer> >>> . >>> >> -- >> You received this message because you are subscribed to the Google Groups >> "blink-dev" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to blink-dev+unsubscr...@chromium.org. >> To view this discussion on the web visit >> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAFUtAY82FD8a7WxksRoC3U8zYm5U2n2G-AVMDBO_QP3wsaAw%3Dg%40mail.gmail.com >> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAFUtAY82FD8a7WxksRoC3U8zYm5U2n2G-AVMDBO_QP3wsaAw%3Dg%40mail.gmail.com?utm_medium=email&utm_source=footer> >> . >> >> -- > You received this message because you are subscribed to the Google Groups > "blink-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to blink-dev+unsubscr...@chromium.org. > To view this discussion on the web visit > https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAGsbWzSvEURKPmGepBkzCTmx-Wgc5UW7-fJviXcxqKtgVZQ0NQ%40mail.gmail.com > <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAGsbWzSvEURKPmGepBkzCTmx-Wgc5UW7-fJviXcxqKtgVZQ0NQ%40mail.gmail.com?utm_medium=email&utm_source=footer> > . > -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAL5BFfWwTYbQ2f8cAkpTrVXuYorT5r3FtioX0TFZn7yD_jB5jw%40mail.gmail.com.
