LGTM3 On Tue, Aug 22, 2023, 7:32 AM Mike Taylor <miketa...@chromium.org> wrote:
> LGTM2 > On 8/22/23 10:29 AM, Yoav Weiss wrote: > > LGTM1 > > Thanks for catching us up here! :) > > > On Thu, Aug 17, 2023 at 5:31 AM Vladimir Levin <vmp...@chromium.org> > wrote: > >> >> >> On Wed, Aug 16, 2023 at 4:37 PM Joey Arhar <jar...@chromium.org> wrote: >> >>> Contact emails jar...@chromium.org >>> >>> Explainer None >>> >>> Specification >>> https://html.spec.whatwg.org/multipage/grouping-content.html#the-search-element >>> >>> Summary >>> >>> The <search> element applies a "search" role for accessibility. It is >>> basically the same as <div role=search>. From the HTML spec: The search >>> element represents a part of a document or application that contains a set >>> of form controls or other content related to performing a search or >>> filtering operation. This could be a search of the web site or application; >>> a way of searching or filtering search results on the current web page; or >>> a global or Internet-wide search function. >>> >>> >>> Blink component Blink>HTML >>> <https://bugs.chromium.org/p/chromium/issues/list?q=component:Blink%3EHTML> >>> >>> TAG review None >>> >>> TAG review status Not applicable >>> >> >> FYI, there has already been a (satisfied with concerns) TAG review for >> this: https://github.com/w3ctag/design-reviews/issues/714 >> >> >>> >>> Risks >>> >>> >>> Interoperability and Compatibility >>> >>> There is minimal compat risk for this. Even if a website is erroneously >>> already using <search> tags, there likely won't be any difference in >>> behavior. >>> >>> >>> *Gecko*: Shipped/Shipping ( >>> https://bugzilla.mozilla.org/show_bug.cgi?id=1824121) >>> >>> *WebKit*: Shipped/Shipping (https://github.com/WebKit/WebKit/pull/13887) >>> >>> *Web developers*: No signals >>> >>> *Other signals*: >>> >>> Ergonomics >>> >>> There are no other platform APIs this feature will be used in tandem >>> with. The default usage of this API will not make it hard for chrome to >>> maintain good performance. >>> >>> >>> Activation >>> >>> It will not be challenging for developers to take advantage of this >>> feature immediately. I don't think that polyfills/documentation/outreach is >>> needed for this feature. >>> >>> >>> Security >>> >>> This feature does not have any security or privacy implications. >>> >>> >>> WebView application risks >>> >>> Does this intent deprecate or change behavior of existing APIs, such >>> that it has potentially high risk for Android WebView-based applications? >>> >>> This has no risk for WebView. >>> >>> >>> Debuggability >>> >>> The DevTools accessibility panel will show the new accessibility role >>> associated with search elements. >>> >>> >>> Will this feature be supported on all six Blink platforms (Windows, Mac, >>> Linux, Chrome OS, Android, and Android WebView)? Yes >>> >>> Is this feature fully tested by web-platform-tests >>> <https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md> >>> ? Yes >>> >>> Flag name on chrome://flags HTMLSearchElement >>> >>> Finch feature name HTMLSearchElement >>> >>> Requires code in //chrome? False >>> >>> Tracking bug >>> https://bugs.chromium.org/p/chromium/issues/detail?id=1294294 >>> >>> Availability expectation This feature has already been implemented in >>> firefox and webkit, so it will be available immediately. >>> >>> Adoption expectation This feature has already been implemented in >>> firefox and webkit, so it will be available immediately. >>> >>> Adoption plan No actions are needed because this feature has already >>> shipped in firefox and safari. >>> >>> Estimated milestones >>> Shipping on desktop 118 >>> DevTrial on desktop 118 >>> Shipping on Android 118 >>> DevTrial on Android 118 >>> Shipping on WebView 118 >>> >>> Anticipated spec changes >>> >>> Open questions about a feature may be a source of future web compat or >>> interop issues. Please list open issues (e.g. links to known github issues >>> in the project for the feature specification) whose resolution may >>> introduce web compat/interop risk (e.g., changing to naming or structure of >>> the API in a non-backward-compatible way). >>> There are no open spec issues for the search element. >>> >>> Link to entry on the Chrome Platform Status >>> https://chromestatus.com/feature/5126108151808000 >>> >>> This intent message was generated by Chrome Platform Status >>> <https://chromestatus.com/>. >>> -- >>> You received this message because you are subscribed to the Google >>> Groups "blink-dev" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to blink-dev+unsubscr...@chromium.org. >>> To view this discussion on the web visit >>> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAK6btwJnqcqZ1XXzmb1Fb_%3Db1eZJDGMDig9M3OF8ZXPxaK92AA%40mail.gmail.com >>> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAK6btwJnqcqZ1XXzmb1Fb_%3Db1eZJDGMDig9M3OF8ZXPxaK92AA%40mail.gmail.com?utm_medium=email&utm_source=footer> >>> . >>> >> -- >> You received this message because you are subscribed to the Google Groups >> "blink-dev" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to blink-dev+unsubscr...@chromium.org. >> To view this discussion on the web visit >> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CADsXd2P9pddg2DpC4Ep5C83x7zP6D1pwEeDpLNTfutEg1naKtA%40mail.gmail.com >> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CADsXd2P9pddg2DpC4Ep5C83x7zP6D1pwEeDpLNTfutEg1naKtA%40mail.gmail.com?utm_medium=email&utm_source=footer> >> . >> > -- > You received this message because you are subscribed to the Google Groups > "blink-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to blink-dev+unsubscr...@chromium.org. > To view this discussion on the web visit > https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAL5BFfVm0kCgnzati0iEFyf17YZ4kRWM-N1exVJRTmiE5MKrGg%40mail.gmail.com > <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAL5BFfVm0kCgnzati0iEFyf17YZ4kRWM-N1exVJRTmiE5MKrGg%40mail.gmail.com?utm_medium=email&utm_source=footer> > . > > -- > You received this message because you are subscribed to the Google Groups > "blink-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to blink-dev+unsubscr...@chromium.org. > To view this discussion on the web visit > https://groups.google.com/a/chromium.org/d/msgid/blink-dev/08295ad1-b2a1-41d6-8a05-4a3382134df4%40chromium.org > <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/08295ad1-b2a1-41d6-8a05-4a3382134df4%40chromium.org?utm_medium=email&utm_source=footer> > . > -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAOMQ%2Bw_fE4j0k5Ha%3DQ0jS%2BYKsWLfhC3CYa_EBQpJHr9rQjTMQw%40mail.gmail.com.
