LGTM3 On Wed, Sep 6, 2023 at 9:51 AM Mike Taylor <miketa...@chromium.org> wrote:
> LGTM2 > On 9/6/23 11:01 AM, Yoav Weiss wrote: > > LGTM1 to ship, while keeping an eye out for TAG feedback, in case it'd be > surprising and not match past feedback in the same vein. > > On Wed, Sep 6, 2023 at 5:41 PM 'François Beaufort' via blink-dev < > blink-dev@chromium.org> wrote: > >> >> >> On Fri, Sep 1, 2023 at 3:09 PM François Beaufort <fbeauf...@google.com> >> wrote: >> >>> Contact emails >>> >>> fbeauf...@google.com >>> >>> elada...@google.com >>> >>> Explainer >>> >>> >>> https://github.com/eladalon1983/screen-share-explainers/blob/main/monitorTypeSurfaces_Explainer.md >>> >>> Specification >>> >>> >>> https://w3c.github.io/mediacapture-screen-share/#dom-displaymediastreamoptions-monitortypesurfaces >>> >>> Summary >>> >>> When getDisplayMedia() is called, the browser offers the user a choice >>> of display surfaces: tabs, windows, or monitors. Using the >>> monitorTypeSurfaces option, the web application may now hint to the >>> browser if it prefers to include display surfaces whose type is monitor >>> among the choices offered to the user. >>> >>> Blink component >>> >>> Blink>GetDisplayMedia >>> <https://bugs.chromium.org/p/chromium/issues/list?q=component:Blink%3EGetDisplayMedia> >>> >>> TAG review >>> >>> https://github.com/w3ctag/design-reviews/issues/892 >>> >>> TAG review status >>> >>> Pending >>> >> >> FYI this feature is a simple addition of a single flag to an existing >> dictionary, following an established pattern that’s also used by a few >> other keys of the same dictionary (selfBrowserSurface, systemAudio, >> surfaceSwitching). well-known patterns. >> We already filed a TAG review for similar options at >> https://github.com/w3ctag/design-reviews/issues/744 which was marked as >> satisfied. >> >> >>> Risks >>> Interoperability and Compatibility >>> >>> None >>> >>> Gecko: No signal ( >>> https://github.com/mozilla/standards-positions/issues/876) Jan-Ivar >>> Bruaroey from Mozilla has reviewed and approved >>> https://github.com/w3c/mediacapture-screen-share/pull/274. >>> >>> WebKit: No signal ( >>> https://github.com/WebKit/standards-positions/issues/248) Youenn Fablet >>> from Apple has participated in >>> https://www.w3.org/2023/06/27-webrtc-minutes.html#t04 and >>> https://github.com/w3c/mediacapture-screen-share/issues/261#issuecomment-1693090386 >>> . >>> >>> Web developers: Positive Cisco folks have expressed interest in this >>> feature. >>> https://github.com/screen-share/meetings/blob/main/minutes/2023-03-21.md?plain=1#L161 >>> >>> Other signals: >>> >>> WebView application risks >>> >>> Does this intent deprecate or change behavior of existing APIs, such >>> that it has potentially high risk for Android WebView-based applications? >>> >>> None >>> >>> >>> Debuggability >>> >>> None >>> >>> Will this feature be supported on all six Blink platforms (Windows, Mac, >>> Linux, Chrome OS, Android, and Android WebView)? >>> >>> Supported on all platforms that support getDisplayMedia. Namely, all >>> desktop platforms. >>> >>> Is this feature fully tested by web-platform-tests >>> <https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md> >>> ? >>> >>> Yes. See >>> https://wpt.fyi/results/screen-capture/getdisplaymedia.https.html >>> >>> Flag name on chrome://flags >>> >>> None >>> >>> Finch feature name >>> >>> MonitorTypeSurfaces >>> >>> Requires code in //chrome? >>> >>> Yes. In chrome/browser/media/webrtc/display_media_access_handler.cc >>> >>> Tracking bug >>> >>> https://bugs.chromium.org/p/chromium/issues/detail?id=1477706 >>> >>> Estimated milestones >>> >>> Shipping on desktop >>> >>> 119 >>> >>> Anticipated spec changes >>> >>> Open questions about a feature may be a source of future web compat or >>> interop issues. Please list open issues (e.g. links to known github issues >>> in the project for the feature specification) whose resolution may >>> introduce web compat/interop risk (e.g., changing to naming or structure of >>> the API in a non-backward-compatible way). >>> >>> None >>> >>> Link to entry on the Chrome Platform Status >>> >>> https://chromestatus.com/feature/5558622137876480 >>> >>> This intent message was generated by Chrome Platform Status >>> <https://chromestatus.com/>. >>> >>> -- >> You received this message because you are subscribed to the Google Groups >> "blink-dev" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to blink-dev+unsubscr...@chromium.org. >> To view this discussion on the web visit >> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAPpwU5LwRya212ep0m1_YJJbfMQPJ4ZqxuuM3FFLJzzKgzuoZQ%40mail.gmail.com >> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAPpwU5LwRya212ep0m1_YJJbfMQPJ4ZqxuuM3FFLJzzKgzuoZQ%40mail.gmail.com?utm_medium=email&utm_source=footer> >> . >> > -- > You received this message because you are subscribed to the Google Groups > "blink-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to blink-dev+unsubscr...@chromium.org. > To view this discussion on the web visit > https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAL5BFfW1Rs-Cn0PyOq0u6NtTLBLU1Rtn_PwsjQeKVcFX3Dj_PQ%40mail.gmail.com > <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAL5BFfW1Rs-Cn0PyOq0u6NtTLBLU1Rtn_PwsjQeKVcFX3Dj_PQ%40mail.gmail.com?utm_medium=email&utm_source=footer> > . > > -- > You received this message because you are subscribed to the Google Groups > "blink-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to blink-dev+unsubscr...@chromium.org. > To view this discussion on the web visit > https://groups.google.com/a/chromium.org/d/msgid/blink-dev/b93428c3-8117-483e-8e5e-1fc00dcf8729%40chromium.org > <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/b93428c3-8117-483e-8e5e-1fc00dcf8729%40chromium.org?utm_medium=email&utm_source=footer> > . > -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAOMQ%2Bw9eKwfnZmUAESwZsRkQzXLqxBYLicKoZrsQfhxJcsBBxw%40mail.gmail.com.