LGTM3 On Thursday, October 5, 2023 at 1:36:25 PM UTC-7 Scott Jehl wrote:
> Thanks!! > > On Thursday, 5 October 2023 at 16:14:19 UTC-4 Dale Curtis wrote: > >> Thanks! >> > >> On Thu, Oct 5, 2023 at 12:53 PM Yoav Weiss <yoav...@chromium.org> wrote: >> > LGTM1 >>> >>> Thanks for correcting this historical mistake! >>> >>> On Thu, Oct 5, 2023, 21:11 Dale Curtis <dalec...@chromium.org> wrote: >>> >>>> Contact emailsdalec...@chromium.org >>>> >>>> ExplainerNone >>>> >>> >>> We could almost use MDN as the explainer, other than my comment below. >>> >>> >>>> >>>> Specification >>>> https://html.spec.whatwg.org/multipage/media.html#loading-the-media-resource >>>> >>>> Design docs >>>> https://developer.mozilla.org/en-US/docs/Web/HTML/Element/source#media >>>> >>> >>> MDN still says the media on<source> is only allowed with a <picture> >>> parent. Could y'all file an issue to get that fixed? >>> >> One was already filed here: >> https://github.com/mdn/content/issues/27079 >> > >> >>> >>> >>>> >>>> Summary >>>> >>>> Adds support for CSS media queries to <source> elements used with >>>> <video> elements. Allowing developers to use media query syntax to tell >>>> the >>>> browser which source should be preferred for a given environment. >>>> >>>> >>>> Blink componentBlink>Media>Video >>>> <https://bugs.chromium.org/p/chromium/issues/list?q=component:Blink%3EMedia%3EVideo> >>>> >>>> TAG reviewNone >>>> >>> >>> Not required as it's part of the spec and shipped in other >>> implementations. >>> >> >>>> >>>> TAG review statusNot applicable >>>> >>>> Risks >>>> >>>> >>>> Interoperability and Compatibility >>>> >>>> Chromium used to support this feature, but it was deprecated and >>>> removed in https://bugs.chromium.org/p/chromium/issues/detail?id=338197 >>>> -- foolip@ now believes this removal was incorrect. >>>> >>>> >>>> *Gecko*: Shipped/Shipping ( >>>> https://bugzilla.mozilla.org/show_bug.cgi?id=1836128) >>>> >>>> *WebKit*: Shipped/Shipping ( >>>> https://github.com/whatwg/html/issues/6363#issuecomment-1556228111) >>>> >>>> *Web developers*: Positive (12 stars on the issue. Developers are >>>> passionate enough to implement the feature themselves in Firefox) >>>> >>>> *Other signals*: >>>> >>>> WebView application risks >>>> >>>> Does this intent deprecate or change behavior of existing APIs, such >>>> that it has potentially high risk for Android WebView-based applications? >>>> >>>> None >>>> >>>> >>>> Debuggability >>>> >>>> None >>>> >>>> >>>> Will this feature be supported on all six Blink platforms (Windows, >>>> Mac, Linux, Chrome OS, Android, and Android WebView)?Yes >>>> >>>> Is this feature fully tested by web-platform-tests >>>> <https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md> >>>> ?Yes >>>> >>>> >>>> https://wpt.fyi/results/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-source-media-env-change.html?label=master&label=experimental&aligned >>>> >>>> >>>> >>>> Flag name on chrome://flagsNone >>>> >>>> Finch feature nameVideoSourceMediaQuerySupport >>>> >>>> Requires code in //chrome?False >>>> >>>> Tracking bug >>>> https://bugs.chromium.org/p/chromium/issues/detail?id=1450316 >>>> >>>> Estimated milestones >>>> Shipping on desktop 120 >>>> Shipping on Android 120 >>>> Shipping on WebView 120 >>>> >>>> Anticipated spec changes >>>> >>>> Open questions about a feature may be a source of future web compat or >>>> interop issues. Please list open issues (e.g. links to known github issues >>>> in the project for the feature specification) whose resolution may >>>> introduce web compat/interop risk (e.g., changing to naming or structure >>>> of >>>> the API in a non-backward-compatible way). >>>> None >>>> >>>> Link to entry on the Chrome Platform Status >>>> https://chromestatus.com/feature/5144127067127808 >>>> >>>> This intent message was generated by Chrome Platform Status >>>> <https://chromestatus.com/>. >>>> >>>> -- >>>> You received this message because you are subscribed to the Google >>>> Groups "blink-dev" group. >>>> >>> To unsubscribe from this group and stop receiving emails from it, send >>>> an email to blink-dev+...@chromium.org. >>> >>> >>>> To view this discussion on the web visit >>>> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAPUDrwcJ42qj-ddQQcRi8f-YmfmzbkU-VStxdeM%2By_8u3%3Dh9-Q%40mail.gmail.com >>>> >>>> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAPUDrwcJ42qj-ddQQcRi8f-YmfmzbkU-VStxdeM%2By_8u3%3Dh9-Q%40mail.gmail.com?utm_medium=email&utm_source=footer> >>>> . >>>> >>> -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/e7a53d3f-db6c-4622-81b4-9be31bcfda0an%40chromium.org.
