On Wed, Oct 4, 2023 at 6:30 AM Yoav Weiss <[email protected]> wrote:
> > On Fri, Sep 29, 2023 at 11:04 PM David Baron <[email protected]> wrote: > >> Summary >> >> This feature adds the ability to construct exclusive accordions using a >> sequence of HTML <details> elements. It adds a name attribute to the >> <details> element. When this attribute is used, multiple <details> elements >> that have the same name form a group. At most one element in the group can >> be open at once. >> > > This looks great!! > The only tiny concern I have is the question of compatibility: Is it > possible that existing <details> elements share a name attribute? > Would it be possible for you to run a quick HTTPArchive scan and see this > is not a semi-common pattern? > I ran a query with HTTPArchive <https://docs.google.com/document/d/1cpjWFoXBiuFYI4zb9I7wHs7uYZ0ntbOgLwH-mgqXdEM/edit>, in particular, the following query: SELECT page, url FROM `httparchive.all.requests` WHERE date = '2023-09-01' AND client = 'desktop' AND is_main_document AND REGEXP_CONTAINS(response_body, r '(?is)<details[[:space:]][^>]*?[[:space:]]name(=|[[:space:]]|>)') This produced 6 urls (for 7 pages; two of them redirect to the same URL). I did view-source: of the 6 urls and based on visual inspection found that 0 of the 6 would be broken by shipping this feature. In more detail: - 3 of the 6 (associated with the same site, mailchimp.com) had multiple <details> elements, on each of which the name and id attributes had the same value, and these values were properly unique (at least among the <details> elements) - 1 had a single <details> with name="somename" - 1 had a single <details> with name="body" and id="body"; there were other elements with this name/id, but none of the others were <details> - 1 had a single <details> element with a unique-ish looking name So none of the pages found used the name attribute in a way that would be affected by shipping this feature (i.e., multiple <details> elements with the same name). Anticipated spec changes >> >> Open questions about a feature may be a source of future web compat or >> interop issues. Please list open issues (e.g. links to known github issues >> in the project for the feature specification) whose resolution may >> introduce web compat/interop risk (e.g., changing to naming or structure of >> the API in a non-backward-compatible way). >> There may still be some small changes as part of the process of getting >> https://github.com/whatwg/html/pull/9400 finished, but I hope to >> implement those before shipping (at least those that happen soon). >> > > The PR is merged. Is there more work happening on it? > No. I sent the intent before the PR was merged. I do still need to follow up on a piece of the discussion there and file an issue on html-aam, though. -David -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAG0MU3gisj8cH4aCDOeDDMJpmUyOKxoU5FnfrT-FeFDN-_c%3DJQ%40mail.gmail.com.
