LGTM1 On Wed, Oct 11, 2023 at 11:26 PM Tommy Steimel <[email protected]> wrote:
> > > On Wed, Oct 11, 2023 at 7:43 AM Yoav Weiss <[email protected]> wrote: > >> >> >> On Friday, October 6, 2023 at 12:55:09 AM UTC+2 [email protected] wrote: >> >> Hi, >> >> Please update your chromestatus entry to trigger the other 5 review >> categories for this intent. I think it's probably the case that you ended >> up with the wrong feature category and need to update it, sorry for any >> confusion. @Jason Robbins <[email protected]> also. >> >> On Wed, Oct 4, 2023 at 3:35 PM 'Tommy Steimel' via blink-dev < >> [email protected]> wrote: >> >> Contact emails >> >> [email protected], [email protected] >> >> Explainer >> >> https://github.com/w3c/mediasession/issues/294 >> >> >> Can you explain what this action does and how developers are likely to >> use it? >> > > Sure. In general, websites can register handlers on the Media Session for > various actions (e.g. "nexttrack"). The UA can then trigger those actions > on the page via browser UI or other user actions (e.g. a next track > button in the browser native UI or if the user presses the "next track" key > on their keyboard). For the case of 'enterpictureinpicture', the website > would register a handler for that action and the UA can trigger it when > appropriate (e.g. Chrome has a picture-in-picture button in its global > media controls UI). The website can use that handler to call > requestPictureInPicture on a video element or request a document > picture-in-picture window. > > >> >> >> >> Specification >> >> https://github.com/w3c/mediasession/pull/295 >> >> >> What's blocking the PR from landing? >> > > I was waiting on review from the other Media Session author. I pinged them > today and have landed the PR. > > >> >> >> >> API spec >> >> Yes >> >> Summary >> >> Adds an 'enterpictureinpicture' action to the Media Session API. Websites >> can register an action handler which can be used to open a >> Picture-in-Picture or Document Picture-in-Picture window. >> >> Blink component >> >> Blink>Media>Session >> >> TAG review >> >> This small addition to the Media Session API doesn’t seem to qualify for >> a TAG review. >> >> Note that one for video conferencing actions was approved previously at >> https://github.com/w3ctag/design-reviews/issues/608 >> >> TAG review status >> >> N/A >> >> Debuggability >> >> No DevTools changes are required, treated like any other attribute/enum. >> >> Risks >> >> >> Interoperability and Compatibility >> It’s low risk as it's a small addition to an existing API that both Gecko >> and WebKit approve of. >> >> >> Signals from other implementations (Gecko, WebKit): >> >> Gecko: No signal >> >> WebKit: No signal - Generally positive feedback when discussed in the >> Media WG, but no official position pursued due to the small nature of the >> change >> >> Web / Framework developers: Positive >> >> (https://github.com/WICG/document-picture-in-picture/issues/96) >> >> The above citation is one example amongst many where developers want to >> be able to initiate pip through other means (e.g. automatically when >> switching tabs or when a picture-in-picture button is pressed in browser >> UI), and having a media session action for this enables the UA to allow the >> website to open a picture-in-picture window in these cases >> >> >> Ergonomics: >> >> N/A: small addition to an enum of an existing API >> >> Activation: >> >> Web developers will be able to simply set/unset a media session action >> handler for “enterpictureinpicture” to make use of this change. When the >> action name is not supported, it raises a TypeError which can be caught to >> detect feature support. >> >> Is this feature fully tested by web-platform-tests? >> >> https://wpt.fyi/results/mediasession/setactionhandler.html >> >> Tracking bug >> >> https://crbug.com/1457056 >> >> Estimated milestones >> >> Shipping on desktop 120 >> >> Link to entry on the Chrome Platform Status >> >> https://chromestatus.com/feature/6245717716238336 >> >> -- >> You received this message because you are subscribed to the Google Groups >> "blink-dev" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected]. >> To view this discussion on the web visit https://groups.google.com/a/ >> chromium.org/d/msgid/blink-dev/CAE-AwAr3XMLjkds47PAf5_n- >> m%2Bv5mLXKBbX5211E_qs-W3sqTA%40mail.gmail.com >> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAE-AwAr3XMLjkds47PAf5_n-m%2Bv5mLXKBbX5211E_qs-W3sqTA%40mail.gmail.com?utm_medium=email&utm_source=footer> >> . >> >> -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAL5BFfUANk3S4TCHahwJV4q64yQrWmphCiyeC3Uq7xUV%2Be5LWQ%40mail.gmail.com.
