LGTM2
On 10/16/23 1:35 PM, Alex Russell wrote:
LGTM1
On Sun, Oct 15, 2023 at 1:01 PM ChangSeok Oh <[email protected]> wrote:
Contact emails
[email protected],[email protected]
Specification
https://drafts.csswg.org/css-font-loading/#font-face-set-check
Summary
The FontFaceSet's check() function verifies whether it's possible
to display text using the specified fonts without attempting to
utilize fonts in the FontFaceSet that have not completed loading.
This allows users to safely employ the font without later
triggering a font replacement (i.e., font swap).
*Motivation
*While having a review [1] to fix issue 1416842 [2], I heard that
an "Intent to ship" email is required since the fix changes
Blink's behavior. The font loading API was updated, so we need to
update our implementation in conformance with the spec.
[1] https://chromium-review.googlesource.com/c/chromium/src/+/4913179
[2] https://crbug.com/1416842
Blink component
Blink>Fonts
<https://bugs.chromium.org/p/chromium/issues/list?q=component:Blink%3EFonts>
Search tags
CSS <https://chromestatus.com/features#tags:CSS>,Font
<https://chromestatus.com/features#tags:Font>,Loading
<https://chromestatus.com/features#tags:Loading>,FontFaceSet
<https://chromestatus.com/features#tags:FontFaceSet>,check
<https://chromestatus.com/features#tags:check>
TAG review
None
TAG review status
Not applicable
Risks
Interoperability and Compatibility
The current behavior of Blink does neither follow the updated spec
nor match other engines' behavior. This proposal aims at fixing
it. https://github.com/w3c/csswg-drafts/issues/5744
/Gecko/: Shipped/Shipping
(https://bugzilla.mozilla.org/show_bug.cgi?id=1252821)
/WebKit/: Shipped/Shipping
(https://bugs.webkit.org/show_bug.cgi?id=156035)
/Web developers/: No signals
/Other signals/:
WebView application risks
Does this intent deprecate or change behavior of existing APIs,
such that it has potentially high risk for Android WebView-based
applications?
None
Debuggability
None
Will this feature be supported on all six Blink platforms
(Windows, Mac, Linux, Chrome OS, Android, and Android WebView)?
Yes
Is this feature fully tested byweb-platform-tests
<https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md>?Yes
The following WPT tests cover this feature. *
css/css-fonts/fallback-remote-to-data-url.html *
css/css-fonts/fallback-url-to-local.html
Flag name on chrome://flags
None
Finch feature name
None
Non-finch justification
None
Requires code in //chrome?
False
Tracking bug
https://bugs.chromium.org/p/chromium/issues/detail?id=1416842
Estimated milestones
Shipping on desktop
120
Shipping on Android
120
Shipping on WebView
120
Shipping on WebView
120
Anticipated spec changes
Open questions about a feature may be a source of future web
compat or interop issues. Please list open issues (e.g. links to
known github issues in the project for the feature specification)
whose resolution may introduce web compat/interop risk (e.g.,
changing to naming or structure of the API in a
non-backward-compatible way).
None
Link to entry on the Chrome Platform Status
https://chromestatus.com/feature/5174086494060544
This intent message was generated byChrome Platform Status
<https://chromestatus.com/>.
--
You received this message because you are subscribed to the Google
Groups "blink-dev" group.
To unsubscribe from this group and stop receiving emails from it,
send an email to [email protected].
To view this discussion on the web visit
https://groups.google.com/a/chromium.org/d/msgid/blink-dev/f1705c1e-cf65-4c2e-bfe2-3ee3b4fb12d1n%40chromium.org
<https://groups.google.com/a/chromium.org/d/msgid/blink-dev/f1705c1e-cf65-4c2e-bfe2-3ee3b4fb12d1n%40chromium.org?utm_medium=email&utm_source=footer>.
--
You received this message because you are subscribed to the Google
Groups "blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send
an email to [email protected].
To view this discussion on the web visit
https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAA44PQj9Q67soyyTMG_eP_2PUPyRNEHh63HXbcbA5TT0mGEe3g%40mail.gmail.com
<https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAA44PQj9Q67soyyTMG_eP_2PUPyRNEHh63HXbcbA5TT0mGEe3g%40mail.gmail.com?utm_medium=email&utm_source=footer>.
--
You received this message because you are subscribed to the Google Groups
"blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/a/chromium.org/d/msgid/blink-dev/6b891ee3-f999-42cd-9552-1353bd2d74a0%40chromium.org.
