LGTM3 https://wpt.fyi/results/url?label=master&label=experimental&aligned&q=canparse shows this is indeed passing on Firefox and Safari.
On Mon, Oct 16, 2023 at 7:34 PM Alex Russell <slightly...@chromium.org> wrote: > LGTM2 > > On Mon, Oct 16, 2023 at 7:24 AM Mike Taylor <miketa...@chromium.org> > wrote: > >> LGTM1 >> On 10/13/23 6:08 PM, Jeremy Roman wrote: >> >> Contact emails jbro...@chromium.org >> >> Explainer None >> >> Specification https://url.spec.whatwg.org/#dom-url-canparse >> >> Summary >> >> A static operation to determine whether a URL string is valid. More >> concise than catching an exception thrown from the URL constructor. >> >> >> Blink component Blink>DOM >> <https://bugs.chromium.org/p/chromium/issues/list?q=component:Blink%3EDOM> >> >> TAG review None >> >> TAG review status Not applicable >> >> Risks >> >> >> Interoperability and Compatibility >> >> This improves interoperability -- this feature is already supported in >> stable releases of Firefox and Safari. It is not expected to have any >> compatibility risk. >> >> >> *Gecko*: Shipped/Shipping >> >> *WebKit*: Shipped/Shipping >> >> *Web developers*: Positive (https://github.com/whatwg/url/issues/713) >> >> *Other signals*: >> >> Ergonomics >> >> Improves ergonomics of checking URL validity. >> >> >> Activation >> >> None anticipated. >> >> >> Security >> >> None -- this is an ergonomic change. >> >> >> WebView application risks >> >> Does this intent deprecate or change behavior of existing APIs, such that >> it has potentially high risk for Android WebView-based applications? >> >> None >> >> >> Debuggability >> >> None. >> >> >> Will this feature be supported on all six Blink platforms (Windows, Mac, >> Linux, Chrome OS, Android, and Android WebView)? Yes >> >> Is this feature fully tested by web-platform-tests >> <https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md> >> ? Yes >> >> Covered under url/ directory, and functionality is close to trivial. >> >> >> Flag name on chrome://flags None >> >> Finch feature name None >> >> Non-finch justification None >> >> Requires code in //chrome? False >> >> Estimated milestones >> Shipping on desktop 120 >> Shipping on Android 120 >> Shipping on WebView 120 >> >> Anticipated spec changes >> >> Open questions about a feature may be a source of future web compat or >> interop issues. Please list open issues (e.g. links to known github issues >> in the project for the feature specification) whose resolution may >> introduce web compat/interop risk (e.g., changing to naming or structure of >> the API in a non-backward-compatible way). >> None >> >> Link to entry on the Chrome Platform Status >> https://chromestatus.com/feature/5123302532317184 >> >> This intent message was generated by Chrome Platform Status >> <https://chromestatus.com/>. >> -- >> You received this message because you are subscribed to the Google Groups >> "blink-dev" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to blink-dev+unsubscr...@chromium.org. >> To view this discussion on the web visit >> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CACuR13cbGAQn0-F_ygyqh1n0SP4p4rxdWO-0VYcb__fGYwgXqA%40mail.gmail.com >> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CACuR13cbGAQn0-F_ygyqh1n0SP4p4rxdWO-0VYcb__fGYwgXqA%40mail.gmail.com?utm_medium=email&utm_source=footer> >> . >> >> -- >> You received this message because you are subscribed to the Google Groups >> "blink-dev" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to blink-dev+unsubscr...@chromium.org. >> To view this discussion on the web visit >> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/c61d7298-ba71-4cae-89d6-bfdcbb94b211%40chromium.org >> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/c61d7298-ba71-4cae-89d6-bfdcbb94b211%40chromium.org?utm_medium=email&utm_source=footer> >> . >> > -- > You received this message because you are subscribed to the Google Groups > "blink-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to blink-dev+unsubscr...@chromium.org. > To view this discussion on the web visit > https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAA44PQjjLco914L%3DBrX45iQU1OG4yJ4AdphcYkAL38Dh_BDSNQ%40mail.gmail.com > <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAA44PQjjLco914L%3DBrX45iQU1OG4yJ4AdphcYkAL38Dh_BDSNQ%40mail.gmail.com?utm_medium=email&utm_source=footer> > . > -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAARdPYcdNDPK09PraR789hc_6dhffr0VLAnWNi1qOBxM8_93aw%40mail.gmail.com.
