LGTM3 On Fri, Oct 27, 2023 at 1:01 PM Dale Curtis <dalecur...@chromium.org> wrote:
> Looks like this got approved on chrome status, but is still missing an > LGTM3. Anyone else want to weigh in? > > - dale > > On Wed, Oct 25, 2023 at 12:35 PM Mike Taylor <miketa...@chromium.org> > wrote: > >> LGTM2 >> On 10/25/23 3:06 PM, 'Rick Byers' via blink-dev wrote: >> >> Looks pretty straightforward to me, especially with Safari already >> shipping. LGTM1 >> >> On Wed, Oct 18, 2023 at 7:18 PM Dale Curtis <dalecur...@chromium.org> >> wrote: >> >>> Contact emails v...@microsoft.com, gw...@microsoft.com, >>> gur...@microsoft.com, dalecur...@chromium.org >>> >>> Explainer >>> https://github.com/w3c/media-capabilities/blob/main/explainer.md#decode-capabilities >>> >>> Specification https://www.w3.org/TR/media-capabilities/#hdrmetadatatype >>> >>> Summary >>> >>> Extends the Media Capabilities API to allow detection of HDR rendering >>> support via three new VideoConfiguration dictionary fields: >>> hdrMetadataType, colorGamut, transferFunction. Chromium implements its own >>> tone-mapping algorithms so will always return true for HDR10 (smpteSt2086) >>> static metadata. HDR10+ (smpteSt2094-10) and Dolby Vision (smpteSt2094-40) >>> dynamic metadata are not currently supported, so will return false. We >>> anticipate adding support for dynamic metadata in the future, so this API >>> will allow developers to select the appropriate content for users with >>> support. >>> >>> >>> Blink component Blink>Media>Capabilities >>> <https://bugs.chromium.org/p/chromium/issues/list?q=component:Blink%3EMedia%3ECapabilities> >>> >>> TAG review Already shipping by another UA. The now-closed Media >>> Capabilities TAG review covered similar discussions: >>> https://github.com/w3ctag/design-reviews/issues/218 >>> >>> TAG review status Not applicable >>> >>> Risks >>> >>> >>> Interoperability and Compatibility >>> >>> Low interop risk: Already shipping in Safari. >>> >>> >>> *Gecko*: Neutral ( >>> https://github.com/mozilla/standards-positions/issues/910) >>> >>> *WebKit*: Shipped/Shipping ( >>> https://www.w3.org/2019/11/19-mediawg-minutes.html) >>> >>> *Web developers*: Positive ( >>> https://github.com/w3c/media-capabilities/issues/118#issuecomment-511461132 >>> ) >>> >>> *Other signals*: >>> >>> Activation >>> >>> Will start returning false for some DolbyVision and HDR10+ metadata >>> types on the web -- playback would have been broken already for these. >>> >>> >>> WebView application risks >>> >>> Does this intent deprecate or change behavior of existing APIs, such >>> that it has potentially high risk for Android WebView-based applications? >>> >>> No risks unique to WebView. >>> >>> >>> Debuggability >>> >>> Debuggable through media dev tools and chrome://gpu information. >>> >>> >>> Will this feature be supported on all six Blink platforms (Windows, Mac, >>> Linux, Chrome OS, Android, and Android WebView)? Yes >>> >>> Is this feature fully tested by web-platform-tests >>> <https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md> >>> ? Yes >>> >>> >>> https://wpt.fyi/results/media-capabilities/decodingInfo.any.html?label=experimental&label=master&aligned >>> >> >> Thanks! Is there a bug filed for the three tests failing in Chrome? >> >> Flag name on chrome://flags >>> >>> Finch feature name MediaCapabilitiesDynamicRange >>> >>> Requires code in //chrome? False >>> >>> Tracking bug >>> https://bugs.chromium.org/p/chromium/issues/detail?id=1048045 >>> >>> Estimated milestones >>> Shipping on desktop 120 >>> Shipping on Android 120 >>> Shipping on WebView 120 >>> >>> Anticipated spec changes >>> >>> Open questions about a feature may be a source of future web compat or >>> interop issues. Please list open issues (e.g. links to known github issues >>> in the project for the feature specification) whose resolution may >>> introduce web compat/interop risk (e.g., changing to naming or structure of >>> the API in a non-backward-compatible way). >>> Spec changes have already been submitted since the feature is shipping >>> in Safari. >>> >>> Link to entry on the Chrome Platform Status >>> https://chromestatus.com/feature/6640863931269120 >>> >>> Links to previous Intent discussions Intent to prototype: >>> https://groups.google.com/a/chromium.org/g/blink-dev/c/jBzVLBz-Yk4/m/ORuQg2zAEwAJ >>> >>> This intent message was generated by Chrome Platform Status >>> <https://chromestatus.com/>. >>> -- >>> You received this message because you are subscribed to the Google >>> Groups "blink-dev" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to blink-dev+unsubscr...@chromium.org. >>> To view this discussion on the web visit >>> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAPUDrwforrrpNE5RLc_OVa9uwa-63UX03VgijptNU5E8sVcD7g%40mail.gmail.com >>> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAPUDrwforrrpNE5RLc_OVa9uwa-63UX03VgijptNU5E8sVcD7g%40mail.gmail.com?utm_medium=email&utm_source=footer> >>> . >>> >> -- >> You received this message because you are subscribed to the Google Groups >> "blink-dev" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to blink-dev+unsubscr...@chromium.org. >> To view this discussion on the web visit >> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAFUtAY-9LJRQwQscKevqnKDWtWkVkyaD%3Dgb7WK1RXRx2bvXn4A%40mail.gmail.com >> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAFUtAY-9LJRQwQscKevqnKDWtWkVkyaD%3Dgb7WK1RXRx2bvXn4A%40mail.gmail.com?utm_medium=email&utm_source=footer> >> . >> >> -- > You received this message because you are subscribed to the Google Groups > "blink-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to blink-dev+unsubscr...@chromium.org. > To view this discussion on the web visit > https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAPUDrwea0MaMQhSprLAPrj4sNJd8JySF2-RR%3D5Th8p5eSmAyAQ%40mail.gmail.com > <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAPUDrwea0MaMQhSprLAPrj4sNJd8JySF2-RR%3D5Th8p5eSmAyAQ%40mail.gmail.com?utm_medium=email&utm_source=footer> > . > -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAOMQ%2Bw-%3Dp4GGDoHzdgB5n5%2B1vLAgxU%3D5Z4yTjczDTKzSs8QQxw%40mail.gmail.com.
