LGTM3 On Wed, Nov 8, 2023 at 7:30 AM Mike Taylor <[email protected]> wrote:
> LGTM2 > On 11/8/23 5:16 AM, Yoav Weiss wrote: > > LGTM1 - seems like a simple and useful addition to the API surface. > > On Wednesday, November 1, 2023 at 3:07:22 PM UTC+1 > [email protected] wrote: > >> Am Mi., 25. Okt. 2023 um 18:40 Uhr schrieb Mike Taylor < >> [email protected]>: >> >>> On 10/20/23 2:27 PM, 'Philipp Hancke' via blink-dev wrote: >>> >>> Contact emails >>> >>> >>> * [email protected] <[email protected]>, >>> [email protected] <[email protected]> * Explainer >>> >>> * None * >>> >>> For those looking for an explainer, hope down to the design docs section >>> (nice explainer, btw!). >>> >>> >>> Specification >>> >>> >>> * >>> https://www.w3.org/TR/webcodecs-av1-codec-registration/#dom-av1encoderconfig-forcescreencontenttools >>> <https://www.w3.org/TR/webcodecs-av1-codec-registration/#dom-av1encoderconfig-forcescreencontenttools> >>> * Design docs >>> >>> >>> * >>> https://github.com/fippo/webrtc-explainers/blob/gh-pages/av1-screencontent/index.md >>> <https://github.com/fippo/webrtc-explainers/blob/gh-pages/av1-screencontent/index.md> >>> * Summary >>> >>> >>> >>> * Adds AV1EncoderConfig (a dictionary containing >>> forceScreenContentTools) to the VideoEncoderConfig along these lines: >>> encoder.configure({ codec: 'av01.0.04M.08', av1: { forceScreenContentTools: >>> true}, width: 1920, height: 1080, bitrate: 2_000_000, framerate: 5, }); >>> This allows an application to encode “screen content”, in particular >>> presentation slides, in a more efficient way supported by the AV1 codec. >>> This material is typically static, often includes text, a limited set of >>> colors, lots of repetitive content (e.g. straight lines, shapes) for which >>> the encoder can optimize. See the explainer for a lot of visual examples. >>> This AV1 feature is already supported by WebRTC and enabled for screen >>> sharing MediaStreamTracks so this increases platform consistency. * Blink >>> component >>> >>> >>> * Blink>Media>WebCodecs >>> <https://bugs.chromium.org/p/chromium/issues/list?q=component:Blink%3EMedia%3EWebCodecs> >>> * TAG review >>> >>> >>> * None * TAG review status >>> >>> * Not applicable * >>> >>> An FYI review would be nice (especially given the discussions around >>> per-frame/per-codec options), can you send one? >>> >> >> Opened an issue here: https://github.com/w3ctag/design-reviews/issues/912 >> >>> >>> Risks >>> >>> Interoperability and Compatibility >>> >>> >>> * None Gecko: Neutral similar to this situation >>> https://github.com/mozilla/standards-positions/issues/837#issuecomment-1614666364 >>> <https://github.com/mozilla/standards-positions/issues/837#issuecomment-1614666364> >>> * >>> >>> Can we go ahead and request a position? It's not clear to me that >>> Mozilla was present when the feature was discussed at >>> https://lists.w3.org/Archives/Public/public-media-wg/2023Apr/0007.html. >>> >> >> Done: https://github.com/mozilla/standards-positions/issues/916 >> Looks like this was discussed at the editors meeting: >> https://github.com/w3c/webcodecs/pull/662#issuecomment-1526010045 but >> since those don't have notes... ;-) >> >>> >>> >>> >>> >>> * WebKit: No signal >>> (https://github.com/WebKit/standards-positions/issues/239 >>> <https://github.com/WebKit/standards-positions/issues/239>) Web developers: >>> No signals Presented in the screen capture community group during TPAC >>> 2023, slides here: >>> https://docs.google.com/presentation/d/10i4HFYZ4CylpFUuoJcigfiI5uS7pK3uaseQpcYhugAY/edit#slide=id.g27ea3fad398_0_0 >>> <https://docs.google.com/presentation/d/10i4HFYZ4CylpFUuoJcigfiI5uS7pK3uaseQpcYhugAY/edit#slide=id.g27ea3fad398_0_0> >>> Other signals: * WebView application risks >>> >>> >>> * Does this intent deprecate or change behavior of existing APIs, such >>> that it has potentially high risk for Android WebView-based applications? >>> None * Debuggability >>> >>> >>> * None *Will this feature be supported on all six Blink platforms >>> (Windows, Mac, Linux, Chrome OS, Android, and Android WebView)? >>> >>> >>> * Yes * Is this feature fully tested by web-platform-tests >>> <https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md> >>> ? >>> >>> >>> >>> * No Unclear to what degree this is testable. Enabling this feature >>> reduces the encoded frame size which makes it tough to test, it might be >>> possible with a canvas source that provides predictable input similar to >>> https://webrtc.github.io/samples/src/content/insertable-streams/video-processing/ >>> <https://webrtc.github.io/samples/src/content/insertable-streams/video-processing/> >>> * Flag name on chrome://flags >>> >>> >>> * None * Finch feature name >>> >>> >>> * None * Non-finch justification >>> >>> >>> * None * Requires code in //chrome? >>> >>> >>> * False * Tracking bug >>> >>> >>> * https://bugs.chromium.org/p/chromium/issues/detail?id=1464862 >>> <https://bugs.chromium.org/p/chromium/issues/detail?id=1464862> * Estimated >>> milestones >>> >>> >>> * Shipping on desktop 121 * Anticipated spec changes >>> >>> >>> >>> * None * Link to entry on the Chrome Platform Status >>> >>> >>> * https://chromestatus.com/feature/6307770441138176 >>> <https://chromestatus.com/feature/6307770441138176> * Links to previous >>> Intent discussions n/a >>> >>> This intent message was generated by Chrome Platform Status >>> <https://chromestatus.com/>. >>> >>> -- >>> You received this message because you are subscribed to the Google >>> Groups "blink-dev" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to [email protected]. >>> To view this discussion on the web visit >>> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CADxkKiJc34b%3DMrX7HhXQP_gZ3wCFg43qHbLJ7mKQqOPe7WYVwA%40mail.gmail.com >>> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CADxkKiJc34b%3DMrX7HhXQP_gZ3wCFg43qHbLJ7mKQqOPe7WYVwA%40mail.gmail.com?utm_medium=email&utm_source=footer> >>> . >>> >>> -- > You received this message because you are subscribed to the Google Groups > "blink-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To view this discussion on the web visit > https://groups.google.com/a/chromium.org/d/msgid/blink-dev/6c589524-5dba-4d8e-b94a-f594be3f4d83%40chromium.org > <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/6c589524-5dba-4d8e-b94a-f594be3f4d83%40chromium.org?utm_medium=email&utm_source=footer> > . > -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAOMQ%2Bw_0uyF6UqagyTc0J3Hxy_iYGerXu%3Dhq60sMPFpx50Zthw%40mail.gmail.com.
