On Wed, Jan 10, 2024 at 5:25 PM Michal Mocny <mmo...@google.com> wrote:
> > > On Wed, Jan 10, 2024 at 10:55 AM Noam Rosenthal <nrosent...@chromium.org> > wrote: > >> >> >> On Wed, Jan 10, 2024 at 3:47 PM Rick Byers <rby...@chromium.org> wrote: >> >>> Thanks Noam, LGTM2 >>> >>> Q: Since this is a trivial fix, does it need to be behind a flag? Either >>>> way is fine with me. The current CL has it behind a new flag. >>> >>> >>> I guess technically it's a new platform API so our guidelines >>> <https://chromium.googlesource.com/chromium/src/+/main/docs/flag_guarding_guidelines.md> >>> require it. But given how tiny and low risk it is, I wouldn't personally >>> object if you hadn't used a flag. But we all know web compat can be very >>> surprising sometimes and it looks like using a flag was pretty trivial, so >>> I'd personally err on the side of keeping the flag, even though that means >>> another clean-up CL later. >>> >>> Great, perhaps the best way forward is with a flag that's starting as >> "stable" from the get go and we can later remove it. >> > > Just curious-- is this the same as a "kill switch" (default enabled flag)? > (which are already included in the guidelines) > Yea, though the kill switch is 6 lines and the feature itself is 7 lines (albeit web-facing) so the value is marginal :) -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAJn%3DMYZd5zZ7SxcWpm2UQUd25bKyddA2wKeZNbbrrJwepNaORQ%40mail.gmail.com.
