LGTM3 On Fri, Feb 2, 2024 at 2:03 PM Mike Taylor <miketa...@chromium.org> wrote:
> LGMT2 - no concerns about lack of a response from TAG. > On 2/2/24 1:18 AM, Domenic Denicola wrote: > > LGTM1 > > On Fri, Feb 2, 2024 at 6:53 AM David Bokan <bo...@chromium.org> wrote: > >> Contact emails bo...@chromium.org, khushalsa...@chromium.org, >> nrosent...@chromium.org, vmp...@chromium.org >> >> Explainer >> https://github.com/WICG/view-transitions/blob/main/cross-doc-explainer.md >> >> Specification https://html.spec.whatwg.org/#reveal >> >> Design docs >> https://github.com/WICG/view-transitions/blob/main/cross-doc-explainer.md >> >> Summary >> >> The `pagereveal` event is fired on a Document's window object at the >> first render opportunity after a Document is: initially loaded, restored >> from the back-forward cache, or activated from a prerender. It can be used >> by a page author to set up a page entry UX - such as a ViewTransition from >> a previous state. This feature is split out from the larger Cross Document >> View Transition project. >> >> >> Blink component Blink>ViewTransitions >> <https://bugs.chromium.org/p/chromium/issues/list?q=component:Blink%3EViewTransitions> >> >> Search tags transition >> <https://chromestatus.com/features#tags:transition>, firstrender >> <https://chromestatus.com/features#tags:firstrender>, reveal >> <https://chromestatus.com/features#tags:reveal>, event >> <https://chromestatus.com/features#tags:event>, viewtransition >> <https://chromestatus.com/features#tags:viewtransition> >> >> TAG review https://github.com/w3ctag/design-reviews/issues/851 >> >> Note: TAG review was for Cross-Document View Transitions which included >> this event as a piece. I asked TAG whether they'd like to do a separate >> review but didn't receive a response. >> > > I'll note that the ask was in 2023-09-28, with two other pings since then, > so I think this is very fair. (And I also agree that this was covered by > the original review request.) > >> >> TAG review status Issues addressed >> >> Risks >> >> >> Interoperability and Compatibility >> >> This is a new event so shouldn't have any compatibility risks. Usual >> interop risk of other engines not adopting it exists but this should be low >> since it's had input and discussion[1] from engineers of both WebKit and >> Mozilla and is a dependency of cross-document view transitions which has >> received a positive signal from at least Mozilla[2] (waiting to hear from >> Apple[3]). [1] https://github.com/whatwg/html/issues/9315 [2] >> https://github.com/mozilla/standards-positions/issues/677 >> >> [3] https://github.com/WebKit/standards-positions/issues/302 >> >> >> *Gecko*: Positive ( >> https://github.com/mozilla/standards-positions/issues/677) See: >> https://github.com/mozilla/standards-positions/issues/677#issuecomment-1904541389 >> >> *WebKit*: No signal ( >> https://github.com/WebKit/standards-positions/issues/303) Awaiting >> response. >> >> *Web developers*: No signals >> >> *Other signals*: >> >> WebView application risks >> >> Does this intent deprecate or change behavior of existing APIs, such that >> it has potentially high risk for Android WebView-based applications? >> >> No >> >> >> Debuggability >> >> None >> >> >> Will this feature be supported on all six Blink platforms (Windows, Mac, >> Linux, ChromeOS, Android, and Android WebView)? Yes >> >> This is a standard HTML event applicable to all platforms >> >> >> Is this feature fully tested by web-platform-tests >> <https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md> >> ? Yes >> >> >> https://wpt.fyi/results/html/browsers/browsing-the-web/history-traversal/pagereveal?label=experimental&label=master&aligned >> > > Can you un-tentative these tests? > > >> >> >> Flag name on chrome://flags >> chrome://flags/#enable-experimental-web-platform-features >> >> Finch feature name PageRevealEvent >> >> Requires code in //chrome? False >> >> Tracking bug https://crbug.com/1466250 >> >> Estimated milestones >> Shipping on desktop 123 >> DevTrial on desktop 120 >> Shipping on Android 123 >> DevTrial on Android 120 >> Shipping on WebView 123 >> >> Anticipated spec changes >> >> Open questions about a feature may be a source of future web compat or >> interop issues. Please list open issues (e.g. links to known github issues >> in the project for the feature specification) whose resolution may >> introduce web compat/interop risk (e.g., changing to naming or structure of >> the API in a non-backward-compatible way). >> None >> >> Link to entry on the Chrome Platform Status >> https://chromestatus.com/feature/5205586941837312 >> >> Links to previous Intent discussions Intent to prototype: >> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/f0f76584-ea3f-43ab-946c-b920fc064344n%40chromium.org >> >> This intent message was generated by Chrome Platform Status >> <https://chromestatus.com/>. >> -- >> You received this message because you are subscribed to the Google Groups >> "blink-dev" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to blink-dev+unsubscr...@chromium.org. >> To view this discussion on the web visit >> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CANMmsAvhWAzVrHCudjLgQRtePgqEHucNqb27Wkn9r4dCKeUTWg%40mail.gmail.com >> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CANMmsAvhWAzVrHCudjLgQRtePgqEHucNqb27Wkn9r4dCKeUTWg%40mail.gmail.com?utm_medium=email&utm_source=footer> >> . >> > -- > You received this message because you are subscribed to the Google Groups > "blink-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to blink-dev+unsubscr...@chromium.org. > To view this discussion on the web visit > https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAM0wra_Yjbyiv9Ezi_d%2BrWgutSTwcAVGwBJPxkkDCQptuozqEg%40mail.gmail.com > <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAM0wra_Yjbyiv9Ezi_d%2BrWgutSTwcAVGwBJPxkkDCQptuozqEg%40mail.gmail.com?utm_medium=email&utm_source=footer> > . > > -- > You received this message because you are subscribed to the Google Groups > "blink-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to blink-dev+unsubscr...@chromium.org. > To view this discussion on the web visit > https://groups.google.com/a/chromium.org/d/msgid/blink-dev/093ddfbf-486b-42fd-aecb-1e86b6970586%40chromium.org > <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/093ddfbf-486b-42fd-aecb-1e86b6970586%40chromium.org?utm_medium=email&utm_source=footer> > . > -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAOMQ%2Bw9MN-FxbTbcmSc3ifoTrq7F%2BgXS4bPcvwTMjj_m0DrkwA%40mail.gmail.com.
