LGTM2

On Wed, Feb 14, 2024 at 9:28 PM Chris Harrelson <chris...@chromium.org>
wrote:

> Thanks!
>
> LGTM1
>
> On Wed, Feb 14, 2024 at 11:07 AM 'Tommy Steimel' via blink-dev <
> blink-dev@chromium.org> wrote:
>
>> Landed the PR and added a comment to the TAG thread. Thanks!
>>
>> On Wed, Feb 14, 2024 at 6:24 AM Yoav Weiss (@Shopify) <
>> yoavwe...@chromium.org> wrote:
>>
>>>
>>>
>>> On Monday, February 12, 2024 at 10:31:12 PM UTC+1 Tommy Steimel wrote:
>>>
>>> Contact emailsstei...@chromium.org, liber...@chromium.org
>>>
>>> ExplainerNone
>>>
>>> Specificationhttps://github.com/WICG/document-picture-in-picture/
>>> pull/109
>>>
>>>
>>> What's preventing the PR from landing?
>>>
>>>
>>>
>>>
>>> Summary
>>>
>>> This enables `opener.focus()` from a document picture-in-picture window
>>> to bring system-level focus to the tab that owns the document
>>> picture-in-picture window. This allows developers to bring the original tab
>>> back to the foreground when necessary, e.g. when the user needs to access a
>>> more full UI/experience that doesn't fit in the smaller picture-in-picture
>>> window.
>>>
>>>
>>> Blink componentBlink>Media>PictureInPicture
>>> <https://bugs.chromium.org/p/chromium/issues/list?q=component:Blink%3EMedia%3EPictureInPicture>
>>>
>>> TAG reviewN/A as this is a minor change to the behavior of an existing
>>> API
>>>
>>>
>>> Can you add a comment to notify the TAG of this change?
>>>
>>>
>>>
>>>
>>> TAG review statusNot applicable
>>>
>>> Risks
>>>
>>>
>>> Interoperability and Compatibility
>>>
>>> None
>>>
>>>
>>> *Gecko*: No signal (https://github.com/mozilla/
>>> standards-positions/issues/670#issuecomment-1919880414) Added comment
>>> to existing standards position issue for document picture-in-picture. No
>>> response yet
>>>
>>> *WebKit*: No signal (https://github.com/WebKit/
>>> standards-positions/issues/41#issuecomment-1919879502) Added comment to
>>> existing standards position issue for document picture-in-picture. No
>>> response yet
>>>
>>> *Web developers*: Positive (https://github.com/WICG/
>>> document-picture-in-picture/issues/94) We have received feature
>>> requests for programmatically returning to the opener tab from multiple
>>> first and third-party partners
>>>
>>> *Other signals*:
>>>
>>> Ergonomics
>>>
>>> N/A
>>>
>>>
>>> Activation
>>>
>>> N/A
>>>
>>>
>>> Security
>>>
>>> While allowing the picture-in-picture window to bring system-level focus
>>> to the opener tab at will could be abused, the user gesture requirement
>>> effectively ensures that the user is at least currently interacting with
>>> that website and not another, so is less likely to be surprised or tricked
>>> by the change of focus to another window from the same origin.
>>>
>>>
>>> WebView application risks
>>>
>>> Does this intent deprecate or change behavior of existing APIs, such
>>> that it has potentially high risk for Android WebView-based applications?
>>>
>>> N/A
>>>
>>>
>>> Debuggability
>>>
>>> N/A
>>>
>>>
>>> Will this feature be supported on all six Blink platforms (Windows, Mac,
>>> Linux, ChromeOS, Android, and Android WebView)?No
>>>
>>> The document picture-in-picture API is not supported on Android
>>>
>>>
>>> Is this feature fully tested by web-platform-tests
>>> <https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md>
>>> ?Yes
>>>
>>> document-picture-in-picture/focus-opener.https.html
>>>
>>>
>>> Flag name on chrome://flagsNone
>>>
>>> Finch feature nameNone
>>>
>>> Non-finch justification
>>>
>>> Small change to existing API
>>>
>>>
>>> Requires code in //chrome?False
>>>
>>> Sample links
>>> https://steimelchrome.github.io/backtotab.html
>>>
>>> Estimated milestonesShipping on desktop123
>>>
>>> Anticipated spec changes
>>>
>>> Open questions about a feature may be a source of future web compat or
>>> interop issues. Please list open issues (e.g. links to known github issues
>>> in the project for the feature specification) whose resolution may
>>> introduce web compat/interop risk (e.g., changing to naming or structure of
>>> the API in a non-backward-compatible way).
>>> None expected
>>>
>>> Link to entry on the Chrome Platform Statushttps://chromestatus.com/
>>> feature/6313015987404800
>>>
>>> This intent message was generated by Chrome Platform Status
>>> <https://chromestatus.com/>.
>>>
>>> --
>> You received this message because you are subscribed to the Google Groups
>> "blink-dev" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to blink-dev+unsubscr...@chromium.org.
>> To view this discussion on the web visit
>> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAE-AwAq9NirpNhP%2BcFO8w0oBZhdz6JJ1rUJVd94gyx9Gd8Zt2Q%40mail.gmail.com
>> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAE-AwAq9NirpNhP%2BcFO8w0oBZhdz6JJ1rUJVd94gyx9Gd8Zt2Q%40mail.gmail.com?utm_medium=email&utm_source=footer>
>> .
>>
>

-- 
You received this message because you are subscribed to the Google Groups 
"blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to blink-dev+unsubscr...@chromium.org.
To view this discussion on the web visit 
https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAOmohSJxYVk2esk__uLWYHnKA3mEuQm7kvbjhqShnCkfRi5_%3DQ%40mail.gmail.com.

Reply via email to