LGTM3 On Thu, Feb 29, 2024 at 3:38 AM Mike Taylor <miketa...@chromium.org> wrote:
> LGTM2 > On 2/28/24 9:37 PM, Domenic Denicola wrote: > > With my HTML editor hat on, I can confirm the spec PR looks good and only > has editorial issues left. It fell between the cracks for 2 weeks; > apologies for that. > > With my API Owner hat on, LGTM1. There are a few borderline aspects here: > > - Security review on ChromeStatus has not yet been completed. However, > I trust you will not ship this until that is resolved. > - Technically this does not yet meet the criteria for being exempt > from TAG review > <https://www.chromium.org/blink/guidelines/api-owners/process-exceptions/>, > since Safari has only shipped to beta and the specification isn't yet > merged. However, as mentioned above the spec PR is in good shape, and I > think it's unlikely to be worth the TAG's time to perform a review at this > stage, for a small change of this sort. > > > On Thu, Feb 29, 2024 at 8:13 AM Di Zhang <dizha...@chromium.org> wrote: > >> Based on the release note, the Webkit implementation is already >> implemented and currently shipping. Everything vertical writing-mode >> related is shipping, including the changes included in this feature. >> >> https://developer.apple.com/documentation/safari-release-notes/safari-17_4-release-notes >> >> For Gecko, there has been no update. The bug has been open for a year. >> https://bugzilla.mozilla.org/show_bug.cgi?id=1801791 >> >> This feature is adding a few new WPT tests (listed in the HTML spec PR >> description [1], specifically [2]). >> >> > How far is this from being merged? >> The comments are addressed and I am pinging the HTML reviewers to take a >> final look. >> >> [1] https://github.com/whatwg/html/pull/10096 >> [2] >> https://github.com/web-platform-tests/wpt/commit/7f56feea538b986d5681532c0dcba8c9773cd6c4 >> <https://chromium-review.googlesource.com/c/chromium/src/+/5241236> >> >> >> >> On Wednesday, February 28, 2024 at 5:17:47 AM UTC-8 Manuel Rego wrote: >> >>> >>> >>> On 23/02/2024 21:42, Di Zhang wrote: >>> > Specification >>> > >>> > https://github.com/whatwg/html/issues/8413 >>> > <https://github.com/whatwg/html/issues/8413> >>> >>> What's the status of this issue? Is there any spec text that needs to >>> change? >>> >>> > Interoperability and Compatibility >>> > >>> > Chrome: implemented behind flag Safari: implemented behind flag >>> Firefox: >>> > implemented for <input type=range> in stable, issue created for >>> > meter/progress. >>> > >>> > >>> > >>> > /Gecko/: No signal >>> >>> It seems something is implemented already and you mention there's a bug >>> for some other things, could you link that bug? Are they currently >>> working on it? >>> >>> > /WebKit/: In development >>> > ( >>> https://developer.apple.com/documentation/safari-release-notes/safari-17_4-release-notes >>> < >>> https://developer.apple.com/documentation/safari-release-notes/safari-17_4-release-notes>) >>> Added support for vertical writing mode support for form controls. >>> (12072686) >>> >>> Has this actually shipped in WebKit or is "in development"? >>> >>> You first mentioned "Safari: implemented behind flag", but you're >>> linking to some release notes. >>> >>> Which parts are shipped in Safari and which are not yet? >>> >>> > Is this feature fully tested by web-platform-tests >>> > < >>> https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md>? >>> >>> > >>> > Yes >>> > >>> > >>> https://wpt.fyi/results/css/css-writing-modes/forms?label=master&label=experimental&product=chrome&product=firefox&product=safari&aligned&view=interop&q=label%3Ainterop-2022-forms%20or%20label%3Ainterop-2023-forms >>> < >>> https://wpt.fyi/results/css/css-writing-modes/forms?label=master&label=experimental&product=chrome&product=firefox&product=safari&aligned&view=interop&q=label%3Ainterop-2022-forms%20or%20label%3Ainterop-2023-forms> >>> >>> >>> These tests are all passing in Chrome and Safari (only 3 failing in >>> Firefox). Is this feature adding new tests? >>> >>> > Open questions about a feature may be a source of future web compat or >>> > interop issues. Please list open issues (e.g. links to known github >>> > issues in the project for the feature specification) whose resolution >>> > may introduce web compat/interop risk (e.g., changing to naming or >>> > structure of the API in a non-backward-compatible way). >>> > >>> > HTML spec currently under review: >>> > https://github.com/whatwg/html/pull/10096 >>> > <https://github.com/whatwg/html/pull/10096> >>> >>> Ok, answering my own question on the Spec link, there's indeed a PR >>> here. How far is this from being merged? >>> >>> Thanks, >>> Rego >>> >> -- >> You received this message because you are subscribed to the Google Groups >> "blink-dev" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to blink-dev+unsubscr...@chromium.org. >> To view this discussion on the web visit >> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/fb0208e3-06e4-4d8f-8095-7b2d9e7d32f6n%40chromium.org >> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/fb0208e3-06e4-4d8f-8095-7b2d9e7d32f6n%40chromium.org?utm_medium=email&utm_source=footer> >> . >> > -- > You received this message because you are subscribed to the Google Groups > "blink-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to blink-dev+unsubscr...@chromium.org. > To view this discussion on the web visit > https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAM0wra8LmY8A7Z%2BKHhTxnqeaJS6mVChpRoU28qM8%3DOLxzJb80w%40mail.gmail.com > <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAM0wra8LmY8A7Z%2BKHhTxnqeaJS6mVChpRoU28qM8%3DOLxzJb80w%40mail.gmail.com?utm_medium=email&utm_source=footer> > . > > -- > You received this message because you are subscribed to the Google Groups > "blink-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to blink-dev+unsubscr...@chromium.org. > To view this discussion on the web visit > https://groups.google.com/a/chromium.org/d/msgid/blink-dev/0badde60-508b-4754-9d76-b113f2d5eb96%40chromium.org > <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/0badde60-508b-4754-9d76-b113f2d5eb96%40chromium.org?utm_medium=email&utm_source=footer> > . > -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAOmohSJ%2Br2EOLFqoBmfbRwnfDCOx84mjJ5vhx88R5WxMYi_pJA%40mail.gmail.com.
