I missed this in the CL review, sorry - you have a dependency on Blink in the component but iOS doesn't use Blink in its default build configuration. Try building the iOS files only if `use_blink` is true and also gating the addition of the unittest target as a components_unittests dep on `use_blink` being true. Note that the code used to be under //content, which is entirely gated by `use_blink` <https://source.chromium.org/chromium/chromium/src/+/main:content/BUILD.gn;l=16?q=content%2FBUILD.gn&ss=chromium> .
Best, Colin On Tue, May 21, 2024 at 4:41 PM 'Kartar Singh' via chromium-mojo < [email protected]> wrote: > +cc [email protected] Since the gn variable(*component_deps_blink*) > is blink specific and +cc [email protected] since the failing > target is in mojo(*mojom_core*). > > On Mon, May 20, 2024 at 6:15 PM Kartar Singh <[email protected]> > wrote: > >> Hey, >> >> We have been trying to set up a new component(//components/input), to >> move input related code there. This(https://crrev.com/c/5541976) is the >> initial change that sets up the component and move few header and >> implementation files there. We see that the change was failing to build on >> `ios-simulator` bot with below error: >> >>> >>> >>> >>> >>> >>> >>> >>> >>> >>> >>> *ERROR at //third_party/blink/public/mojom/BUILD.gn:1604:26: Assignment >>> had no effect. component_deps_blink = [ ^You set >>> the variable "component_deps_blink" here and it was unused before it >>> wentout of scope.See //third_party/blink/public/mojom/BUILD.gn:1306:1: >>> whence it was called.mojom("mojom_core") {^--------------------See >>> //third_party/blink/public/common/BUILD.gn:74:5: which caused the file to >>> be included. >>> "//third_party/blink/public/mojom:web_bluetooth_mojo_bindings", >>> ^-------------------------------------------------------------* >> >> We narrowed it down to unit test dependency, i.e. not depending on the >> unittest of the new component on ios >> <https://chromium-review.googlesource.com/c/chromium/src/+/5541976/13..14/components/BUILD.gn> >> didn't >> cause the build failure somehow. >> >> I have this(https://crrev.com/c/5547985) minimal CL on top of our >> component setup cl which repros the build error. Just wanted to reachout to >> get some pointers to help debug this further. >> >> Regards, >> Kartar >> > -- > You received this message because you are subscribed to the Google Groups > "chromium-mojo" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To view this discussion on the web visit > https://groups.google.com/a/chromium.org/d/msgid/chromium-mojo/CAPro3FdvVBadF6xq-qAfdNrjhJ9YaHAH7KSRTMTYTzrKGV47dA%40mail.gmail.com > <https://groups.google.com/a/chromium.org/d/msgid/chromium-mojo/CAPro3FdvVBadF6xq-qAfdNrjhJ9YaHAH7KSRTMTYTzrKGV47dA%40mail.gmail.com?utm_medium=email&utm_source=footer> > . > -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAMGE5NEX5Re7C9yYb0WzpATZyS7ba-R%3DtLrJKM_6tkq%2BbocUoA%40mail.gmail.com.
