On Fri, May 31, 2024, 5:43 AM Markus Handell <[email protected]> wrote:
> Hi Peter, from the spec text: > > "If videoKeyFrameIntervalCount is not null ... the video encoder produces > a keyframe on the *first* frame arriving *after* *videoKeyFrameIntervalCount > frames passed* *since* the last key frame" > > It sounds to me like the blink impl is correctly implementing the spec > meaning. If videoKeyFrameIntervalCount is 0, the spec text implies every > frame should be a key frame. If your alternative interpretation were true, > what would a value of 0 mean? > A value of 0 would in practice have the same effect as a value of 1, both meaning, "key frame every frame". Though also in practice I don't think either actually works, given that the blink impl API only requests key frames in response to receiving delta frames. If "first frame after" is intended to imply "exclusive of", then the count part is correct but the time part is wrong (it would need to switch to > from >=). I think the intent of the wording was to imply "inclusive of", though. But I wasn't in the meetings, so I'm not sure. PK > On Thu, May 30, 2024 at 7:50 PM Peter Kasting <[email protected]> > wrote: > >> On Thursday, May 30, 2024 at 9:32:50 AM UTC-7 Peter Kasting wrote: >> >> The spec says that both the duration and frame count refer to the >> interval "between key frames". >> >> >> More spec text: "If videoKeyFrameIntervalCount is not null and >> videoKeyFrameIntervalDuration is null, the video encoder produces a >> keyframe on the first frame arriving after videoKeyFrameIntervalCount >> frames passed since the last key frame." I think that means Blink's current >> impl is indeed off-by-one. >> >> PK >> > -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAAHOzFD9LvWmZpG2tqSY0_aCKe29hB_r%2Bo3ozp7NG_46STNs8g%40mail.gmail.com.
