Hi Yoav, I think external specifications can define extension commands independently (in their respective WGs) so there is no need to discuss them with the WebDriver WG (unless you want to). The API for testing pressure looks good to me and it would be nice if the spec also defined a WebDriver BiDi <https://w3c.github.io/webdriver-bidi/#external-specifications> module.
Best regards, Alex On Wed, Jun 19, 2024 at 5:55 PM Mathias Bynens <[email protected]> wrote: > > > On Wed, Jun 19, 2024 at 5:52 PM Yoav Weiss (@Shopify) < > [email protected]> wrote: > >> >> >> On Wed, Jun 19, 2024 at 9:55 AM Mandy, Arnaud <[email protected]> >> wrote: >> >>> Contact emails >>> [email protected], [email protected], >>> [email protected], [email protected] >>> >>> Specification >>> https://github.com/w3c/compute-pressure/pull/284 >>> >> >> >> <[email protected]> >> +Mathias Bynens <[email protected]> +Alex Rudenko >> <[email protected]> - I'd love to hear your thoughts on this in >> general and on the PR in particular. >> >> Arnaud - was this discussed with the WebDriver WG? Even if other vendors >> are opposed to the broader feature, it'd still be good to validate the >> design. >> >> >>> >>> Summary >>> This exposes WebDriver commands for creating, removing and updating >>> pressure source samples for so-called "virtual pressure sources": pressure >>> sources that do not depend on underlying hardware or operating system >>> support and can be used for testing. >>> >>> Not only does this allow ChromeDriver users to test this API more >>> easily, but it was also one of the suggestions brought up during the >>> Intent to Ship thread for this API >>> <https://groups.google.com/a/chromium.org/g/blink-dev/c/7leKysvPZWk/m/MEtDE7zyAQAJ>, >>> as the existing web tests in WPT depend on MojoJS and are not interoperable. >>> >>> Blink component >>> Blink>PerformanceAPIs>ComputePressure >>> <https://bugs.chromium.org/p/chromium/issues/list?q=component:Blink%3EPerformanceAPIs%3EComputePressure> >>> >>> TAG review >>> None >>> >>> TAG review status >>> Not applicable >>> >>> Risks >>> >>> >>> Interoperability and Compatibility >>> This feature implements WebDriver extension commands in ChromeDriver >>> that are used in web-platform-tests and can also be used by ChromeDriver >>> users. This feature is therefore not web-exposed, but it does intend to >>> help increase adoption of the spec by making it possible for any >>> implementation to run the existing web tests without having to use JS mocks >>> that are heavily Mojo-based although not dependent on Mojo. >>> >>> *Gecko*: No signal for this feature (Not in favor of Compute Pressure >>> API) >>> >>> *WebKit*: No signal for this feature (Not in favor of Compute Pressure >>> API) >>> >> >> I agree that there's no point in filing for a signal if they are opposed >> to the feature itself. >> >> >>> >>> *Web developers*: No signals >>> >>> *Other signals*: Compute Pressure API Intent To Ship comment >>> <https://groups.google.com/a/chromium.org/g/blink-dev/c/7leKysvPZWk/m/MEtDE7zyAQAJ> >>> . >>> >>> >>> Security >>> n/a, this is exposed through WebDriver. There have been changes to the >>> Compute Pressure code in //content and //services. >>> >>> WebView application risks >>> None, this API is not exposed on Android. >>> >>> Ongoing technical constraints >>> WebDriver endpoints and virtual pressure sources work in Window and >>> Dedicated Worker scopes, but not shared worker ones: we store virtual >>> pressure source information in WebContentsUserData, which does not >>> integrate well with shared workers. Shared worker support would need to >>> work with origins instead, but doing so would not play well with any >>> DevTools frontend work to support the Compute Pressure API. The same >>> constraint is also present in the spec, and feedback is being gathered in >>> issue >>> 285 <https://github.com/w3c/compute-pressure/issues/285>. >>> >>> Debuggability >>> This is a debugging feature. It exposes new ChromeDriver and CDP >>> endpoints, but the DevTools frontend has not been touched. >>> >>> Will this feature be supported on all six Blink platforms (Windows, Mac, >>> Linux, ChromeOS, Android, and Android WebView)? >>> Windows, Mac, Linux, ChromeOS >>> >>> Is this feature fully tested by web-platform-tests >>> <https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md> >>> ? >>> The feature is currently tested by WPT, but the tests depend on >>> Mojo-specific JS mocks. Having these endpoints is the first step towards >>> making the existing web tests interoperable. >>> >>> Requires code in //chrome? >>> True: //chrome/test/chromedriver >>> >>> Tracking bug >>> https://issues.chromium.org/u/1/issues/347031400 >>> >>> Estimated milestones >>> Shipping on desktop 130 >>> >>> >>> Link to entry on the Chrome Platform Status >>> https://chromestatus.com/feature/5130657352384512 >>> >>> -- >>> You received this message because you are subscribed to the Google >>> Groups "blink-dev" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to [email protected]. >>> To view this discussion on the web visit >>> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/DS0PR11MB79029DDFA8D49E3C82BEAF4393CF2%40DS0PR11MB7902.namprd11.prod.outlook.com >>> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/DS0PR11MB79029DDFA8D49E3C82BEAF4393CF2%40DS0PR11MB7902.namprd11.prod.outlook.com?utm_medium=email&utm_source=footer> >>> . >>> >> -- >> You received this message because you are subscribed to the Google Groups >> "blink-dev" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected]. >> To view this discussion on the web visit >> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAOmohSKiAKXvfz0kwH5rPd1jpB5Ub4%2B%3D-hT%3D7j5i6nFB1mq6tg%40mail.gmail.com >> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAOmohSKiAKXvfz0kwH5rPd1jpB5Ub4%2B%3D-hT%3D7j5i6nFB1mq6tg%40mail.gmail.com?utm_medium=email&utm_source=footer> >> . >> > -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAHuqpVPwY2KCbyNPp3AhL_fjM8%3D3eCU8hj%2B5fDu2hHOLjv1fvQ%40mail.gmail.com.
