Thanks! LGTM1
On Wed, Nov 6, 2024 at 11:42 AM 'Thomas Guilbert' via blink-dev < blink-dev@chromium.org> wrote: > > > On Wed, Nov 6, 2024 at 7:28 AM Yoav Weiss (@Shopify) < > yoavwe...@chromium.org> wrote: > >> >> >> On Mon, Nov 4, 2024 at 7:20 PM Thomas Guilbert <tguilb...@chromium.org> >> wrote: >> >>> Contact emailstguilb...@chromium.org >>> >>> ExplainerNone >>> >>> SpecificationNone >>> >>> Summary >>> >>> The prefixed HTMLVideoElement-specific fullscreen APIs have been >>> deprecated since approximately M38. They were replaced by the >>> Element.requestFullscreen() API, which first shipped un-prefixed in M71, in >>> 2018. As of 2024, most browsers have had support for the un-prefixed APIs >>> for a few years now. This feature tracks removing the following APIs from >>> HTMLVideoElement: - readonly attribute boolean webkitSupportsFullscreen; - >>> readonly attribute boolean webkitDisplayingFullscreen; - void >>> webkitEnterFullscreen(); - void webkitExitFullscreen(); // Note the >>> different capitalization of the "S" in FullScreen. - void >>> webkitEnterFullScreen(); - void webkitExitFullScreen(); These methods are >>> now only aliases for the modern API. Their use has declined steadily over >>> the years. >>> >>> Blink componentBlink>Fullscreen >>> <https://bugs.chromium.org/p/chromium/issues/list?q=component:Blink%3EFullscreen> >>> >>> TAG reviewNone >>> >>> TAG review statusNot applicable >>> >>> Chromium Trial NameDeprecatePrefixedVideoFullscreen >>> >>> Origin Trial documentation link >>> https://developer.mozilla.org/en-US/docs/Web/API/Fullscreen_API >>> >>> WebFeature UseCounter namekPrefixedVideoSupportsFullscreen >>> >>> Risks >>> >>> >>> Interoperability and Compatibility >>> >>> The main risk is that websites that are *only* using this API will be >>> broken. However, the usage of these APIs is low >>> >> >> Do we have stats on usage? >> > > Yes. Here's a discussion from the deprecation trial email: > > https://groups.google.com/a/chromium.org/g/blink-dev/c/jrkCYeUSusg/m/VVrRUlAVAAAJ > > There are 0 records in UMAs usecounters for M126+. > > >> >>> , and the replacement APIs are available and supported across browsers. >>> >>> >>> Starting in M125, this API was disabled by default. A deprecation trial >>> was conducted, allowing registrants to temporarily re-enable the APIs while >>> they update their websites. No negative feedback surfaced during the >>> deprecation trial. The trial is concluding in M131. >>> >> >> Do you know if all deprecation trial participants successfully unprefixed? >> > > I cannot confirm for sure that all of them did. However: > - I have not received any complaints or pushback on the associated bug. > - The number of registrants is very low. > > - I confirmed that 1 properly transitioned (or already handled it). 3-4 > probably already handled fullscreen properly and didn't use the OT token, > but someone registered their origin. > > - I would argue that the rest are unverifiable from dubious registrations, > unsecure websites, and websites which should not be verified on a corporate > network. > > > >> >> >>> >>> Additionally, an enterprise policy was added to allow enterprise >>> customers who >>> >>> couldn't register for an OT to transition away from the API. No feedback >>> was >>> >>> surfaced by enterprise customers either, and the policy will be >>> deprecated and >>> >>> removed at the same time as these APIs will be permanently removed. >>> >>> *Gecko*: N/A Gecko has their own set of prefixed APIs. >>> >>> *WebKit*: Closed Without a Position ( >>> https://github.com/WebKit/standards-positions/issues/306) >>> >>> *Web developers*: No signals >>> >>> *Other signals*: >>> >>> Security >>> >>> The APIs to be deprecated are aliases for the replacement APIs at this >>> point. Removing them should not exercise new code paths, or open up new >>> attach surfaces. >>> >>> >>> WebView application risks >>> >>> Does this intent deprecate or change behavior of existing APIs, such >>> that it has potentially high risk for Android WebView-based applications? >>> >>> None >>> >>> >>> Debuggability >>> >>> None >>> >>> >>> Will this feature be supported on all six Blink platforms (Windows, Mac, >>> Linux, ChromeOS, Android, and Android WebView)?Yes >>> >>> Is this feature fully tested by web-platform-tests >>> <https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md> >>> ?Yes >>> >>> Tests tracking removal of these prefixes: >>> https://wpt.fyi/results/fullscreen/api/historical.html?label=experimental&label=master&aligned&q=%2Ffullscreen%2Fapi%2Fhistorical.html >>> Test covering the new fullscreen APIs: >>> https://wpt.fyi/results/fullscreen/api?label=master&label=experimental&aligned&q=%2Ffullscreen%2Fapi%2F >>> >>> >>> Flag name on about://flagsNone >>> >>> Finch feature namePrefixedVideoFullscreen >>> >>> Requires code in //chrome?False >>> >>> Estimated milestones >>> Shipping on desktop 132 >>> Origin trial desktop first 125 >>> Origin trial desktop last 131 >>> DevTrial on desktop 125 >>> Shipping on Android 132 >>> DevTrial on Android 125 >>> >>> Anticipated spec changes >>> >>> Open questions about a feature may be a source of future web compat or >>> interop issues. Please list open issues (e.g. links to known github issues >>> in the project for the feature specification) whose resolution may >>> introduce web compat/interop risk (e.g., changing to naming or structure of >>> the API in a non-backward-compatible way). >>> None >>> >>> Link to entry on the Chrome Platform Status >>> https://chromestatus.com/feature/5111638103687168?gate=5072706943057920 >>> >>> Links to previous Intent discussionsIntent to Experiment: >>> https://groups.google.com/a/chromium.org/g/blink-dev/c/jrkCYeUSusg >>> >>> >>> This intent message was generated by Chrome Platform Status >>> <https://chromestatus.com/>. >>> >>> -- >>> You received this message because you are subscribed to the Google >>> Groups "blink-dev" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to blink-dev+unsubscr...@chromium.org. >>> To view this discussion visit >>> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CABrVPoZbdQ3pqjxKSzSHEbMs5y4K6qda-Mnm3hqunUyTx1vx3A%40mail.gmail.com >>> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CABrVPoZbdQ3pqjxKSzSHEbMs5y4K6qda-Mnm3hqunUyTx1vx3A%40mail.gmail.com?utm_medium=email&utm_source=footer> >>> . >>> >> -- > You received this message because you are subscribed to the Google Groups > "blink-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to blink-dev+unsubscr...@chromium.org. > To view this discussion visit > https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CABrVPoYX-BKQMn_9s8nYwQpHzuX2N%3DZmhEXtfi497dXS-R%3Db4Q%40mail.gmail.com > <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CABrVPoYX-BKQMn_9s8nYwQpHzuX2N%3DZmhEXtfi497dXS-R%3Db4Q%40mail.gmail.com?utm_medium=email&utm_source=footer> > . > -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org. To view this discussion visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAOMQ%2Bw-9H9ksOhm1TgCC%3D%3DSzBB0178%3Dng5cQ5%2BzYWVh21yyu6Q%40mail.gmail.com.
