Hi all, It appears we never actually proceeded to create the ToT CL to enable this. It turns out this is implemented in a way that impacts both <link rel=prefetch> and speculation rules prefetch, and the latter is causing bugs for a large speculation rules prefetch deployment. See this bug <https://issues.chromium.org/issues/381099745> for more on the speculation rules case.
I plan to submit a CL to enable this on ToT, based on the LGTMs given here. If anyone has any concerns, let me know. I will update ChromeStatus with the proper shipping milestone as well. On Monday, May 1, 2023 at 11:21:18 PM UTC+9 Noam Rosenthal wrote: > On Mon, May 1, 2023 at 5:19 PM Mike Taylor <miketa...@chromium.org> wrote: > >> On 5/1/23 10:16 AM, Noam Rosenthal wrote: >> >> >> On Mon, May 1, 2023 at 5:15 PM Mike Taylor <miketa...@chromium.org> >> wrote: >> >>> Hi Noam, >>> >>> Given the results, I would say you have the LGTMs you need to ship. Are >>> you currently launched at 100% via Finch? LGTM to enable in tip of tree if >>> so. >>> >> No, should I slowly enable finch until it's 100% before enabling? >> >> Up to you - if you're enabled at some % on stable now, ramping up to 100% >> then ToT makes sense. But if you only did the experiment for some period of >> time (i.e., it's at 0% right now), enabling on ToT only is fine too. >> > > Yes it's at 0% on stable (beta+dev for quite a while) but I don't see a > reason to keep the experiment churn. If that's OK I'll proceed with a ToT > CL. > > -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org. To view this discussion visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/9956cb46-3e99-438f-b7d4-458c244e31b1n%40chromium.org.
