Thanks Yi, that sounds great! No LGTMs needed from my perspective, ship away.
On Wed, Jan 8, 2025 at 4:32 PM Yi Xu <yi...@chromium.org> wrote: > We have some tests that implicitly test for it, example: > https://github.com/web-platform-tests/wpt/blob/master/css/css-paint-api/paint2d-image.https.html. > I added a few more tests on PaintCanvas to ensure that it always returns > the same results as Canvas 2D in this cl > <https://chromium-review.googlesource.com/c/chromium/src/+/6078244>. > > Yi Xu > > > On Tue, Jan 7, 2025 at 1:27 PM Chris Harrelson <chris...@chromium.org> > wrote: > >> Hi Yi, >> >> On Tue, Jan 7, 2025 at 10:21 AM Yi Xu <yi...@chromium.org> wrote: >> >>> The ImageSmoothingQuality feature for Canvas 2D was launched in 2015, >>> M54 (Chrome Status Link >>> <https://chromestatus.com/feature/4717415682277376>, original I2S >>> <https://groups.google.com/a/chromium.org/g/blink-dev/c/PuXQBnfWRus/>). >>> This feature was supposed to launch on Paint Canvas as well (Spec >>> <https://drafts.css-houdini.org/css-paint-api-1/#paintrenderingcontext2d>, >>> precisely, the line "PaintRenderingContext2D >>> <https://drafts.css-houdini.org/css-paint-api-1/#paintrenderingcontext2d> >>> includes CanvasImageSmoothing >>> <https://html.spec.whatwg.org/multipage/canvas.html#canvasimagesmoothing> >>> ;"). However, we forgot to remove the flag in Paint Canvas when >>> ImageSmoothingQuality was shipped. So this feature has been well used and >>> tested in Canvas Rendering Context 2D in the past 9 years. That's why we >>> set it as a "Web-Facing Change PSA". >>> >>> For tests: yes, Houtini features currently don't have to have web >>> platform tests. >>> >> >> Why would that be? All such features follow the regular Blink >> intent-to-ship process, which requires a spec and WPT tests, even if other >> browser vendors don't have a positive stance on the feature (in those cases >> the WPT tests can be marked .tentative). >> >> >>> >>> Yi Xu >>> >>> On Mon, Jan 6, 2025 at 4:44 PM Mike Taylor <miketa...@chromium.org> >>> wrote: >>> >>>> On 1/6/25 3:37 PM, Noam Rosenthal wrote: >>>> >>>> On Mon, Jan 6, 2025 at 7:01 PM Chromestatus < >>>> ad...@cr-status.appspotmail.com> wrote: >>>> >>>>> Summary >>>>> >>>>> Add support for the imageSmoothingQuality attribute on Paint Canvas. >>>>> It allows a web developer to choose the quality/performance tradeoff when >>>>> scaling images. There are 3 options in total for imageSmoothingQuality: >>>>> low, medium and high. Chrome platform status entry for its launch on >>>>> Canvas >>>>> 2D: https://chromestatus.com/feature/4717415682277376 >>>>> >>>>> Is this feature fully tested by web-platform-tests >>>>> <https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md> >>>>> ? No >>>>> >>>> >>>> So houdini features don't go through I2S and don't come with web >>>> platform tests? Do they go through some other special process and have >>>> their own tests somewhere? >>>> >>>> It seems like perhaps the wrong feature type was selected, this should >>>> really be an Intent to Ship. Fernando, do you mind re-sending? >>>> >>> -- >>> You received this message because you are subscribed to the Google >>> Groups "blink-dev" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to blink-dev+unsubscr...@chromium.org. >>> To view this discussion visit >>> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAC3hXJf%2BqmD7oikZC4qM7d4HXguzXg0pR0OocAgG65ueey295g%40mail.gmail.com >>> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAC3hXJf%2BqmD7oikZC4qM7d4HXguzXg0pR0OocAgG65ueey295g%40mail.gmail.com?utm_medium=email&utm_source=footer> >>> . >>> >> -- > You received this message because you are subscribed to the Google Groups > "blink-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to blink-dev+unsubscr...@chromium.org. > To view this discussion visit > https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAC3hXJdHqB3CaKTpz_kiOOmpB6ToF-rxkpjs4jOznBC52bQe4g%40mail.gmail.com > <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAC3hXJdHqB3CaKTpz_kiOOmpB6ToF-rxkpjs4jOznBC52bQe4g%40mail.gmail.com?utm_medium=email&utm_source=footer> > . > -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org. To view this discussion visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAOMQ%2Bw_r19-Cf%3D39MOzVOxPnYnB%2B8xmwnnW8uYEDxYaRAYwXZA%40mail.gmail.com.
