Hi Xianzhu and blink-dev@, I'm in the last stages of eliminating Canvas2DLayerBridge. At this point the primary blocker is Canvas2D code that checks for the existence of the bridge as a proxy to determine whether task <foo> is doable.
In putting together a POC changing these callsites, I've hit one issue, which I've isolated down to a minimal CL <https://chromium-review.googlesource.com/c/chromium/src/+/6203066>: If I align CanvasRenderingContext2D::FinalizeFrame() with OffscreenCanvasRenderingContext2D::FinalizeFrame() in being guarded only by the canvas not being null (rather than CanvasRC2D's current check of the canvas *and* its bridge not being null), I hit a PaintUnderInvalidationChecker::CheckNewItem() error <https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/platform/graphics/paint/paint_under_invalidation_checker.cc;l=82-83;drc=27d34700b83f381c62e3a348de2e6dfdc08364b8> in this test <https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/web_tests/fast/canvas/canvas-resize-after-paint-without-layout.html;l=1?q=canvas-resize-after-paint-wit&ss=chromium>. The CL gives the full details. I don't have any real insight into what this failure is signaling at a higher level. Would you be able to provide insight on whether it indicates (a) that the change is actually problematic or (b) that there is a problem to fix with the check and/or test infrastructure that this change is tickling? Thanks, Colin -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org. To view this discussion visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAMGE5NGQdoE_sEbgsSG7WpRPw3euP9iaDYz7VBkDP7xooEWGwg%40mail.gmail.com.
