LGTM3 On Wed, Feb 5, 2025 at 11:16 AM Mike Taylor <miketa...@chromium.org> wrote:
> LGTM2 > On 2/5/25 11:15 AM, Chris Harrelson wrote: > > LGTM1 > > On Wed, Jan 29, 2025 at 1:08 PM Josh Karlin <jkar...@chromium.org> wrote: > >> Contact emails cam...@chromium.org, yao...@chromium.org, >> jkar...@chromium.org, saraak...@google.com >> >> Explainer https://github.com/WICG/shared-storage >> <https://github.com/WICG/shared-storage#:~:text=When%20a%20valid%20serialized%20HTTPS%20URL%20is%20passed%20as%20the%20value%20for%20dataOrigin> >> >> Specification >> Draft spec >> <https://wicg.github.io/shared-storage/#worklet-allowed-header:~:text=If%20this%20is%20of%20type%20SharedStorageWorklet%2C%20has%20cross%2Dorigin%20data%20origin%20is%20true%2C%20and%20data%20origin%20is%20not%20%22script%2Dorigin%22%3A> >> >> Summary >> >> We add support for creating a worklet with a caller-provided x-site data >> origin without having to create a x-site iframe first. For security >> purposes the data origin must opt in to having the given worklet script run >> on its data. >> >> Blink component Blink>Storage>SharedStorage >> <https://issues.chromium.org/issues?q=customfield1222907:%22Blink%3EStorage%3ESharedStorage%22> >> >> TAG review >> https://github.com/w3ctag/design-reviews/issues/747#issuecomment-2583552240 >> >> TAG review status TAG is unsatisfied >> <https://github.com/w3ctag/design-reviews/issues/747> with the >> underlying API >> >> Risks >> >> >> Interoperability and Compatibility >> >> The changes are backwards compatible. >> >> *Gecko*: No signal >> >> *WebKit*: No signal >> >> *Web developers*: Supportive. This feature was requested >> <https://github.com/WICG/shared-storage/issues/127#issuecomment-2093764210> >> (and tested) by an external developer to allow the worklet script to be >> hosted on a cdn while processing data from their primary origin. >> >> >> WebView application risks >> >> Does this intent deprecate or change behavior of existing APIs, such that >> it has potentially high risk for Android WebView-based applications? >> >> NA as not shipped to webview >> >> >> Debuggability >> >> Shared Storage worklets can be inspected within DevTools: Debug Shared >> Storage worklets with DevTools >> <https://developers.google.com/privacy-sandbox/private-advertising/shared-storage/debugging#debug_shared_storage_worklets_with_devtools> >> >> >> Will this feature be supported on all six Blink platforms (Windows, Mac, >> Linux, ChromeOS, Android, and Android WebView)? All but webview >> >> Is this feature fully tested by web-platform-tests >> <https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md> >> ? Yes >> >> Flag name on about://flags None >> >> Finch feature name SharedStorageCreateWorkletCustomDataOrigin >> >> Non-finch justification None >> >> Requires code in //chrome? False >> >> Availability expectation M134 >> >> >> Anticipated spec changes >> None >> >> Link to entry on the Chrome Platform Status >> https://chromestatus.com/feature/4886122881351680?gate=4922008641732608 >> >> This intent message was generated by Chrome Platform Status >> <https://chromestatus.com/>. >> -- >> You received this message because you are subscribed to the Google Groups >> "blink-dev" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to blink-dev+unsubscr...@chromium.org. >> To view this discussion visit >> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAANMuaNQFjb%2B%3DnO84%2BJ22Q6-3mWF%2Bkhrve3JoK14Uy%3D8tw6rPg%40mail.gmail.com >> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAANMuaNQFjb%2B%3DnO84%2BJ22Q6-3mWF%2Bkhrve3JoK14Uy%3D8tw6rPg%40mail.gmail.com?utm_medium=email&utm_source=footer> >> . >> > -- > You received this message because you are subscribed to the Google Groups > "blink-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to blink-dev+unsubscr...@chromium.org. > To view this discussion visit > https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAOMQ%2Bw-K0RfK7z6iY4UH45Tex4-_OPv6DsLAu1BNpSjw47HMkw%40mail.gmail.com > <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAOMQ%2Bw-K0RfK7z6iY4UH45Tex4-_OPv6DsLAu1BNpSjw47HMkw%40mail.gmail.com?utm_medium=email&utm_source=footer> > . > > -- > You received this message because you are subscribed to the Google Groups > "blink-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to blink-dev+unsubscr...@chromium.org. > To view this discussion visit > https://groups.google.com/a/chromium.org/d/msgid/blink-dev/08ede04b-4eee-4b4a-9a42-f08f40053aae%40chromium.org > <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/08ede04b-4eee-4b4a-9a42-f08f40053aae%40chromium.org?utm_medium=email&utm_source=footer> > . > -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org. To view this discussion visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CADsXd2ODppSzfXrA58GpvBv%2BExiRM8ghB2wnJe460X5Rt0MeZw%40mail.gmail.com.