LGTM2 On Thu, Feb 13, 2025 at 2:47 AM Philip Jägenstedt <foo...@chromium.org> wrote:
> LGTM1, a small but useful addition to the platform. > > The spec change was done in https://github.com/whatwg/html/pull/10971 and > everything looks to be in good order. > > On Thu, Feb 13, 2025 at 5:35 AM Domenic Denicola <dome...@chromium.org> > wrote: > >> I'm recusing myself from this Intent, but one small comment about TAG >> review: >> >> On Thursday, February 13, 2025 at 7:51:50 AM UTC+9 Chromestatus wrote: >> >> Contact emails jap...@chromium.org, dome...@chromium.org, >> nrosent...@chromium.org >> >> Explainer https://github.com/WICG/navigation-api/commit/ >> 85edaf1d4d42355b020807cd56f6a22784978c3d >> >> Specification https://html.spec.whatwg.org/multipage/nav-history-apis. >> html#dom-navigateevent-sourceelement >> >> Summary >> >> When a navigation is initiated by an Element (i.e., a link click or a >> form submission), the sourceElement property on the NavigateEvent will be >> the initiating element. >> >> >> Blink component Blink>History >> <https://issues.chromium.org/issues?q=customfield1222907:%22Blink%3EHistory%22> >> >> TAG review >> >> >> In https://github.com/w3ctag/design-reviews/issues/867 the TAG agreed >> this was too small to require TAG review. >> >> >> >> TAG review status Not applicable >> >> Risks >> >> >> Interoperability and Compatibility >> >> None >> >> >> *Gecko*: Positive (https://github.com/mozilla/standards-positions/issues/ >> 1154) >> >> *WebKit*: No signal (https://github.com/WebKit/ >> standards-positions/issues/441) >> >> *Web developers*: Strongly positive (https://github.com/WICG/ >> navigation-api/issues/225) >> >> *Other signals*: >> >> WebView application risks >> >> Does this intent deprecate or change behavior of existing APIs, such that >> it has potentially high risk for Android WebView-based applications? >> >> None >> >> >> Debuggability >> >> None >> >> >> Will this feature be supported on all six Blink platforms (Windows, Mac, >> Linux, ChromeOS, Android, and Android WebView)? Yes >> >> Is this feature fully tested by web-platform-tests >> <https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md> >> ? Yes >> >> Coverage throughout the navigation-api/ WPT suite: >> https://chromium-review.googlesource.com/c/chromium/src/+/4385906 >> >> >> Flag name on about://flags None >> >> Finch feature name NavigateEventSourceElement >> >> Requires code in //chrome? False >> >> Tracking bug https://issues.chromium.org/issues/40281924 >> >> Estimated milestones Shipping on desktop 135 >> >> Anticipated spec changes >> >> Open questions about a feature may be a source of future web compat or >> interop issues. Please list open issues (e.g. links to known github issues >> in the project for the feature specification) whose resolution may >> introduce web compat/interop risk (e.g., changing to naming or structure of >> the API in a non-backward-compatible way). >> None >> >> Link to entry on the Chrome Platform Status https://chromestatus.com/ >> feature/5134353390895104?gate=5104580677599232 >> >> Links to previous Intent discussions Intent to Prototype: >> https://groups.google.com/a/chromium.org/d/msgid/blink- >> dev/CACf%3D2LK%3DHeSj%2B5eQt1O23-TiO6Mai%2Bhdv-E% >> 3DzMguriouYi6gVw%40mail.gmail.com >> >> >> This intent message was generated by Chrome Platform Status >> <https://chromestatus.com>. >> >> -- >> You received this message because you are subscribed to the Google Groups >> "blink-dev" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to blink-dev+unsubscr...@chromium.org. >> To view this discussion visit >> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/428b7dd4-add0-4c07-8dbd-214c90515dabn%40chromium.org >> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/428b7dd4-add0-4c07-8dbd-214c90515dabn%40chromium.org?utm_medium=email&utm_source=footer> >> . >> > -- > You received this message because you are subscribed to the Google Groups > "blink-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to blink-dev+unsubscr...@chromium.org. > To view this discussion visit > https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAARdPYerTmdRpOzuW%2BWxHsS9_1RpZOq2Q4y9vv67rv_YrLevmw%40mail.gmail.com > <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAARdPYerTmdRpOzuW%2BWxHsS9_1RpZOq2Q4y9vv67rv_YrLevmw%40mail.gmail.com?utm_medium=email&utm_source=footer> > . > -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org. To view this discussion visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAOMQ%2Bw9Rk5ocY%2BzwAuq0-H-NOqpDtTZaYkV0bVdnCPXqd9fLJA%40mail.gmail.com.
